From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27715C433F5 for ; Tue, 11 Oct 2022 14:12:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A3C810E803; Tue, 11 Oct 2022 14:11:55 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6E1810E802; Tue, 11 Oct 2022 14:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665497510; x=1697033510; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=J2g4J0KCKmBCJAf+baG6YH8AVSSCVNcQSeIH/j6UtDg=; b=kVMJSVAl+R2qTZ8e61fHE02a09FzTL5aK2Sx+nYO3feiJSe9ZvYx5rDt VqSdSY0TtjR5gBc+Vnceq7PMw60ulWCwuc0RLPMTK8/tmQcxSR7CJ9Q8B JFQzo0RM9m7ogrBKg7mImGOJIaxVMKtqWeS99krvsfmOnb/VmqTlgz02K 9QTJLat1vlTHIyADvj2x0wqas8ZLWWx5w0CDfC2MsT+HI2u+oAnISDRyd N+/9aW1YDKHqJLlE+TQOols7d2N0ZWi/XGASKh51Zj2NETXJzpfPbuHpQ 3A7M1bWPJN5WmnaWaaWmk9usNsDqkk7+8Zf2/L4j1JWwzNO9jHrYCPRtP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="287776456" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="287776456" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 07:11:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="621416039" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="621416039" Received: from milawils-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.183]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 07:11:47 -0700 From: Jani Nikula To: Harry Wentland , dri-devel@lists.freedesktop.org In-Reply-To: <7724d8cc-54b9-1ef9-fe34-42fcbd9b93bf@amd.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <8620697ae6a13bb9202db9edbc26ff30d9f4e2e8.1665496046.git.jani.nikula@intel.com> <7724d8cc-54b9-1ef9-fe34-42fcbd9b93bf@amd.com> Date: Tue, 11 Oct 2022 17:11:44 +0300 Message-ID: <877d16xxen.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 03/15] drm/amd/display: stop using connector->override_edid X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , intel-gfx@lists.freedesktop.org, Xinhui Pan , Christian =?utf-8?Q?K=C3=B6nig?= , amd-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 11 Oct 2022, Harry Wentland wrote: > On 2022-10-11 09:49, Jani Nikula wrote: >> The connector->override_edid flag is strictly for EDID override debugfs >> management, and drivers have no business using it. >>=20 >> Cc: Alex Deucher >> Cc: Christian K=C3=B6nig >> Cc: Xinhui Pan >> Cc: amd-gfx@lists.freedesktop.org >> Signed-off-by: Jani Nikula >>=20 >> --- >>=20 >> I really have no idea what the functional impact here is. I can only >> guess that the intention is to abuse ->override_edid to block EDID >> property updates. In any case, this use needs to go. >>=20 >> It also seems really curious we get here via connector .get_modes hook! >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- >> 1 file changed, 3 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> index 4c73727e0b7d..d96877196a7f 100644 >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >> @@ -6109,7 +6109,6 @@ static void create_eml_sink(struct amdgpu_dm_conne= ctor *aconnector) >> aconnector->base.name); >>=20=20 >> aconnector->base.force =3D DRM_FORCE_OFF; >> - aconnector->base.override_edid =3D false; > > I'm not even sure the DRM_FORCE_OFF business is right. > > Either way, I don't think amdgpu should be messing with > override_edid, so this is > Reviewed-by: Harry Wentland Thanks for the swift review; is it okay to merge this via drm-misc-next along with the rest (once they've been reviewed, of course)? BR, Jani. > > Harry > >> return; >> } >>=20=20 >> @@ -6144,8 +6143,6 @@ static void handle_edid_mgmt(struct amdgpu_dm_conn= ector *aconnector) >> link->verified_link_cap.link_rate =3D LINK_RATE_HIGH2; >> } >>=20=20 >> - >> - aconnector->base.override_edid =3D true; >> create_eml_sink(aconnector); >> } >>=20=20 > --=20 Jani Nikula, Intel Open Source Graphics Center