From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E81FBC433F5 for ; Mon, 16 May 2022 12:12:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 690F210E809; Mon, 16 May 2022 12:12:31 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D870310E7CB for ; Mon, 16 May 2022 12:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652703149; x=1684239149; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=pMa7KpNlLY+9rhBFDT1HoDNNdSbKCl/Igya5BVtyI3c=; b=K+gqH8xRylBunRCc2/M6mL2ynyseuYKsqMXjJ1xidho4uQ3Usc/osx8a 7p7LuF/UT5ku13NRI5ocD9rpzXKtyE+ufMguhr0/7gED7CEedzMGBA2vc PwRRwqDgLkwIQa/6w7q3f1IEBcpj4DFWIwOj/n8ftzXu5lXk4SfB3eRT2 YB8VdwogxFZMheLu0E/RiydkRPIHWAxpQtqjOzRWEtfQroggr3Cks/trm tfS+u+z0NjAWlUEg0y1kcOHg6vAEC6VcLLwBeGkJP1vpMcXvowdixfdme Bj1wnIfFqFiESNUI2zOTr3RpwfG6w5D5PJva+TKMHOsdeMvjD8HGz+dza g==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="258381751" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="258381751" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 05:12:28 -0700 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="699502501" Received: from akuriata-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.145.127]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 05:12:21 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20220503182242.18797-4-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220503182242.18797-1-ville.syrjala@linux.intel.com> <20220503182242.18797-4-ville.syrjala@linux.intel.com> Date: Mon, 16 May 2022 15:12:18 +0300 Message-ID: <877d6lhe1p.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 03/26] drm/i915: Clean up DPLL related debugs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > The debugs in lower level DPLL code don't really provide any > useful extra information AFAICS. Better just streamline the > code and just put the necessary debugs (to identify at which > step the modeset failed) into the higher level code. In > addition we'll get the full state dump as well, which should > hopefully have enough information to figure out what went wrong. > > Reviewed-by: Jani Nikula Yup. > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > --- > drivers/gpu/drm/i915/display/intel_dpll.c | 75 +++++++------------ > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 48 +++--------- > 2 files changed, 35 insertions(+), 88 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/= i915/display/intel_dpll.c > index 7f0538ee2b51..2b3f72550e5a 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll.c > +++ b/drivers/gpu/drm/i915/display/intel_dpll.c > @@ -954,21 +954,12 @@ static int hsw_crtc_get_shared_dpll(struct intel_at= omic_state *state, > intel_atomic_get_new_crtc_state(state, crtc); > struct intel_encoder *encoder =3D > intel_get_crtc_new_encoder(state, crtc_state); > - int ret; >=20=20 > if (DISPLAY_VER(dev_priv) < 11 && > intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI)) > return 0; >=20=20 > - ret =3D intel_reserve_shared_dplls(state, crtc, encoder); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "failed to find PLL for pipe %c\n", > - pipe_name(crtc->pipe)); > - return ret; > - } > - > - return 0; > + return intel_reserve_shared_dplls(state, crtc, encoder); > } >=20=20 > static int dg2_crtc_compute_clock(struct intel_atomic_state *state, > @@ -1135,11 +1126,8 @@ static int ilk_crtc_compute_clock(struct intel_ato= mic_state *state, >=20=20 > if (!crtc_state->clock_set && > !g4x_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&dev_priv->drm, > - "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > ilk_compute_dpll(crtc_state, &crtc_state->dpll, > &crtc_state->dpll); > @@ -1150,24 +1138,14 @@ static int ilk_crtc_compute_clock(struct intel_at= omic_state *state, > static int ilk_crtc_get_shared_dpll(struct intel_atomic_state *state, > struct intel_crtc *crtc) > { > - struct drm_i915_private *dev_priv =3D to_i915(state->base.dev); > struct intel_crtc_state *crtc_state =3D > intel_atomic_get_new_crtc_state(state, crtc); > - int ret; >=20=20 > /* CPU eDP is the only output that doesn't need a PCH PLL of its own. */ > if (!crtc_state->has_pch_encoder) > return 0; >=20=20 > - ret =3D intel_reserve_shared_dplls(state, crtc, NULL); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "failed to find PLL for pipe %c\n", > - pipe_name(crtc->pipe)); > - return ret; > - } > - > - return 0; > + return intel_reserve_shared_dplls(state, crtc, NULL); > } >=20=20 > void vlv_compute_dpll(struct intel_crtc_state *crtc_state) > @@ -1208,7 +1186,6 @@ void chv_compute_dpll(struct intel_crtc_state *crtc= _state) > static int chv_crtc_compute_clock(struct intel_atomic_state *state, > struct intel_crtc *crtc) > { > - struct drm_i915_private *i915 =3D to_i915(state->base.dev); > struct intel_crtc_state *crtc_state =3D > intel_atomic_get_new_crtc_state(state, crtc); > const struct intel_limit *limit =3D &intel_limits_chv; > @@ -1216,10 +1193,8 @@ static int chv_crtc_compute_clock(struct intel_ato= mic_state *state, >=20=20 > if (!crtc_state->clock_set && > !chv_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&i915->drm, "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > chv_compute_dpll(crtc_state); >=20=20 > @@ -1229,7 +1204,6 @@ static int chv_crtc_compute_clock(struct intel_atom= ic_state *state, > static int vlv_crtc_compute_clock(struct intel_atomic_state *state, > struct intel_crtc *crtc) > { > - struct drm_i915_private *i915 =3D to_i915(state->base.dev); > struct intel_crtc_state *crtc_state =3D > intel_atomic_get_new_crtc_state(state, crtc); > const struct intel_limit *limit =3D &intel_limits_vlv; > @@ -1238,7 +1212,6 @@ static int vlv_crtc_compute_clock(struct intel_atom= ic_state *state, > if (!crtc_state->clock_set && > !vlv_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > refclk, NULL, &crtc_state->dpll)) { > - drm_err(&i915->drm, "Couldn't find PLL settings for mode!\n"); > return -EINVAL; > } >=20=20 > @@ -1280,11 +1253,8 @@ static int g4x_crtc_compute_clock(struct intel_ato= mic_state *state, >=20=20 > if (!crtc_state->clock_set && > !g4x_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&dev_priv->drm, > - "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > i9xx_compute_dpll(crtc_state, &crtc_state->dpll, > &crtc_state->dpll); > @@ -1316,11 +1286,8 @@ static int pnv_crtc_compute_clock(struct intel_ato= mic_state *state, >=20=20 > if (!crtc_state->clock_set && > !pnv_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&dev_priv->drm, > - "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > i9xx_compute_dpll(crtc_state, &crtc_state->dpll, > &crtc_state->dpll); > @@ -1352,11 +1319,8 @@ static int i9xx_crtc_compute_clock(struct intel_at= omic_state *state, >=20=20 > if (!crtc_state->clock_set && > !i9xx_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&dev_priv->drm, > - "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > i9xx_compute_dpll(crtc_state, &crtc_state->dpll, > &crtc_state->dpll); > @@ -1390,11 +1354,8 @@ static int i8xx_crtc_compute_clock(struct intel_at= omic_state *state, >=20=20 > if (!crtc_state->clock_set && > !i9xx_find_best_dpll(limit, crtc_state, crtc_state->port_clock, > - refclk, NULL, &crtc_state->dpll)) { > - drm_err(&dev_priv->drm, > - "Couldn't find PLL settings for mode!\n"); > + refclk, NULL, &crtc_state->dpll)) > return -EINVAL; > - } >=20=20 > i8xx_compute_dpll(crtc_state, &crtc_state->dpll, > &crtc_state->dpll); > @@ -1446,6 +1407,7 @@ int intel_dpll_crtc_compute_clock(struct intel_atom= ic_state *state, > struct drm_i915_private *i915 =3D to_i915(state->base.dev); > struct intel_crtc_state *crtc_state =3D > intel_atomic_get_new_crtc_state(state, crtc); > + int ret; >=20=20 > drm_WARN_ON(&i915->drm, !intel_crtc_needs_modeset(crtc_state)); >=20=20 > @@ -1455,7 +1417,14 @@ int intel_dpll_crtc_compute_clock(struct intel_ato= mic_state *state, > if (!crtc_state->hw.enable) > return 0; >=20=20 > - return i915->dpll_funcs->crtc_compute_clock(state, crtc); > + ret =3D i915->dpll_funcs->crtc_compute_clock(state, crtc); > + if (ret) { > + drm_dbg_kms(&i915->drm, "[CRTC:%d:%s] Couldn't calculate DPLL setting= s\n", > + crtc->base.base.id, crtc->base.name); > + return ret; > + } > + > + return 0; > } >=20=20 > int intel_dpll_crtc_get_shared_dpll(struct intel_atomic_state *state, > @@ -1464,6 +1433,7 @@ int intel_dpll_crtc_get_shared_dpll(struct intel_at= omic_state *state, > struct drm_i915_private *i915 =3D to_i915(state->base.dev); > struct intel_crtc_state *crtc_state =3D > intel_atomic_get_new_crtc_state(state, crtc); > + int ret; >=20=20 > drm_WARN_ON(&i915->drm, !intel_crtc_needs_modeset(crtc_state)); >=20=20 > @@ -1476,7 +1446,14 @@ int intel_dpll_crtc_get_shared_dpll(struct intel_a= tomic_state *state, > if (!i915->dpll_funcs->crtc_get_shared_dpll) > return 0; >=20=20 > - return i915->dpll_funcs->crtc_get_shared_dpll(state, crtc); > + ret =3D i915->dpll_funcs->crtc_get_shared_dpll(state, crtc); > + if (ret) { > + drm_dbg_kms(&i915->drm, "[CRTC:%d:%s] Couldn't get a shared DPLL\n", > + crtc->base.base.id, crtc->base.name); > + return ret; > + } > + > + return 0; > } >=20=20 > void > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/= drm/i915/display/intel_dpll_mgr.c > index 4c5c3439b745..64708e874b13 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > @@ -1603,10 +1603,8 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, > break; > } >=20=20 > - if (!ctx.p) { > - DRM_DEBUG_DRIVER("No valid divider found for %dHz\n", clock); > + if (!ctx.p) > return -EINVAL; > - } >=20=20 > /* > * gcc incorrectly analyses that these can be used without being > @@ -2145,19 +2143,14 @@ bxt_ddi_hdmi_pll_dividers(struct intel_crtc_state= *crtc_state, > struct dpll *clk_div) > { > struct drm_i915_private *i915 =3D to_i915(crtc_state->uapi.crtc->dev); > - struct intel_crtc *crtc =3D to_intel_crtc(crtc_state->uapi.crtc); >=20=20 > /* Calculate HDMI div */ > /* > * FIXME: tie the following calculation into > * i9xx_crtc_compute_clock > */ > - if (!bxt_find_best_dpll(crtc_state, clk_div)) { > - drm_dbg(&i915->drm, "no PLL dividers found for clock %d pipe %c\n", > - crtc_state->port_clock, > - pipe_name(crtc->pipe)); > + if (!bxt_find_best_dpll(crtc_state, clk_div)) > return -EINVAL; > - } >=20=20 > drm_WARN_ON(&i915->drm, clk_div->m1 !=3D 2); >=20=20 > @@ -2879,11 +2872,8 @@ static int icl_calc_mg_pll_state(struct intel_crtc= _state *crtc_state, >=20=20 > ret =3D icl_mg_pll_find_divisors(clock, is_dp, use_ssc, &dco_khz, > pll_state, is_dkl); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "Failed to find divisors for clock %d\n", clock); > + if (ret) > return ret; > - } >=20=20 > m1div =3D 2; > m2div_int =3D dco_khz / (refclk_khz * m1div); > @@ -2893,12 +2883,8 @@ static int icl_calc_mg_pll_state(struct intel_crtc= _state *crtc_state, > m2div_int =3D dco_khz / (refclk_khz * m1div); > } >=20=20 > - if (m2div_int > 255) { > - drm_dbg_kms(&dev_priv->drm, > - "Failed to find mdiv for clock %d\n", > - clock); > + if (m2div_int > 255) > return -EINVAL; > - } > } > m2div_rem =3D dco_khz % (refclk_khz * m1div); >=20=20 > @@ -3206,11 +3192,8 @@ static int icl_compute_combo_phy_dpll(struct intel= _atomic_state *state, > else > ret =3D icl_calc_dp_combo_pll(crtc_state, &pll_params); >=20=20 > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "Could not calculate combo PHY PLL state.\n"); > + if (ret) > return ret; > - } >=20=20 > icl_calc_dpll_state(dev_priv, &pll_params, &port_dpll->hw_state); >=20=20 > @@ -3265,12 +3248,8 @@ static int icl_get_combo_phy_dpll(struct intel_ato= mic_state *state, > port_dpll->pll =3D intel_find_shared_dpll(state, crtc, > &port_dpll->hw_state, > dpll_mask); > - if (!port_dpll->pll) { > - drm_dbg_kms(&dev_priv->drm, > - "No combo PHY PLL found for [ENCODER:%d:%s]\n", > - encoder->base.base.id, encoder->base.name); > + if (!port_dpll->pll) > return -EINVAL; > - } >=20=20 > intel_reference_shared_dpll(state, crtc, > port_dpll->pll, &port_dpll->hw_state); > @@ -3293,21 +3272,15 @@ static int icl_compute_tc_phy_dplls(struct intel_= atomic_state *state, >=20=20 > port_dpll =3D &crtc_state->icl_port_dplls[ICL_PORT_DPLL_DEFAULT]; > ret =3D icl_calc_tbt_pll(crtc_state, &pll_params); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "Could not calculate TBT PLL state.\n"); > + if (ret) > return ret; > - } >=20=20 > icl_calc_dpll_state(dev_priv, &pll_params, &port_dpll->hw_state); >=20=20 > port_dpll =3D &crtc_state->icl_port_dplls[ICL_PORT_DPLL_MG_PHY]; > ret =3D icl_calc_mg_pll_state(crtc_state, &port_dpll->hw_state); > - if (ret) { > - drm_dbg_kms(&dev_priv->drm, > - "Could not calculate MG PHY PLL state.\n"); > + if (ret) > return ret; > - } >=20=20 > return 0; > } > @@ -3328,10 +3301,8 @@ static int icl_get_tc_phy_dplls(struct intel_atomi= c_state *state, > port_dpll->pll =3D intel_find_shared_dpll(state, crtc, > &port_dpll->hw_state, > BIT(DPLL_ID_ICL_TBTPLL)); > - if (!port_dpll->pll) { > - drm_dbg_kms(&dev_priv->drm, "No TBT-ALT PLL found\n"); > + if (!port_dpll->pll) > return -EINVAL; > - } > intel_reference_shared_dpll(state, crtc, > port_dpll->pll, &port_dpll->hw_state); >=20=20 > @@ -3344,7 +3315,6 @@ static int icl_get_tc_phy_dplls(struct intel_atomic= _state *state, > BIT(dpll_id)); > if (!port_dpll->pll) { > ret =3D -EINVAL; > - drm_dbg_kms(&dev_priv->drm, "No MG PHY PLL found\n"); > goto err_unreference_tbt_pll; > } > intel_reference_shared_dpll(state, crtc, --=20 Jani Nikula, Intel Open Source Graphics Center