From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 119EFC433F5 for ; Mon, 2 May 2022 11:49:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE01810EB79; Mon, 2 May 2022 11:49:52 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95E3C10E995; Mon, 2 May 2022 11:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651492190; x=1683028190; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=ahcGSVFBbDw+47hsgxMhBh6EUdikBk/3EyASncuqTcM=; b=ZeL02RUfkdRg453mNO1Ax+mF5KlyugT4tnulyv3SEZaprwOHSLUh9Dz8 5H9P+PR6TRvOE9gT9MP3e+bJX/RZpNVIvafuSVbheeqkcbfM9afpNn2P4 lrU11Ifivz/0sKybKAPGYeoTltPchVZBLN2ERuHRFnKivlpT867M6STer WiSAjPcE9mhj/E2yP3FSseHREoFYokFFYiRNt0uInDM8uDn0mKtohgrhP BD5DXFlikpE5boC8YcIgRHcxJcm9lmOi7xMGjRJG7ity8QJ1ZnHYsmgkm 5eZ9ezr6d2qKuh9ic4BRGQLJJWIb4b6b1Xw1oYi+1Zok0Cri7YAUuRY+S Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10334"; a="266038786" X-IronPort-AV: E=Sophos;i="5.91,190,1647327600"; d="scan'208";a="266038786" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 04:49:50 -0700 X-IronPort-AV: E=Sophos;i="5.91,190,1647327600"; d="scan'208";a="583658713" Received: from wagoleb-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.155.30]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 04:49:47 -0700 From: Jani Nikula To: "Murthy, Arun R" , "Modem, Bhanuprakash" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "ville.syrjala@linux.intel.com" , "harry.wentland@amd.com" , "Sharma, Swati2" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220411095129.1652096-1-bhanuprakash.modem@intel.com> <20220411095129.1652096-2-bhanuprakash.modem@intel.com> Date: Mon, 02 May 2022 14:49:44 +0300 Message-ID: <877d74rw6f.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 29 Apr 2022, "Murthy, Arun R" wrote: >> +static int output_bpc_show(struct seq_file *m, void *data) { > > Can we have a meaningful name instead of 'm' ? > Upon changing this parameter name, you can have my > Reviewed-By: Arun R Murthy Please keep 'm'. It's by far the most common name for struct seq_file * in the kernel: $ git grep -o "struct seq_file \*[a-zA-Z0-9_]\+" | sed 's/^.*:struct seq_file \*//' | sort | uniq -c | sort -rn | head -5 2212 m 1219 seq 1126 s 135 sf 121 file BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center