From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h
Date: Mon, 10 Jan 2022 11:59:05 +0200 [thread overview]
Message-ID: <877db7c3o6.fsf@intel.com> (raw)
In-Reply-To: <Ydh0B45uYhxMmznT@mdroper-desk1.amr.corp.intel.com>
On Fri, 07 Jan 2022, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Fri, Jan 07, 2022 at 11:49:49AM +0200, Jani Nikula wrote:
>> The PCI config space registers don't really belong next to the MMIO
>> register definitions.
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
> ...
>> diff --git a/drivers/gpu/drm/i915/intel_pci_config.h b/drivers/gpu/drm/i915/intel_pci_config.h
>> new file mode 100644
>> index 000000000000..db35b91d36e0
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/intel_pci_config.h
>> @@ -0,0 +1,85 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2021 Intel Corporation
>
> It's 2022 now!
They were written in 2021, but I guess it's the first posting that
matters. Fixed in v2.
>
> Otherwise,
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Thanks!
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-01-10 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:49 [Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h Jani Nikula
2022-01-07 9:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: move VGA registers to intel_vga.c Jani Nikula
2022-01-07 17:24 ` Matt Roper
2022-01-10 9:58 ` Jani Nikula
2022-01-07 9:49 ` [Intel-gfx] [PATCH 3/3] drm/i915: split out vlv sideband registers from i915_reg.h Jani Nikula
2022-01-07 17:30 ` Matt Roper
2022-01-07 10:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: split out PCI config space " Patchwork
2022-01-07 10:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-07 10:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-07 17:10 ` [Intel-gfx] [PATCH 1/3] " Matt Roper
2022-01-10 9:59 ` Jani Nikula [this message]
2022-01-07 17:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877db7c3o6.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox