From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BBA6C433F5 for ; Mon, 10 Jan 2022 09:59:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D2D312B744; Mon, 10 Jan 2022 09:59:12 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B412C12B744 for ; Mon, 10 Jan 2022 09:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641808751; x=1673344751; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=Cz587lX8psdvI14vKci1/WtbxfHPjluS9NtPoG3Sxu0=; b=P2w8yLk5fUzPSezwY/tE3kSc++7J94BRpvRVIWjkV5FOISwzcVERX9LA nhNMO59RLMRvO44PXBXXY8WVQp34wFvjDLpqF6NzxKpQD+cv4vSfgpZza OWk1nXZgOX2SXBi50CdXSap1qBVV8rUGC5RK3kz0AhanFe78H/+yXbMd8 9cehkOmIM+Vw6Kdgo8lf/tIGLw6FIz0z9/L7lU6+iNUI3DVgYZbfjEesd XPwzkUuAtnzfSGubhVByedkIPfKlrjjdbsGwNbr6pl1D2Sk5o9l5/Yck+ 0WDE8Rkix+9g5AEtDkhnGs1C1eAQMb4nA21cP7x46jzxKuK6BY3CjhIem w==; X-IronPort-AV: E=McAfee;i="6200,9189,10222"; a="267521132" X-IronPort-AV: E=Sophos;i="5.88,276,1635231600"; d="scan'208";a="267521132" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 01:59:10 -0800 X-IronPort-AV: E=Sophos;i="5.88,276,1635231600"; d="scan'208";a="474075103" Received: from bdoyle2-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.26.184]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 01:59:08 -0800 From: Jani Nikula To: Matt Roper In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220107094951.96181-1-jani.nikula@intel.com> Date: Mon, 10 Jan 2022 11:59:05 +0200 Message-ID: <877db7c3o6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 07 Jan 2022, Matt Roper wrote: > On Fri, Jan 07, 2022 at 11:49:49AM +0200, Jani Nikula wrote: >> The PCI config space registers don't really belong next to the MMIO >> register definitions. >>=20 >> Cc: Matt Roper >> Signed-off-by: Jani Nikula >> --- > ... >> diff --git a/drivers/gpu/drm/i915/intel_pci_config.h b/drivers/gpu/drm/i= 915/intel_pci_config.h >> new file mode 100644 >> index 000000000000..db35b91d36e0 >> --- /dev/null >> +++ b/drivers/gpu/drm/i915/intel_pci_config.h >> @@ -0,0 +1,85 @@ >> +/* SPDX-License-Identifier: MIT */ >> +/* >> + * Copyright =C2=A9 2021 Intel Corporation > > It's 2022 now! They were written in 2021, but I guess it's the first posting that matters. Fixed in v2. > > Otherwise, > > Reviewed-by: Matt Roper Thanks! BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center