From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7548C433E0 for ; Fri, 3 Jul 2020 13:24:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8040F20760 for ; Fri, 3 Jul 2020 13:24:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8040F20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FB79892D6; Fri, 3 Jul 2020 13:24:43 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2F43892D6 for ; Fri, 3 Jul 2020 13:24:41 +0000 (UTC) IronPort-SDR: 6aUgN8gfui4NIL0y14k/pzFxNaR6TA0NEKHPw6cWNypKuqE5uHB/D6MQXIfwIkYqhtZw+X7cKI oBZSet1oPybA== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="134601306" X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="134601306" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2020 06:24:40 -0700 IronPort-SDR: Yx3/Rwgwz3gQR5dil2Eg6PJqzvrEuqtcPB3dBLbj64dAe+K2V8p1zM4hbCVvL40kCNsp3Eh0UL if3AMC9JBp0Q== X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="482375752" Received: from kroegerb-mobl.ger.corp.intel.com (HELO localhost) ([10.252.39.221]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2020 06:24:38 -0700 From: Jani Nikula To: Lucas De Marchi In-Reply-To: <20200701153522.dh4jhbml5gdenu5o@ldmartin-desk1> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200625001120.22810-1-lucas.demarchi@intel.com> <20200625001120.22810-3-lucas.demarchi@intel.com> <87y2o4lf9h.fsf@intel.com> <20200701153522.dh4jhbml5gdenu5o@ldmartin-desk1> Date: Fri, 03 Jul 2020 16:24:36 +0300 Message-ID: <877dvkk9yj.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/display: fix comment on skl straps X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 01 Jul 2020, Lucas De Marchi wrote: > On Tue, Jun 30, 2020 at 06:55:38PM +0300, Jani Nikula wrote: >>On Wed, 24 Jun 2020, Lucas De Marchi wrote: >>> We are not checking for specific SKUs and feedback from HW team is that >>> it may not work since it was supposed to be fixed by the same time >>> straps stopped to be used. So, just update comment. >>> >>> v2: Instead of removing the check, just update the comment since >>> feedback from HW team was that it actually may not work >>> >>> Signed-off-by: Lucas De Marchi >> >>Acked-by: Jani Nikula > > is an ack sufficient for merging a comment-only change? Yes, but Reviewed-by: Jani Nikula if you insist. ;) > > Lucas De Marchi > >> >>> --- >>> drivers/gpu/drm/i915/display/intel_display.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >>> index 49772c82a299..effd6b65f270 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_display.c >>> +++ b/drivers/gpu/drm/i915/display/intel_display.c >>> @@ -16863,8 +16863,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) >>> >>> /* >>> * Haswell uses DDI functions to detect digital outputs. >>> - * On SKL pre-D0 the strap isn't connected, so we assume >>> - * it's there. >>> + * On SKL pre-D0 the strap isn't connected. Later SKUs may or >>> + * may not have it - it was supposed to be fixed by the same >>> + * time we stopped using straps. Assume it's there. >>> */ >>> found = intel_de_read(dev_priv, DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED; >>> /* WaIgnoreDDIAStrap: skl */ >> >>-- >>Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx