From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0067C10DCE for ; Thu, 12 Mar 2020 16:57:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A779206F1 for ; Thu, 12 Mar 2020 16:57:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A779206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FC386EB03; Thu, 12 Mar 2020 16:57:19 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16F666EB03 for ; Thu, 12 Mar 2020 16:57:18 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 09:57:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,545,1574150400"; d="scan'208";a="416007937" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga005.jf.intel.com with ESMTP; 12 Mar 2020 09:57:11 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id ABDB15C1DD1; Thu, 12 Mar 2020 18:55:48 +0200 (EET) From: Mika Kuoppala To: Matt Roper , intel-gfx@lists.freedesktop.org In-Reply-To: <20200311162300.1838847-7-matthew.d.roper@intel.com> References: <20200311162300.1838847-1-matthew.d.roper@intel.com> <20200311162300.1838847-7-matthew.d.roper@intel.com> Date: Thu, 12 Mar 2020 18:55:48 +0200 Message-ID: <877dzp1pij.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Add Wa_1605460711 / Wa_1408767742 to ICL and EHL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Matt Roper writes: > This workaround appears under two different numbers (and with somewhat > confused stepping applicability on ICL). Ultimately it appears we > should just implement this for all stepping of ICL and EHL. > > Note that this is identical to Wa_1407928979:tgl that already exists in > our driver too...yet another number referencing the same actual > workaround. > > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index cbfc8d5ebb3e..5176ad1a3976 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -1487,6 +1487,14 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) > wa_write_or(wal, > SUBSLICE_UNIT_LEVEL_CLKGATE, > GWUNIT_CLKGATE_DIS); > + > + /* > + * Wa_1408767742:icl[a2..forever],ehl[all] > + * Wa_1605460711:icl[a0..c0] > + */ > + wa_write_or(wal, > + GEN7_FF_THREAD_MODE, > + GEN12_FF_TESSELATION_DOP_GATE_DISABLE); The gen12 assignment is amusing artefact. But we learn these things late sometimes. And when we do, we should try to proactively look one gen back. This was supposed to be fixed in d0, then re-established. Reviewed-by: Mika Kuoppala > } > > if (IS_GEN_RANGE(i915, 9, 12)) { > -- > 2.24.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx