[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: make a gt sysfs group and move power management files

Patchwork
2020-02-08T15:15:08Z

== Series Details ==

Series: drm/i915/gt: make a gt sysfs group and move power management files
URL : https://patchwork.freedesktop.org/series/73190/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e572bceec010 drm/i915/gt: make a gt sysfs group and move power management files
-:71: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
new file mode 100644

-:118: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#118: FILE: drivers/gpu/drm/i915/gt/sysfs_gt.c:43:
+ gt->kobj = kobject_create_and_add("gt",
+ kobject_get(&gt->i915->drm.primary->kdev->kobj));

-:512: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP0_freq_mhz_show'
#512: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:344:
+static DEVICE_ATTR(gt_RP0_freq_mhz, 0444, gt_rp_mhz_show, NULL);

-:513: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP1_freq_mhz_show'
#513: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:345:
+static DEVICE_ATTR(gt_RP1_freq_mhz, 0444, gt_rp_mhz_show, NULL);

-:514: CHECK:CAMELCASE: Avoid CamelCase: <gt_RPn_freq_mhz>
#514: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:346:
+static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL);

-:514: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RPn_freq_mhz_show'
#514: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:346:
+static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL);

-:529: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_gt_RPn_freq_mhz>
#529: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:361:
+ else if (attr == &dev_attr_gt_RPn_freq_mhz)

-:532: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#532: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:364:
+ BUG();

total: 0 errors, 5 warnings, 3 checks, 970 lines checked