Re: [Intel-gfx] [PATCH] drm/i915/gt: make a gt sysfs group and move power management files

Andi Shyti
2020-02-09T15:50:57Z

Hi Jani,

> > void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private *i915)
> > {
> > @@ -321,6 +322,7 @@ void intel_gt_driver_register(struct intel_gt *gt)
> > intel_rps_driver_register(&gt->rps);
> >
> > debugfs_gt_register(gt);
>
> Yikes, when did this happen? Not good. We don't own the debugfs
> "namespace" prefix.
>
> > + sysfs_gt_register(gt);
>
> Ditto for the sysfs namespace prefix.
>
> I guess it's not likely debugfs or sysfs would add functions named like
> that, but if they did, they'd be right to call these names a violation
> of their namespace.
>
> I have been promoting the idea of naming functions somewhat based on the
> name of the file they reside in... so do we want to name the files like
> this either?

Yes, you're right here. I will rename the "debugfs" function and
fix the sysfs in my next patch.

Thanks,
Andi