From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/i915: Serialise concurrent calls to i915_gem_set_wedged()
Date: Wed, 16 Jan 2019 17:04:32 +0200 [thread overview]
Message-ID: <877ef4y77j.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <154763087509.30063.17176411973013494888@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Chris Wilson (2019-01-15 12:05:27)
>> Quoting Mika Kuoppala (2019-01-15 11:56:11)
>> > Chris Wilson <chris@chris-wilson.co.uk> writes:
>> >
>> > > Make i915_gem_set_wedged() and i915_gem_unset_wedged() behaviour more
>> > > consistently if called concurrently.
>> >
>> > More is needed in here. The purpose is to make them wait in turns
>> > on top of mutex, instead of racing on the bit? Where is
>> > the inconsistency tho.
>>
>> We report set-wedged multiple times on failure paths. Worse is when we
>> report set-wedged multiple times simultaneously.
>
> I've been contemplating just moving the reporting inside the test-bit
> serialisation, but I kept resisting. This issue has been nagging at me
> ever since using the bit for loose serialisation; you either fix a race
> or live to regret it.
That part I can agree with. Now it is all contained so if it coalesces
on reports, it will be alarming :)
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-16 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 21:04 Mika's reward Chris Wilson
2019-01-14 21:04 ` [PATCH 1/8] drm/i915: Serialise concurrent calls to i915_gem_set_wedged() Chris Wilson
2019-01-15 11:56 ` Mika Kuoppala
2019-01-15 12:05 ` Chris Wilson
2019-01-16 9:27 ` Chris Wilson
2019-01-16 15:04 ` Mika Kuoppala [this message]
2019-01-14 21:04 ` [PATCH 2/8] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Chris Wilson
2019-01-14 21:04 ` [PATCH 3/8] drm/i915: Pull all the reset functionality together into i915_reset.c Chris Wilson
2019-01-16 15:06 ` Mika Kuoppala
2019-01-16 15:31 ` Chris Wilson
2019-01-14 21:04 ` [PATCH 4/8] drm/i915: Make all GPU resets atomic Chris Wilson
2019-01-17 14:14 ` Mika Kuoppala
2019-01-14 21:04 ` [PATCH 5/8] drm/i915/guc: Disable global reset Chris Wilson
2019-01-17 14:24 ` Mika Kuoppala
2019-01-17 18:27 ` Daniele Ceraolo Spurio
2019-01-14 21:04 ` [PATCH 6/8] drm/i915: Remove GPU reset dependence on struct_mutex Chris Wilson
2019-01-14 21:04 ` [PATCH 7/8] drm/i915/selftests: Trim struct_mutex duration for set-wedged selftest Chris Wilson
2019-01-14 21:04 ` [PATCH 8/8] drm/i915: Issue engine resets onto idle engines Chris Wilson
2019-01-14 21:26 ` ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Serialise concurrent calls to i915_gem_set_wedged() Patchwork
2019-01-14 21:59 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ef4y77j.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).