Re: [PATCH 3/9] drm/i915: Compact modes in intel_dump_pipe_config

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 27 Apr 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Use the new drm_mode_debug_printmodeline_raw to log the
> prefix and mode on the same line.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index b7cb632a2a31..1362a1270c9f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12167,10 +12167,15 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
>  		      pipe_config->has_audio,
>  		      pipe_config->has_infoframe);
>  
> -	DRM_DEBUG_KMS("requested mode:\n");
> -	drm_mode_debug_printmodeline(&pipe_config->base.mode);
> -	DRM_DEBUG_KMS("adjusted mode:\n");
> -	drm_mode_debug_printmodeline(&pipe_config->base.adjusted_mode);
> +	DRM_DEBUG_KMS("requested mode: ");
> +	drm_mode_debug_printmodeline_raw(&pipe_config->base.mode);
> +	if (drm_debug & DRM_UT_KMS)

In addition to the other complaints, I also don't like to spread the use
of DRM_UT_* macros outside of drm core.

BR,
Jani.

> +		printk("\n");
> +	DRM_DEBUG_KMS("adjusted mode: ");
> +	drm_mode_debug_printmodeline_raw(&pipe_config->base.adjusted_mode);
> +	if (drm_debug & DRM_UT_KMS)
> +		printk("\n");
> +
>  	intel_dump_crtc_timings(&pipe_config->base.adjusted_mode);
>  	DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock);
>  	DRM_DEBUG_KMS("pipe src size: %dx%d\n",

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx