From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/6] drm/i915: Skip .get_backlight() when backlight isn't enabled Date: Fri, 07 Nov 2014 15:24:13 +0200 Message-ID: <877fz716v6.fsf@intel.com> References: <1415351764-3514-3-git-send-email-ville.syrjala@linux.intel.com> <1415366325-12765-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 13B516E73C for ; Fri, 7 Nov 2014 05:24:46 -0800 (PST) In-Reply-To: <1415366325-12765-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwNyBOb3YgMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IE9uIFZMVi9DSFYgd2hlbiB0aGUgZGlzcGxheSBpcyBvZmYsIHdlIGNhbid0IHJlYWQgb3V0 IHRoZSBjdXJyZW50Cj4gYmFja2xpZ2h0IGxldmVsIGZyb20gdGhlIGhhcmR3YXJlIHNpbmNlIHdl IGhhdmUgbm8gcGlwZSB0byBkbyBzby4KPiBDdXJyZW50bHkgd2UgZW5kIHVwIHJlYWRpbmcgYSBi aWd1cyByZWdpc3RlciBkdWUgdG8gcGFzc2luZwo+IElOVkFMSURfUElQRSB0byBWTFZfQkxDX1BX TV9DVEwoKS4KPgo+IFNraXAgdGhlIGVudGlyZSAuZ2V0X2JhY2tsaWdodCgpIGNhbGwgaWYgdGhl IGJhY2tsaWdodCBpc24ndCBlbmFibGVkCj4gYWNjb3JkaW5nIHRvIGJhY2tsaWdodC5lbmFibGVk Lgo+Cj4gVGhpcyBwcm9ibGVtIGNhbiBiZSByZXByb2R1Y2VkIHNpbXBseSBieSByZWFkaW5nIHRo ZSBiYWNrbGlnaHQgZGV2aWNlCj4gYWN0dWFsX2JyaWdodG5lc3MgZmlsZSB3aGlsZSB0aGUgZGlz cGxheSBpcyBvZmYuCj4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4K PiBTdWdnZXN0ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyB8IDkgKysrKysrLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBpbmRleCBlZjY0NmIxLi40ZWM2YzJmIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gQEAgLTUzOSwxMiArNTM5LDE1IEBAIHN0YXRp YyB1MzIgaW50ZWxfcGFuZWxfZ2V0X2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpj b25uZWN0b3IpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmJh c2UuZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiAtCXUzMiB2YWw7Cj4gKwlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmNv bm5lY3Rvci0+cGFuZWw7Cj4gKwl1MzIgdmFsID0gMDsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZf cHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+ICAKPiAtCXZhbCA9IGRldl9wcml2LT5kaXNwbGF5Lmdl dF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiAtCXZhbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJp Z2h0bmVzcyhjb25uZWN0b3IsIHZhbCk7Cj4gKwlpZiAocGFuZWwtPmJhY2tsaWdodC5lbmFibGVk KSB7Cj4gKwkJdmFsID0gZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2JhY2tsaWdodChjb25uZWN0b3Ip Owo+ICsJCXZhbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZh bCk7Cj4gKwl9Cj4gIAo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2sp Owo+ICAKPiAtLSAKPiAyLjAuNAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK