From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences Date: Thu, 30 Oct 2014 10:51:36 +0200 Message-ID: <877fzij5yf.fsf@intel.com> References: <7441f15f037714b64fa4d0039e2d2332546ff541.1414419818.git.jani.nikula@intel.com> <1414497789-6224-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 931306E6B1 for ; Thu, 30 Oct 2014 01:52:00 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyOSBPY3QgMjAxNCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAZ21haWwuY29t PiB3cm90ZToKPiBPbiBUdWUsIE9jdCAyOCwgMjAxNCBhdCA1OjAzIEFNLCBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPj4gVGhlcmUncyBzb21lIHNlcmlvdXMgY29u ZnVzaW9uIHJlZ2FyZGluZyBFTEQgdmFsaWQgYml0IHRoYXQgZ2V0cyBzZXQgYW5kCj4+IGNsZWFy ZWQgYmFjayBhbmQgZm9ydGggZXRjLiBSZXdyaXRlIGl0IGFsbCBiYXNlZCBvbiB0aGUgZG9jdW1l bnRlZCBhdWRpbwo+PiBjb2RlYyBlbmFibGUvZGlzYWJsZSBzZXF1ZW5jZXMuCj4+Cj4+IHYzOiBy ZXBsYWNlIHZibGFuayB3YWl0IHdpdGggYSBjb21tZW50Cj4KPiBXaHkgZGlkIHlvdSByZW1vdmUg dGhlIHZibGFuayB3YWl0PyBzZWVtZWQgY29ycmVjdCBieSBzcGVjIHlvdQo+IHBvaW50ZWQuLi4g YXQgbGVhc3QgbG9va2luZyB0byBCRFcgb25lLi4uCgpUaGUgcHJvYmxlbSBpcywgd2UgY2FuJ3Qg ZG8gdGhhdCBjYWxsIGluIG1vZGVzZXQgcGF0aCB3aXRob3V0IGdldHRpbmcgYQp3YXJuaW5nLCBJ SVVDIHRoaXMgaXMgc2luY2Ugd2UgbW92ZWQgdG8gdGhlIGRybSB2Ymxhbmsgd2FpdApjYWxsLiBE YW5pZWw/CgpCUiwKSmFuaS4KCgoKCj4KPgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3Vs YSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2F1ZGlvLmMgfCAxMTAgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDY0IGRlbGV0aW9ucygtKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPj4gaW5kZXggODIxNTE0Yzk1MjI5Li4y ZTdkNDI4NzhiOWQgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1 ZGlvLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYwo+PiBAQCAt MTMyLDE0ICsxMzIsMjYgQEAgc3RhdGljIHZvaWQgZzR4X2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+Pgo+PiAgc3RhdGljIHZvaWQgaHN3X2F1ZGlv X2NvZGVjX2Rpc2FibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4+ICB7Cj4+IC0g ICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGVuY29kZXItPmJhc2UuZGV2Owo+PiAtICAg ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7 Cj4+IC0gICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjID0gZW5jb2Rlci0+YmFzZS5jcnRjOwo+ PiAtICAgICAgIGVudW0gcGlwZSBwaXBlID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPj4g KyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmNvZGVyLT5iYXNl LmRldi0+ZGV2X3ByaXZhdGU7Cj4+ICsgICAgICAgc3RydWN0IGludGVsX2NydGMgKmludGVsX2Ny dGMgPSB0b19pbnRlbF9jcnRjKGVuY29kZXItPmJhc2UuY3J0Yyk7Cj4+ICsgICAgICAgZW51bSBw aXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+PiAgICAgICAgIHVpbnQzMl90IHRtcDsKPj4K Pj4gKyAgICAgICBEUk1fREVCVUdfS01TKCJEaXNhYmxlIGF1ZGlvIGNvZGVjIG9uIHBpcGUgJWNc biIsIHBpcGVfbmFtZShwaXBlKSk7Cj4+ICsKPj4gKyAgICAgICAvKiBEaXNhYmxlIHRpbWVzdGFt cHMgKi8KPj4gKyAgICAgICB0bXAgPSBJOTE1X1JFQUQoSFNXX0FVRF9DRkcocGlwZSkpOwo+PiAr ICAgICAgIHRtcCAmPSB+QVVEX0NPTkZJR19OX1ZBTFVFX0lOREVYOwo+PiArICAgICAgIHRtcCB8 PSBBVURfQ09ORklHX05fUFJPR19FTkFCTEU7Cj4+ICsgICAgICAgdG1wICY9IH5BVURfQ09ORklH X1VQUEVSX05fTUFTSzsKPj4gKyAgICAgICB0bXAgJj0gfkFVRF9DT05GSUdfTE9XRVJfTl9NQVNL Owo+PiArICAgICAgIGlmIChpbnRlbF9waXBlX2hhc190eXBlKGludGVsX2NydGMsIElOVEVMX09V VFBVVF9ESVNQTEFZUE9SVCkpCj4+ICsgICAgICAgICAgICAgICB0bXAgfD0gQVVEX0NPTkZJR19O X1ZBTFVFX0lOREVYOwo+PiArICAgICAgIEk5MTVfV1JJVEUoSFNXX0FVRF9DRkcocGlwZSksIHRt cCk7Cj4+ICsKPj4gKyAgICAgICAvKiBJbnZhbGlkYXRlIEVMRCAqLwo+PiAgICAgICAgIHRtcCA9 IEk5MTVfUkVBRChIU1dfQVVEX1BJTl9FTERfQ1BfVkxEKTsKPj4gLSAgICAgICB0bXAgJj0gfigo QVVESU9fT1VUUFVUX0VOQUJMRV9BIHwgQVVESU9fRUxEX1ZBTElEX0EpIDw8IChwaXBlICogNCkp Owo+PiArICAgICAgIHRtcCAmPSB+KEFVRElPX0VMRF9WQUxJRF9BIDw8IChwaXBlICogNCkpOwo+ PiAgICAgICAgIEk5MTVfV1JJVEUoSFNXX0FVRF9QSU5fRUxEX0NQX1ZMRCwgdG1wKTsKPj4gIH0K Pj4KPj4gQEAgLTE0OSw3NyArMTYxLDQ3IEBAIHN0YXRpYyB2b2lkIGhzd19hdWRpb19jb2RlY19l bmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gIHsKPj4gICAgICAgICBz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBjb25uZWN0b3ItPmRldi0+ZGV2X3By aXZhdGU7Cj4+ICAgICAgICAgc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRl bF9jcnRjKGVuY29kZXItPmJhc2UuY3J0Yyk7Cj4+IC0gICAgICAgdWludDhfdCAqZWxkID0gY29u bmVjdG9yLT5lbGQ7Cj4+IC0gICAgICAgdWludDMyX3QgZWxkdjsKPj4gKyAgICAgICBlbnVtIHBp cGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4+ICsgICAgICAgY29uc3QgdWludDhfdCAqZWxk ID0gY29ubmVjdG9yLT5lbGQ7Cj4+ICAgICAgICAgdWludDMyX3QgdG1wOwo+PiAgICAgICAgIGlu dCBsZW4sIGk7Cj4+IC0gICAgICAgZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+ PiAtICAgICAgIGVudW0gcG9ydCBwb3J0Owo+PiAtICAgICAgIGludCBoZG1pd19oZG1pZWRpZCA9 IEhTV19BVURfRURJRF9EQVRBKHBpcGUpOwo+PiAtICAgICAgIGludCBhdWRfY250bF9zdCA9IEhT V19BVURfRElQX0VMRF9DVFJMKHBpcGUpOwo+PiAtICAgICAgIGludCBhdWRfY29uZmlnID0gSFNX X0FVRF9DRkcocGlwZSk7Cj4+IC0gICAgICAgaW50IGF1ZF9jbnRybF9zdDIgPSBIU1dfQVVEX1BJ Tl9FTERfQ1BfVkxEOwo+Pgo+PiAtICAgICAgIC8qIEF1ZGlvIG91dHB1dCBlbmFibGUgKi8KPj4g LSAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJIRE1JIGF1ZGlvOiBlbmFibGUgY29kZWNcbiIpOwo+ PiAtICAgICAgIHRtcCA9IEk5MTVfUkVBRChhdWRfY250cmxfc3QyKTsKPj4gLSAgICAgICB0bXAg fD0gKEFVRElPX09VVFBVVF9FTkFCTEVfQSA8PCAocGlwZSAqIDQpKTsKPj4gLSAgICAgICBJOTE1 X1dSSVRFKGF1ZF9jbnRybF9zdDIsIHRtcCk7Cj4+IC0gICAgICAgUE9TVElOR19SRUFEKGF1ZF9j bnRybF9zdDIpOwo+PiAtCj4+IC0gICAgICAgLyogU2V0IEVMRCB2YWxpZCBzdGF0ZSAqLwo+PiAt ICAgICAgIHRtcCA9IEk5MTVfUkVBRChhdWRfY250cmxfc3QyKTsKPj4gLSAgICAgICBEUk1fREVC VUdfRFJJVkVSKCJIRE1JIGF1ZGlvOiBwaW4gZWxkIHZsZCBzdGF0dXM9MHglMDh4XG4iLCB0bXAp Owo+PiAtICAgICAgIHRtcCB8PSAoQVVESU9fRUxEX1ZBTElEX0EgPDwgKHBpcGUgKiA0KSk7Cj4+ IC0gICAgICAgSTkxNV9XUklURShhdWRfY250cmxfc3QyLCB0bXApOwo+PiAtICAgICAgIHRtcCA9 IEk5MTVfUkVBRChhdWRfY250cmxfc3QyKTsKPj4gLSAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJI RE1JIGF1ZGlvOiBlbGQgdmxkIHN0YXR1cz0weCUwOHhcbiIsIHRtcCk7Cj4+IC0KPj4gLSAgICAg ICAvKiBFbmFibGUgSERNSSBtb2RlICovCj4+IC0gICAgICAgdG1wID0gSTkxNV9SRUFEKGF1ZF9j b25maWcpOwo+PiAtICAgICAgIERSTV9ERUJVR19EUklWRVIoIkhETUkgYXVkaW86IGF1ZGlvIGNv bmY6IDB4JTA4eFxuIiwgdG1wKTsKPj4gLSAgICAgICAvKiBjbGVhciBOX3Byb2dyYW1pbmdfZW5h YmxlIGFuZCBOX3ZhbHVlX2luZGV4ICovCj4+IC0gICAgICAgdG1wICY9IH4oQVVEX0NPTkZJR19O X1ZBTFVFX0lOREVYIHwgQVVEX0NPTkZJR19OX1BST0dfRU5BQkxFKTsKPj4gLSAgICAgICBJOTE1 X1dSSVRFKGF1ZF9jb25maWcsIHRtcCk7Cj4+ICsgICAgICAgRFJNX0RFQlVHX0tNUygiRW5hYmxl IGF1ZGlvIGNvZGVjIG9uIHBpcGUgJWMsICV1IGJ5dGVzIEVMRFxuIiwKPj4gKyAgICAgICAgICAg ICAgICAgICAgIHBpcGVfbmFtZShwaXBlKSwgZWxkWzJdKTsKPj4KPj4gLSAgICAgICBEUk1fREVC VUdfRFJJVkVSKCJFTEQgb24gcGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPj4gLQo+PiAt ICAgICAgIGVsZHYgPSBBVURJT19FTERfVkFMSURfQSA8PCAocGlwZSAqIDQpOwo+PiAtCj4+IC0g ICAgICAgaWYgKGludGVsX3BpcGVfaGFzX3R5cGUoaW50ZWxfY3J0YywgSU5URUxfT1VUUFVUX0RJ U1BMQVlQT1JUKSkKPj4gLSAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoYXVkX2NvbmZpZywgQVVE X0NPTkZJR19OX1ZBTFVFX0lOREVYKTsgLyogMHgxID0gRFAgKi8KPj4gLSAgICAgICBlbHNlCj4+ IC0gICAgICAgICAgICAgICBJOTE1X1dSSVRFKGF1ZF9jb25maWcsIGF1ZGlvX2NvbmZpZ19oZG1p X3BpeGVsX2Nsb2NrKG1vZGUpKTsKPj4gLQo+PiAtICAgICAgIGlmIChpbnRlbF9lbGRfdXB0b2Rh dGUoY29ubmVjdG9yLAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXVkX2NudHJs X3N0MiwgZWxkdiwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1ZF9jbnRsX3N0 LCBJQlhfRUxEX0FERFJFU1NfTUFTSywKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGhkbWl3X2hkbWllZGlkKSkKPj4gLSAgICAgICAgICAgICAgIHJldHVybjsKPj4gKyAgICAgICAv KiBFbmFibGUgYXVkaW8gcHJlc2VuY2UgZGV0ZWN0LCBpbnZhbGlkYXRlIEVMRCAqLwo+PiArICAg ICAgIHRtcCA9IEk5MTVfUkVBRChIU1dfQVVEX1BJTl9FTERfQ1BfVkxEKTsKPj4gKyAgICAgICB0 bXAgfD0gQVVESU9fT1VUUFVUX0VOQUJMRV9BIDw8IChwaXBlICogNCk7Cj4+ICsgICAgICAgdG1w ICY9IH4oQVVESU9fRUxEX1ZBTElEX0EgPDwgKHBpcGUgKiA0KSk7Cj4+ICsgICAgICAgSTkxNV9X UklURShIU1dfQVVEX1BJTl9FTERfQ1BfVkxELCB0bXApOwo+Pgo+PiAtICAgICAgIHRtcCA9IEk5 MTVfUkVBRChhdWRfY250cmxfc3QyKTsKPj4gLSAgICAgICB0bXAgJj0gfmVsZHY7Cj4+IC0gICAg ICAgSTkxNV9XUklURShhdWRfY250cmxfc3QyLCB0bXApOwo+PiArICAgICAgIC8qIFhYWDogdmJs YW5rIHdhaXQgaGVyZSAqLwo+Pgo+PiAtICAgICAgIHRtcCA9IEk5MTVfUkVBRChhdWRfY250bF9z dCk7Cj4+ICsgICAgICAgLyogUmVzZXQgRUxEIHdyaXRlIGFkZHJlc3MgKi8KPj4gKyAgICAgICB0 bXAgPSBJOTE1X1JFQUQoSFNXX0FVRF9ESVBfRUxEX0NUUkwocGlwZSkpOwo+PiAgICAgICAgIHRt cCAmPSB+SUJYX0VMRF9BRERSRVNTX01BU0s7Cj4+IC0gICAgICAgSTkxNV9XUklURShhdWRfY250 bF9zdCwgdG1wKTsKPj4gLSAgICAgICBwb3J0ID0gKHRtcCA+PiAyOSkgJiBESVBfUE9SVF9TRUxf TUFTSzsgICAgICAgICAvKiBESVBfUG9ydF9TZWxlY3QsIDB4MSA9IFBvcnRCICovCj4+IC0gICAg ICAgRFJNX0RFQlVHX0RSSVZFUigicG9ydCBudW06JWRcbiIsIHBvcnQpOwo+PiArICAgICAgIEk5 MTVfV1JJVEUoSFNXX0FVRF9ESVBfRUxEX0NUUkwocGlwZSksIHRtcCk7Cj4+Cj4+IC0gICAgICAg bGVuID0gbWluX3QoaW50LCBlbGRbMl0sIDIxKTsgICAvKiA4NCBieXRlcyBvZiBodyBFTEQgYnVm ZmVyICovCj4+IC0gICAgICAgRFJNX0RFQlVHX0RSSVZFUigiRUxEIHNpemUgJWRcbiIsIGxlbik7 Cj4+ICsgICAgICAgLyogVXAgdG8gODQgYnl0ZXMgb2YgaHcgRUxEIGJ1ZmZlciAqLwo+PiArICAg ICAgIGxlbiA9IG1pbl90KGludCwgZWxkWzJdLCAyMSk7Cj4+ICAgICAgICAgZm9yIChpID0gMDsg aSA8IGxlbjsgaSsrKQo+PiAtICAgICAgICAgICAgICAgSTkxNV9XUklURShoZG1pd19oZG1pZWRp ZCwgKigodWludDMyX3QgKillbGQgKyBpKSk7Cj4+IC0KPj4gLSAgICAgICB0bXAgPSBJOTE1X1JF QUQoYXVkX2NudHJsX3N0Mik7Cj4+IC0gICAgICAgdG1wIHw9IGVsZHY7Cj4+IC0gICAgICAgSTkx NV9XUklURShhdWRfY250cmxfc3QyLCB0bXApOwo+PiArICAgICAgICAgICAgICAgSTkxNV9XUklU RShIU1dfQVVEX0VESURfREFUQShwaXBlKSwgKigodWludDMyX3QgKillbGQgKyBpKSk7Cj4+Cj4+ IC0gICAgICAgLyogWFhYOiBUcmFuc2l0aW9uYWwgKi8KPj4gKyAgICAgICAvKiBFTEQgdmFsaWQg Ki8KPj4gICAgICAgICB0bXAgPSBJOTE1X1JFQUQoSFNXX0FVRF9QSU5fRUxEX0NQX1ZMRCk7Cj4+ IC0gICAgICAgdG1wIHw9ICgoQVVESU9fT1VUUFVUX0VOQUJMRV9BIHwgQVVESU9fRUxEX1ZBTElE X0EpIDw8IChwaXBlICogNCkpOwo+PiArICAgICAgIHRtcCB8PSBBVURJT19FTERfVkFMSURfQSA8 PCAocGlwZSAqIDQpOwo+PiAgICAgICAgIEk5MTVfV1JJVEUoSFNXX0FVRF9QSU5fRUxEX0NQX1ZM RCwgdG1wKTsKPj4gKwo+PiArICAgICAgIC8qIEVuYWJsZSB0aW1lc3RhbXBzICovCj4+ICsgICAg ICAgdG1wID0gSTkxNV9SRUFEKEhTV19BVURfQ0ZHKHBpcGUpKTsKPj4gKyAgICAgICB0bXAgJj0g fkFVRF9DT05GSUdfTl9WQUxVRV9JTkRFWDsKPj4gKyAgICAgICB0bXAgJj0gfkFVRF9DT05GSUdf Tl9QUk9HX0VOQUJMRTsKPj4gKyAgICAgICB0bXAgJj0gfkFVRF9DT05GSUdfUElYRUxfQ0xPQ0tf SERNSV9NQVNLOwo+PiArICAgICAgIGlmIChpbnRlbF9waXBlX2hhc190eXBlKGludGVsX2NydGMs IElOVEVMX09VVFBVVF9ESVNQTEFZUE9SVCkpCj4+ICsgICAgICAgICAgICAgICB0bXAgfD0gQVVE X0NPTkZJR19OX1ZBTFVFX0lOREVYOwo+PiArICAgICAgIGVsc2UKPj4gKyAgICAgICAgICAgICAg IHRtcCB8PSBhdWRpb19jb25maWdfaGRtaV9waXhlbF9jbG9jayhtb2RlKTsKPj4gKyAgICAgICBJ OTE1X1dSSVRFKEhTV19BVURfQ0ZHKHBpcGUpLCB0bXApOwo+PiAgfQo+Pgo+PiAgc3RhdGljIHZv aWQgaWxrX2F1ZGlvX2NvZGVjX2VuYWJsZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y LAo+PiAtLQo+PiAyLjEuMQo+Pgo+Cj4KPgo+IC0tIAo+IFJvZHJpZ28gVml2aQo+IEJsb2c6IGh0 dHA6Ly9ibG9nLnZpdmkuZW5nLmJyCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNl IFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==