From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: patches for occlusion query fix on sandybridge Date: Tue, 14 Dec 2010 09:58:58 -0800 Message-ID: <877hfcgrrx.fsf@pollan.anholt.net> References: <1292302562-5800-1-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0790699554==" Return-path: In-Reply-To: <1292302562-5800-1-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0790699554== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 14 Dec 2010 12:55:59 +0800, Zhenyu Wang w= rote: > It appears Sandybridge PIPE_CONTROL write out buffer need > to be set as cached, currently LLC cached, in order to read > back correct counter. Otherwise I can always be possible to > get corrupted 64-bit PS_DEPTH_COUNT from PIPE_CONTROL write. >=20 > So below patches try to add new flag during bo create with > cacheable type, to be sure that GTT entry's cache bits would > be setup for that. >=20 > This fixes occlusion query piglit test and mesa demos on my > sandybridge. Note that below patches don't include necessary > component version check changes. Why don't we just keep all of our BOs LLC cached? This was supposed to be a big win of the new chipset, as it means we don't need to clflush. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk0HsGIACgkQHUdvYGzw6vf5WQCfS0xtWxVjwa7gpMb/1d5SJiWU 4RYAmwben1GMBR3DZrhU9oL38ar8kuwQ =S8R2 -----END PGP SIGNATURE----- --=-=-=-- --===============0790699554== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0790699554==--