From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Tvrtko Ursulin <tursulin@ursulin.net>
Cc: Intel-gfx@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling
Date: Wed, 18 Oct 2017 10:39:06 +0100 [thread overview]
Message-ID: <87828c1b-7e6b-2534-af57-b0178ed62e19@linux.intel.com> (raw)
In-Reply-To: <20171018090715.55powwdixxsius46@phenom.ffwll.local>
On 18/10/2017 10:07, Daniel Vetter wrote:
> On Tue, Oct 17, 2017 at 04:09:08PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Avoid dereferencing the error pointer and also avoid returning NULL
>> from i915_mmu_notifier_find since the callers do not expect that.
>
> How did my patch return a NULL value? At least I assume that's the reasonf
> for your v2 ...
The flow as I saw it was:
1. err = PTR_ERR
2. mn->mm == NULL
3. err = 0
4. return mm->mn
Which I okay-ed as well so a combined fail.
I pinged you on IRC and from your reply I understood you want me to send
the patch I showed there, and don't want to bother thinking about it any
longer.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-18 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:14 [PATCH] drm/i915: Fixup userptr mmu notifier registration error handling Daniel Vetter
2017-10-17 15:09 ` [PATCH v2] " Tvrtko Ursulin
2017-10-17 15:32 ` Chris Wilson
2017-10-18 9:07 ` Daniel Vetter
2017-10-18 9:39 ` Tvrtko Ursulin [this message]
2017-10-17 15:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-17 16:07 ` ✓ Fi.CI.BAT: success for drm/i915: Fixup userptr mmu notifier registration error handling (rev2) Patchwork
2017-10-18 8:26 ` Tvrtko Ursulin
2017-10-18 2:37 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87828c1b-7e6b-2534-af57-b0178ed62e19@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox