Re: [PATCH 00/22] drm/i915/vrr: A few fixes and a bunch of cleanup

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 20 Oct 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> With all the recent work on the VRR code we've accumulated quite
> a few slightly rough corners. Try to clean things up a bit.
>
> While testing the cleanups I noticed a few real issues, fixes
> for which are included at the start of the series.

I quickly eyeballed through this, looks good, but would Ankit be up for
detailed review considering the recent contributions in the area?

BR,
Jani.


>
> Ville Syrjälä (22):
>   drm/i915/vrr: Fix intel_vrr_always_use_vrr_tg()==true on TGL
>   drm/i915/lrr: Include SCL in lrr_params_changed()
>   drm/i915: Remove the "vblank delay" state dump
>   drm/i915/vrr: Compute fixed refresh rate timings the sam way as CMRR
>     timings
>   drm/i915/vrr: Reorganize intel_vrr_compute_cmrr_timings() a bit
>   drm/i195/vrr: Move crtc_state->vrr.{vmin,vmax} update into
>     intel_vrr_compute_vrr_timings()
>   drm/i915/vrr: Move compute_fixed_rr_timings()
>   drm/i915/vrr: Extract intel_vrr_set_vrr_timings()
>   drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable()
>   drm/i915/vrr: Move EMP_AS_SDP_TL write into
>     intel_vrr_set_transcoder_timings()
>   drm/i915/vrr: Use trans_vrr_ctl() in intel_vrr_transcoder_disable()
>   drm/i915/vrr: Extract intel_vrr_tg_disable()
>   drm/i915/vrr: Extract intel_vrr_tg_enable()
>   drm/i915/vrr: Disable VRR TG in intel_vrr_transcoder_disable() only on
>     always use_vrr_tg() platforms
>   drm/i915/vrr: Always write TRANS_VRR_CTL in
>     intel_vrr_set_transcoder_timings() on !always_use_vrr_tg()
>   drm/i915/vrr: Remove redundant HAS_VRR() checks
>   drm/i915/vrr: Move HAS_VRR() check into
>     intel_vrr_set_transcoder_timings()
>   drm/i915/vrr: s/crtc_state/old_crtc_state/ in
>     intel_vrr_transcoder_disable()
>   drm/i915/vrr: Nuke intel_vrr_vblank_exit_length()
>   drm/i915/vrr: Nuke intel_vrr_vmin_flipline()
>   drm/i915/vrr: Update the intel_vrr_extra_vblank_delay() comment
>   drm/i915/vrr: Check HAS_VRR() first in intel_vrr_is_capable()
>
>  .../drm/i915/display/intel_crtc_state_dump.c  |   4 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |  22 +-
>  drivers/gpu/drm/i915/display/intel_vrr.c      | 212 ++++++++----------
>  3 files changed, 113 insertions(+), 125 deletions(-)

-- 
Jani Nikula, Intel