From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E480C001E0 for ; Thu, 13 Jul 2023 12:48:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33B2F10E6AA; Thu, 13 Jul 2023 12:48:47 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B6E510E673; Thu, 13 Jul 2023 09:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689239035; x=1720775035; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=wpe6dsOBfDPS7D7Sq/hiKhbMpNSn/Y2A1D02VMmRxgw=; b=nCC482jgclH2CTz6+8O714okx2RScR1uZ2aAY20lsHcei7XFzoS0RmBS h5N0PTR8+GfYDCWQf5ysPxbzqCQZEFJi+wNxT1glQr5w2aPx5evHTAFAi RP0U/ZTxT3zUpjpJFqkl6ovSYirIQDR2Z2Dy1mWNCSsgYgar9gDCOLrRm N2wPAmMQsZfWXVQ7+mM0JQDNuoBBznXVebwm+HpNtMBWJ3FTQYzxoNAPS /9qVkQNhtHpmq3IXBweM1YUcGUUOC/BwcEG+JrsXnPsakzPsZ2FCuc7un YHqhkBTsB3xbg+FQsFEtpiwJPjWLdpdweVtTlmp4v9VEXRnjcnY3iGDNv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="395935058" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="395935058" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 02:03:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="715882508" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="715882508" Received: from atadj-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.50.30]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 02:03:08 -0700 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= In-Reply-To: <20230712161025.22op3gtzgujrhytb@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <87fs5tgpvv.fsf@intel.com> <20230712161025.22op3gtzgujrhytb@pengutronix.de> Date: Thu, 13 Jul 2023 12:03:05 +0300 Message-ID: <878rbkgp4m.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 13 Jul 2023 12:48:29 +0000 Subject: Re: [Intel-gfx] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Xinliang Liu , Rodrigo Vivi , Alexey Kodanev , dri-devel@lists.freedesktop.org, Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Jonathan Hunter , Jerome Brunet , linux-samsung-soc@vger.kernel.org, Samuel Holland , Matt Roper , Wenjing Liu , Javier Martinez Canillas , Danilo Krummrich , NXP Linux Team , spice-devel@lists.freedesktop.org, Dmitry Baryshkov , linux-sunxi@lists.linux.dev, Matthias Brugger , Tim Huang , =?utf-8?Q?A?= =?utf-8?Q?ndr=C3=A9?= Almeida , Leo Li , Sascha Hauer , Lucas De Marchi , Hersen Wu , Dave Airlie , Kamlesh Gurudasani , Bhawanpreet Lakha , =?utf-8?Q?=C5=81ukasz?= Bartosik , Andrew Jeffery , Seung-Woo Kim , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Laurent Pinchart , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Yongqin Liu , Mario Limonciello , Chunyan Zhang , David Francis , Aaron Liu , Vinod Polimera , linux-rockchip@lists.infradead.org, Fangzhi Zuo , Aurabindo Pillai , VMware Graphics Reviewers , Ben Skeggs , Jessica Zhang , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Nicolas Ferre , Maxime Ripard , Tian Tao , Biju Das , linux-amlogic@lists.infradead.org, Evan Quan , Michal Simek , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Boris Brezillon , Shawn Guo , Qingqing Zhuo , Sandy Huang , linux-renesas-soc@vger.kernel.org, Kyungmin Park , Maxime Coquelin , Kevin Hilman , Hawking Zhang , Haneen Mohammed , Paul Cercueil , Dan Carpenter , Karol Herbst , linux-hyperv@vger.kernel.org, Melissa Wen , =?utf-8?Q?Ma=C3=ADra?= Canal , Luca Coelho , Gerd Hoffmann , Andrzej Hajda , Likun Gao , "Jiri Slaby \(SUSE\)" , Emma Anholt , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Deepak Rawat , Xinwei Kong , Joel Stanley , Orson Zhai , Alan Liu , Philip Yang , intel-gfx@lists.freedesktop.org, Alison Wang , Wolfram Sang , Abhinav Kumar , Baolin Wang , Tomi Valkeinen , Mikko Perttunen , Yifan Zhang , Rodrigo Siqueira , Tomi Valkeinen , Deepak R Varma , "Pan, Xinhui" , Konrad Dybcio , Kieran Bingham , John Stultz , Roman Li , Sumit Semwal , Christian =?utf-8?Q?K=C3=B6nig?= , linux-stm32@st-md-mailman.stormreply.com, Sam Ravnborg , Chun-Kuang Hu , Alexandre Torgue , Gurchetan Singh , Liu Shixin , Hamza Mahfooz , Marek Vasut , Paul Kocialkowski , xen-devel@lists.xenproject.org, Guchun Chen , Oleksandr Andrushchenko , Raphael Gallais-Pou , Rodrigo Siqueira , Russell King , Jiasheng Jiang , Srinivasan Shanmugam , David Lechner , Jiapeng Chong , Marek =?utf-8?B?T2zFocOhaw==?= , =?utf-8?Q?Joaqu=C3=ADn?= Ignacio =?utf-8?Q?Aramend=C3=ADa?= , Melissa Wen , Hans de Goede , linux-mediatek@lists.infradead.org, Laurentiu Palcu , linux-tegra@vger.kernel.org, David Tadokoro , AngeloGioacchino Del Regno , amd-gfx@lists.freedesktop.org, Lang Yu , Yannick Fertre , linux-mips@vger.kernel.org, Krzysztof Kozlowski , Philippe Cornu , Thomas Zimmermann , Wayne Lin , Drew Davenport , Nirmoy Das , Jyri Sarha Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 12 Jul 2023, Uwe Kleine-K=C3=B6nig = wrote: > Hello Jani, > > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: >> On Wed, 12 Jul 2023, Uwe Kleine-K=C3=B6nig wrote: >> > Hello, >> > >> > while I debugged an issue in the imx-lcdc driver I was constantly >> > irritated about struct drm_device pointer variables being named "dev" >> > because with that name I usually expect a struct device pointer. >> > >> > I think there is a big benefit when these are all renamed to "drm_dev". >> > I have no strong preference here though, so "drmdev" or "drm" are fine >> > for me, too. Let the bikesheding begin! >> > >> > Some statistics: >> > >> > $ git grep -ohE 'struct drm_device *\* *[^ (),;]*' v6.5-rc1 | sort | u= niq -c | sort -n >> > 1 struct drm_device *adev_to_drm >> > 1 struct drm_device *drm_ >> > 1 struct drm_device *drm_dev >> > 1 struct drm_device *drm_dev >> > 1 struct drm_device *pdev >> > 1 struct drm_device *rdev >> > 1 struct drm_device *vdev >> > 2 struct drm_device *dcss_drv_dev_to_drm >> > 2 struct drm_device **ddev >> > 2 struct drm_device *drm_dev_alloc >> > 2 struct drm_device *mock >> > 2 struct drm_device *p_ddev >> > 5 struct drm_device *device >> > 9 struct drm_device * dev >> > 25 struct drm_device *d >> > 95 struct drm_device * >> > 216 struct drm_device *ddev >> > 234 struct drm_device *drm_dev >> > 611 struct drm_device *drm >> > 4190 struct drm_device *dev >> > >> > This series starts with renaming struct drm_crtc::dev to drm_dev. If >> > it's not only me and others like the result of this effort it should be >> > followed up by adapting the other structs and the individual usages in >> > the different drivers. >>=20 >> I think this is an unnecessary change. In drm, a dev is usually a drm >> device, i.e. struct drm_device *. > > Well, unless it's not. Prominently there is > > struct drm_device { > ... > struct device *dev; > ... > }; > > which yields quite a few code locations using dev->dev which is > IMHO unnecessary irritating: > > $ git grep '\dev' v6.5-rc1 drivers/gpu/drm | wc -l > 1633 > > Also the functions that deal with both a struct device and a struct > drm_device often use "dev" for the struct device and then "ddev" for > the drm_device (see for example amdgpu_device_get_pcie_replay_count()). Why is specifically struct drm_device *dev so irritating to you? You lead us to believe it's an outlier in kernel, something that goes against common kernel style, but it's really not: $ git grep -how "struct [A-Za-z0-9_]\+ \*dev" | sort | uniq -c | sort -rn |= head -20 38494 struct device *dev 16388 struct net_device *dev 4184 struct drm_device *dev 2780 struct pci_dev *dev 1916 struct comedi_device *dev 1510 struct mlx5_core_dev *dev 1057 struct mlx4_dev *dev 894 struct b43_wldev *dev 762 struct input_dev *dev 623 struct usbnet *dev 561 struct mlx5_ib_dev *dev 525 struct mt76_dev *dev 465 struct mt76x02_dev *dev 435 struct platform_device *dev 431 struct usb_device *dev 411 struct mt7915_dev *dev 398 struct cx231xx *dev 378 struct mei_device *dev 363 struct ksz_device *dev 359 struct mthca_dev *dev A good portion of the above also have a dev member. Are you planning on changing all of the above too, or are you only annoyed by drm? I'm really not convinced at all. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center