From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE65EEB64D9 for ; Tue, 27 Jun 2023 09:47:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 755E310E1B7; Tue, 27 Jun 2023 09:47:32 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FB0810E1B7 for ; Tue, 27 Jun 2023 09:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687859250; x=1719395250; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=KbXve1fuu2HChoKY35w9filbsS+bI8bu23tDWWcvb4I=; b=GZfQ33clbIJU8IP82iyuYItmgaPiAV9tSejAJt4WJ+AhiKxQEmxA5eTQ ZD/YjV87/E7FvzEGZa+/KQ6Qgqm2YB2J833q2rUcOAGC7OiXVaIethXre QG1bP1pbBhK/PgB7y72eP+OtTOqfo3nkgWQAucai3VTWv12SQzsXZb0nE ZOhKDpTbm2DdiBS+YlkcSnQnkPExXnFFDGs9Mjv8oMvW9IQmUkxnouQlO PnUngZGUl+25GWwpLqe/uMLr9nMHsJS4kQxhLNZKM0K827NXnCmFEwuGv 6Z9A7qvUNsdB2OV76ecXMWIssdt+G+j5Yk3gEFn0CGCXtWAA+7jpcvj2r g==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="361567560" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="361567560" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:47:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="829597214" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="829597214" Received: from jwerner6-mobl.ger.corp.intel.com (HELO localhost) ([10.252.39.48]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 02:47:28 -0700 From: Jani Nikula To: "Borah, Chaitanya Kumar" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230626061043.1162688-1-chaitanya.kumar.borah@intel.com> <20230626075254.1183894-1-chaitanya.kumar.borah@intel.com> <87r0pyv34w.fsf@intel.com> <878rc6uw9z.fsf@intel.com> Date: Tue, 27 Jun 2023 12:47:11 +0300 Message-ID: <878rc5texs.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 27 Jun 2023, "Borah, Chaitanya Kumar" wrote: > Hello Jani, > >> -----Original Message----- >> From: Jani Nikula >> Sent: Monday, June 26, 2023 8:05 PM >> To: Borah, Chaitanya Kumar ; intel- >> gfx@lists.freedesktop.org >> Cc: Shankar, Uma ; Murthy, Arun R >> >> Subject: RE: [PATCH] drm/i915/display: Add forward declaration for struct >> seq_file >> >> On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar" >> wrote: >> > Hello Jani, >> > >> >> -----Original Message----- >> >> From: Jani Nikula >> >> Sent: Monday, June 26, 2023 5:37 PM >> >> To: Borah, Chaitanya Kumar ; intel- >> >> gfx@lists.freedesktop.org >> >> Cc: Shankar, Uma ; Murthy, Arun R >> >> ; Borah, Chaitanya Kumar >> >> >> >> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for >> >> struct seq_file >> >> >> >> On Mon, 26 Jun 2023, Chaitanya Kumar Borah >> >> wrote: >> >> > With change [1], visibility of struct seq_file is lost in >> >> > intel_display_power.h leading to build errors. Add forward >> >> > declaration. >> >> > >> >> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo >> >> > declaration") >> >> > >> >> > v2: Use forward declaration instead of headerfile inclusion [Jani] >> >> > >> >> > Signed-off-by: Chaitanya Kumar Borah >> >> > >> >> >> >> Hey, thanks for the patch, this would've been fine, but looks like >> >> Imre just pushed commit f4fab137dd2b ("drm/i915: Add missing forward >> >> declarations/includes to display power headers") which adds the >> >> forward declaration among other things. >> >> >> >> Sorry for the trouble. >> >> >> > >> > No problem, Thank you for the info. >> > >> > Sorry for my ignorance but will this patch eventually find its way to >> > linux-next or do we need to do something special here? >> >> It'll show up in linux-next once -rc1 is out. But I'm not sure that's the >> *question* you want the answer to, really. >> > > If I understand correctly, the patch will get merged with linux-next > along with the release of 6.4-rc1. > > The pertinent question is when will linux-next builds be fixed? > We are missing out on regression tracking because of the build failures. I've asked Tvrtko to pick this up to drm-intel-next-fixes, which should show up in linux-next when it's next generated (it's daily). BR, Jani. > > Regards > > Chaitanya > >> BR, >> Jani. >> >> >> > >> > Regards >> > >> > Chaitanya >> > >> >> BR, >> >> Jani. >> >> >> >> > --- >> >> > drivers/gpu/drm/i915/display/intel_display_power.h | 1 + >> >> > 1 file changed, 1 insertion(+) >> >> > >> >> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h >> >> > b/drivers/gpu/drm/i915/display/intel_display_power.h >> >> > index be1a87bde0c9..0ba268e566b0 100644 >> >> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h >> >> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h >> >> > @@ -16,6 +16,7 @@ enum port; >> >> > struct drm_i915_private; >> >> > struct i915_power_well; >> >> > struct intel_encoder; >> >> > +struct seq_file; >> >> > >> >> > /* >> >> > * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain >> >> > instances >> >> >> >> -- >> >> Jani Nikula, Intel Open Source Graphics Center >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center