From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30954C433EF for ; Sat, 11 Jun 2022 00:55:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B819F10E394; Sat, 11 Jun 2022 00:55:34 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E35D10E394 for ; Sat, 11 Jun 2022 00:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654908934; x=1686444934; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Ghx03sOONpSaLJaiCwcRoJlsvQgcV95gw7VjAv/1/nY=; b=F9lmUKlT4qHN/+25iNAIKUqzsO0+pdDOdSxq+AfdlM6ejuRJ/zfTDLol kYieJEDnFXMd9fg4yxPjodTz4Xt7fWeek1TRDUiRKhafL7kOFytlog9ud iX89VKocIRwo15e6JSSiw7xkdQhsrwOBcwTvzvb+F7YBzHYu7CU6XATsf EwLofFHLjnLYpftCJnLBWsKeKbVf7oZDyADXUvq26Tfk1k/us3jXv5zw0 7GvQ2NgfJAXvHx9xtNWjKIehxCI0oG2XE2nQEcvGVCt2mGqlgCvVIcA3H wWCYs+nd+Jhblp0qSYncvAe0yYpXrWXb0gdV8mnxJmW8xIZI6Irm9MtYq g==; X-IronPort-AV: E=McAfee;i="6400,9594,10374"; a="260910018" X-IronPort-AV: E=Sophos;i="5.91,292,1647327600"; d="scan'208";a="260910018" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 17:55:33 -0700 X-IronPort-AV: E=Sophos;i="5.91,292,1647327600"; d="scan'208";a="586487140" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.9.44]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 17:55:33 -0700 Date: Fri, 10 Jun 2022 17:55:32 -0700 Message-ID: <878rq4j9x7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar In-Reply-To: <20220523110841.1151431-4-badal.nilawar@intel.com> References: <20220523110841.1151431-1-badal.nilawar@intel.com> <20220523110841.1151431-4-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 23 May 2022 04:08:41 -0700, Badal Nilawar wrote: > > +static int > +i915_in_read(struct i915_hwmon_drvdata *ddat, u32 attr, long *val) > +{ > + struct i915_hwmon *hwmon = ddat->dd_hwmon; > + intel_wakeref_t wakeref; > + u32 reg_value; > + > + switch (attr) { > + case hwmon_in_input: > + with_intel_runtime_pm(ddat->dd_uncore->rpm, wakeref) > + reg_value = intel_uncore_read(ddat->dd_uncore, hwmon->rg.gt_perf_status); > + *val = DIV_ROUND_CLOSEST(REG_FIELD_GET(GEN12_VOLTAGE_MASK, reg_value) * 25, 10); A comment here that voltage is in units of 2.5 mV would be nice. > @@ -440,12 +495,14 @@ i915_hwmon_get_preregistration_info(struct drm_i915_private *i915) > hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT; > hwmon->rg.energy_status_all = PCU_PACKAGE_ENERGY_STATUS; > hwmon->rg.energy_status_tile = INVALID_MMIO_REG; > + hwmon->rg.gt_perf_status = GEN12_RPSTAT1; > } else { > hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG; > hwmon->rg.pkg_power_sku = INVALID_MMIO_REG; > hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG; > hwmon->rg.energy_status_all = INVALID_MMIO_REG; > hwmon->rg.energy_status_tile = INVALID_MMIO_REG; > + hwmon->rg.gt_perf_status = INVALID_MMIO_REG; Looks like this is supportable on XEHPSDV too, so let's add that too.