From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54019C433EF for ; Thu, 14 Apr 2022 22:31:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7D4B10E40B; Thu, 14 Apr 2022 22:31:09 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09DA610E40B for ; Thu, 14 Apr 2022 22:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649975469; x=1681511469; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=XlQQ955ZcDM70MOYqJPTx9H+vO4mtPLmrl6NsobK4Q4=; b=WiAC59SGk4s+MiOLOhmzDCs3V8TwGxm3CO7F0aGt7LpoKyY3x66AhdBt VwnJtBrKm1E5bl7AW6uGRAiLITxExBPIPD3OJ+O5Rzud4uwG0FLL+SJeR wifKjHychLAUgXn2tHn2bbyXzqhtuW/ObSTEtNf0nsMyFa5bdsDHg6vSH EcW6rDamuvqFVCoeXvEWDAHl4PeWAUNAj4IEyA+6k8u466MwMiLVe5Gaf rR88EUlUZNGQBfkVKY19oYeBXwWG9xpHzlUxb2nhhM/69OFe8ApYKy8v0 zrXElAi6WbLbQ8IkzXtlfOKTnNC++GNMTAmDdAsuG+ugFH0x6YwZB7FRC Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10317"; a="263219785" X-IronPort-AV: E=Sophos;i="5.90,260,1643702400"; d="scan'208";a="263219785" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 15:31:08 -0700 X-IronPort-AV: E=Sophos;i="5.90,260,1643702400"; d="scan'208";a="656171868" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.176.166]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 15:31:08 -0700 Date: Thu, 14 Apr 2022 15:31:07 -0700 Message-ID: <878rs72t78.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula In-Reply-To: <87lew7eque.fsf@intel.com> References: <8f667da9aa39452524abef1333226b645438d2cc.1649871650.git.ashutosh.dixit@intel.com> <87lew7eque.fsf@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > Each gt contains an independent instance of pcode. Extend pcode functions > > to interface with pcode on different gt's. Previous (GT0) pcode read/write > > interfaces are preserved. > > The big problem here is that this hard couples display code to gt code, > while we're trying hard to go the opposite direction. It doesn't matter > that the existing interfaces are preserved as wrappers when it relies on > an intel_gt being available (via i915->gt0). > > Note how 'git grep intel_gt -- drivers/gpu/drm/i915/display/' matches > only 1 line. Hi Jani, would you have suggestions about how to do this (handle pcode on multiple gt's)? The thinking was this patch would be a straightforward way to avoid code duplication. Also: int intel_gt_probe_all() { ... /* * We always have at least one primary GT on any device * and it has been already initialized early during probe * in i915_driver_probe() */ Thanks.