Re: [Intel-gfx] [PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open

Christoph Hellwig
2021-07-23T08:13:42Z

On Tue, Jul 20, 2021 at 02:42:57PM -0300, Jason Gunthorpe wrote:
> mbochs_close() iterates over global device state and frees it. Currently
> this is done every time a device FD is closed, but if multiple device FDs
> are open this could corrupt other still active FDs.
>
> Change this to use close_device() so it only runs on the last close.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>