From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EADC433EA for ; Thu, 23 Jul 2020 13:17:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93C1520737 for ; Thu, 23 Jul 2020 13:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I45ih93L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93C1520737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F3CD6E05A; Thu, 23 Jul 2020 13:17:21 +0000 (UTC) Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A41489E47; Thu, 23 Jul 2020 13:17:19 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id 140so3249793lfi.5; Thu, 23 Jul 2020 06:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=9kJug77lFue3e3m3qpRP4EGSNSmchk/0/9BCGZu0uig=; b=I45ih93L8ocvZtWaP72y27l1QuZcEYn5mYBbQTD4rOjCE1Kf0YdrLmTv2QTP3/Vvyk DKtBBwGnpWDXYTkGWDrvOrZ1BtT9O5uYMQetUsAED6CrMa85si1iifXk+KvzmZPpGI3A h+JodYBenNYX+GXvG6GHdO56v0nlp3MnNCmBA1Fmwd2Q/szrnNoUZc65AHcfAPz9EKZs NtThqI/UGlSTnPojE6hxYW4rIL0h1dVHHJ27rXGp/Ey2467Gc5A8bryqLi6Xb6FtwBr6 OtpuTkdIuIX7aDKVW13hg7Al3QJqrOD7vE+eNDHqTBL65QexDqW6SXU1pKYwriJmTT10 KfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=9kJug77lFue3e3m3qpRP4EGSNSmchk/0/9BCGZu0uig=; b=Hcq84mZZwW/5CONRZIac06Yy2yDfs/JFOpBn2mUjAV9+gFAVuan45fQYGbzNEKLkB6 5piahBfS6VJDtCrp2gOo7wMEqF0/NPCcjSwtGVYblC9LzaJfwoV3kJl1KYLBxWokzFsA VFqG27eAZV5UahXpzAjmiYHQ9ztzBbyfok3fzmu5+ZWKxpwQgIVg95JcC8aO/0S8Z4/9 cQAMWZKIk/VWQr3ClJAsm/OUg95thVjvlj8PxdLnKvYJw+OBUEbojyOxqhIB/qO7zdCX b0G4IraCAVav30JdQYDHVOQMD7e05qrtiZG9XdsSLWpzIAfa3kOOh1PA/+aTgD6MugSt hE2Q== X-Gm-Message-State: AOAM532frOxM9LhOBzewOyzCFacV8hih40FyQzUbWiG57Y+ZiCWYBpFX TaQHlVHHLwOzS0zzZpxohAU= X-Google-Smtp-Source: ABdhPJwzAFDirtOGzLAp/Kdima3bh8W+FrH+3Vfj9z0CyTMzVmI/bLvz4ZlDlw5Y93U8HoQMOpMuIg== X-Received: by 2002:a05:6512:3317:: with SMTP id k23mr2274429lfe.111.1595510237593; Thu, 23 Jul 2020 06:17:17 -0700 (PDT) Received: from saruman (91-155-214-58.elisa-laajakaista.fi. [91.155.214.58]) by smtp.gmail.com with ESMTPSA id d2sm2711666ljg.6.2020.07.23.06.17.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jul 2020 06:17:16 -0700 (PDT) From: Felipe Balbi To: Nicolas Boichat , linux-kernel@vger.kernel.org In-Reply-To: <20200627070307.516803-2-drinkcat@chromium.org> References: <20200627070307.516803-1-drinkcat@chromium.org> <20200627070307.516803-2-drinkcat@chromium.org> Date: Thu, 23 Jul 2020 16:17:10 +0300 Message-ID: <878sfanzft.fsf@kernel.org> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , "Guilherme G . Piccoli" , Rafael Aquini , Sam Ravnborg , David Airlie , Todor Tomov , Bjorn Andersson , David Howells , Tiezhu Yang , Will Deacon , Christian Brauner , Kees Cook , devel@driverdev.osuosl.org, Stephen Rothwell , Nicolas Boichat , Jayshri Pawar , Masahiro Yamada , Alexei Starovoitov , Jason Gunthorpe , Andy Gross , Tomas Winkler , Alexey Dobriyan , linux-media@vger.kernel.org, Pawel Laszczak , Arnd Bergmann , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Chao Yu , Steven Rostedt , Jaegeuk Kim , Thomas Gleixner , Mauro Carvalho Chehab , Ingo Molnar , Roger Quadros , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Andy Shevchenko , Sakari Ailus , Colin Ian King , Andrew Morton , Divya Indi Content-Type: multipart/mixed; boundary="===============1947633261==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1947633261== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Boichat writes: > trace_printk should not be used in production code, replace it > call with dev_dbg. > > Signed-off-by: Nicolas Boichat > > --- > > Unclear why a trace_printk was used in the first place, it's > possible that some rate-limiting is necessary here. > > drivers/usb/cdns3/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c > index 5e24c2e57c0d8c8..c303ab7c62d1651 100644 > --- a/drivers/usb/cdns3/gadget.c > +++ b/drivers/usb/cdns3/gadget.c > @@ -421,7 +421,7 @@ static int cdns3_start_all_request(struct cdns3_devic= e *priv_dev, > if ((priv_req->flags & REQUEST_INTERNAL) || > (priv_ep->flags & EP_TDLCHK_EN) || > priv_ep->use_streams) { > - trace_printk("Blocking external request\n"); > + dev_dbg(priv_dev->dev, "Blocking external request\n"); Instead, I would suggest adding a proper trace event here; one that includes "priv_ep->flags" in the output. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8ZjdYACgkQzL64meEa mQYWXg/8CF3lZVFo7WlBjaJGn7A3OwB/7jbBrBvT3T0ox5HN0tw9WqagXbxF4XOJ cFCDjlAYjq1K96/WcInpTiY++V/GrDvjLM098NfY6MYfLCFt259q/Z9hadQptlJo M50jOZW/c7Q1BAdk41qGOuYF5PY1JyqvCSRLMMbjkL5jbReFGiAVE83n9zm58zam Nob/eZD6Vx5S2gmgOUo3WE3nZCimqjExa8dtR2kTxyfTljyPpjmSr5JziL46rVY4 TPYDihgkkTpF5+IBo4bHPG20NPSud0Gf3bTDJn1BXl7GgTmA1NSkgGoHHzJbBIme UdnT9Gk4QjdnS1wV66LQ++0WAoFGOsWXIwCNKXttooxlimYo5Z1Se89cPEhclLMe U6/rJuzZEX2RCjYCgzrlJHj+hixf7s+n+t1IrF9Xy9i3VoghMMIXsskVkf/nrDYF B+kCaXMTIk+DeaIvqXTkl+jZPmcoXUZtg96jZ+dSoBb0zKgZJ5oRaMxwQGNrTcZJ bPGmD51NGtucsp3V72rSq+GUF6m5ujmnYuWVDSugdFcHj+PHYV3bYamT6TkbkqTq aQfBddx23Tgt792Ob1XXQ6jPEHWkEk4QJOalTdzr7g2HFeWprrHQo4+xJKvlLX9L pwGZeApjT2vY6aRpv3DD9qgzfYCipgCPJ6pMkHP6CWgqUw++Qnw= =59xo -----END PGP SIGNATURE----- --=-=-=-- --===============1947633261== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1947633261==--