From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 08/25] drm/i915/pmu: Always sample an active
 ringbuffer
Date: Fri, 22 Feb 2019 14:10:33 +0200
Message-ID: <878sy8vxae.fsf@gaia.fi.intel.com>
References: <20190219122215.8941-1-chris@chris-wilson.co.uk>
 <20190219122215.8941-8-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3A59489565
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Feb 2019 12:10:56 +0000 (UTC)
In-Reply-To: <20190219122215.8941-8-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQXMgd2Ug
bm8gbG9uZ2VyIGhhdmUgYSBwcmVjaXNlIGluZGljYXRpb24gb2YgcmVxdWVzdHMgcXVldWVkIHRv
IGFuCj4gZW5naW5lLCBtYWtlIG5vIHByZXN1bXB0aW9ucyBhbmQganVzdCBzYW1wbGUgdGhlIHJp
bmcgcmVnaXN0ZXJzIHRvIHNlZQo+IGlmIHRoZSBlbmdpbmUgaXMgYnVzeS4KPgo+IHYyOiBSZXBv
cnQgYnVzeSB3aGlsZSB0aGUgcmluZyBpcyBpZGxpbmcgb24gYSBzZW1hcGhvcmUvZXZlbnQuCj4g
djM6IEdpdmUgdGhlIHN0cnVjdCBhIG5hbWUhCj4gdjQ6IEFsd2F5cyAwIG91dHNpZGUgdGhlIHBv
d2Vyd2VsbDsgdHJ1c3RpbmcgdGhlIHBvd2Vyd2VsbCBpcwo+IGFjY3VyYXRlIGVub3VnaCBmb3Ig
b3VyIHNhbXBsaW5nIHBtdS4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA
Y2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A
aW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jICAgICAg
ICAgfCA2MCArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3JpbmdidWZmZXIuaCB8ICAyICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0
aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9wbXUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMKPiBpbmRl
eCAxM2Q3MGI5MGRkMGYuLjIxYWRhZDcyYmQ4NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X3BtdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUu
Ywo+IEBAIC0xNDgsMTQgKzE0OCw2IEBAIHZvaWQgaTkxNV9wbXVfZ3RfdW5wYXJrZWQoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gIAlzcGluX3VubG9ja19pcnEoJmk5MTUtPnBtdS5s
b2NrKTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgZ3JhYl9mb3JjZXdha2Uoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgZncpCj4gLXsKPiAtCWlmICghZncpCj4gLQkJaW50ZWxf
dW5jb3JlX2ZvcmNld2FrZV9nZXQoaTkxNSwgRk9SQ0VXQUtFX0FMTCk7Cj4gLQo+IC0JcmV0dXJu
IHRydWU7Cj4gLX0KPiAtCj4gIHN0YXRpYyB2b2lkCj4gIGFkZF9zYW1wbGUoc3RydWN0IGk5MTVf
cG11X3NhbXBsZSAqc2FtcGxlLCB1MzIgdmFsKQo+ICB7Cj4gQEAgLTE2OCw0OSArMTYwLDQzIEBA
IGVuZ2luZXNfc2FtcGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdW5zaWdu
ZWQgaW50IHBlcmlvZF9ucykKPiAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPiAg
CWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICAJaW50ZWxfd2FrZXJlZl90IHdha2VyZWY7Cj4g
LQlib29sIGZ3ID0gZmFsc2U7Cj4gIAo+ICAJaWYgKChkZXZfcHJpdi0+cG11LmVuYWJsZSAmIEVO
R0lORV9TQU1QTEVfTUFTSykgPT0gMCkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JaWYgKCFkZXZfcHJp
di0+Z3QuYXdha2UpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCXdha2VyZWYgPSBpbnRlbF9ydW50aW1l
X3BtX2dldF9pZl9pbl91c2UoZGV2X3ByaXYpOwo+ICsJd2FrZXJlZiA9IDA7Cj4gKwlpZiAoUkVB
RF9PTkNFKGRldl9wcml2LT5ndC5hd2FrZSkpCgpJcyB0aGlzIGd0LmF3YWtlIGNoZWNrIGp1c3Qg
dG8gYmUgbW9yZSBsaWdodHdlaWdodCBvbiBzYW1wbGluZz8KCj4gKwkJd2FrZXJlZiA9IGludGVs
X3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZShkZXZfcHJpdik7Cj4gIAlpZiAoIXdha2VyZWYpCj4g
IAkJcmV0dXJuOwo+ICAKPiAgCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkg
ewo+IC0JCXUzMiBjdXJyZW50X3NlcW5vID0gaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUp
Owo+IC0JCXUzMiBsYXN0X3NlcW5vID0gaW50ZWxfZW5naW5lX2xhc3Rfc3VibWl0KGVuZ2luZSk7
Cj4gKwkJc3RydWN0IGludGVsX2VuZ2luZV9wbXUgKnBtdSA9ICZlbmdpbmUtPnBtdTsKPiArCQli
b29sIGJ1c3k7Cj4gIAkJdTMyIHZhbDsKPiAgCj4gLQkJdmFsID0gIWk5MTVfc2Vxbm9fcGFzc2Vk
KGN1cnJlbnRfc2Vxbm8sIGxhc3Rfc2Vxbm8pOwo+IC0KPiAtCQlpZiAodmFsKQo+IC0JCQlhZGRf
c2FtcGxlKCZlbmdpbmUtPnBtdS5zYW1wbGVbSTkxNV9TQU1QTEVfQlVTWV0sCj4gLQkJCQkgICBw
ZXJpb2RfbnMpOwo+IC0KPiAtCQlpZiAodmFsICYmIChlbmdpbmUtPnBtdS5lbmFibGUgJgo+IC0J
CSAgICAoQklUKEk5MTVfU0FNUExFX1dBSVQpIHwgQklUKEk5MTVfU0FNUExFX1NFTUEpKSkpIHsK
PiAtCQkJZncgPSBncmFiX2ZvcmNld2FrZShkZXZfcHJpdiwgZncpOwo+IC0KPiAtCQkJdmFsID0g
STkxNV9SRUFEX0ZXKFJJTkdfQ1RMKGVuZ2luZS0+bW1pb19iYXNlKSk7Cj4gLQkJfSBlbHNlIHsK
PiAtCQkJdmFsID0gMDsKPiAtCQl9Cj4gKwkJdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfQ1RMKGVu
Z2luZS0+bW1pb19iYXNlKSk7Cj4gKwkJaWYgKHZhbCA9PSAwKSAvKiBwb3dlcndlbGwgb2ZmID0+
IGVuZ2luZSBpZGxlICovCj4gKwkJCWNvbnRpbnVlOwo+ICAKPiAgCQlpZiAodmFsICYgUklOR19X
QUlUKQo+IC0JCQlhZGRfc2FtcGxlKCZlbmdpbmUtPnBtdS5zYW1wbGVbSTkxNV9TQU1QTEVfV0FJ
VF0sCj4gLQkJCQkgICBwZXJpb2RfbnMpOwo+IC0KPiArCQkJYWRkX3NhbXBsZSgmcG11LT5zYW1w
bGVbSTkxNV9TQU1QTEVfV0FJVF0sIHBlcmlvZF9ucyk7Cj4gIAkJaWYgKHZhbCAmIFJJTkdfV0FJ
VF9TRU1BUEhPUkUpCj4gLQkJCWFkZF9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NB
TVBMRV9TRU1BXSwKPiAtCQkJCSAgIHBlcmlvZF9ucyk7Cj4gLQl9Cj4gKwkJCWFkZF9zYW1wbGUo
JnBtdS0+c2FtcGxlW0k5MTVfU0FNUExFX1NFTUFdLCBwZXJpb2RfbnMpOwo+ICAKPiAtCWlmIChm
dykKPiAtCQlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FM
TCk7Cj4gKwkJLyoKPiArCQkgKiBNSV9NT0RFIHJlcG9ydHMgSURMRSBpZiB0aGUgcmluZyBpcyB3
YWl0aW5nLCBidXQgd2UgcmVnYXJkCj4gKwkJICogdGhpcyBhcyBiZWluZyBidXN5IGluc3RlYWQs
IGFzIHRoZSBlbmdpbmUgaXMgYnVzeSB3aXRoIHRoZQo+ICsJCSAqIHVzZXIgcmVxdWVzdC4KPiAr
CQkgKi8KPiArCQlidXN5ID0gdmFsICYgKFJJTkdfV0FJVF9TRU1BUEhPUkUgfCBSSU5HX1dBSVQp
Owo+ICsJCWlmICghYnVzeSkgewo+ICsJCQl2YWwgPSBJOTE1X1JFQURfRlcoUklOR19NSV9NT0RF
KGVuZ2luZS0+bW1pb19iYXNlKSk7Cj4gKwkJCWJ1c3kgPSAhKHZhbCAmIE1PREVfSURMRSk7CgpU
aGUgY29tbWVudCBtYWtlcyBzZW5zZSBpZiB5b3UgZG8KYnVzeSA9IHZhbCAmIE1PREVfSURMRTsK
Ci1NaWthCgo+ICsJCX0KPiArCQlpZiAoYnVzeSkKPiArCQkJYWRkX3NhbXBsZSgmcG11LT5zYW1w
bGVbSTkxNV9TQU1QTEVfQlVTWV0sIHBlcmlvZF9ucyk7Cj4gKwl9Cj4gIAo+ICAJaW50ZWxfcnVu
dGltZV9wbV9wdXQoZGV2X3ByaXYsIHdha2VyZWYpOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3JpbmdidWZmZXIuaAo+IGluZGV4IDcxMGZmYjIyMTc3NS4uNWQ0NWFkNGVjY2E5IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0zOTIsNyAr
MzkyLDcgQEAgc3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4gIAkJYm9vbCBpcnFfYXJtZWQ7Cj4g
IAl9IGJyZWFkY3J1bWJzOwo+ICAKPiAtCXN0cnVjdCB7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5l
X3BtdSB7Cj4gIAkJLyoqCj4gIAkJICogQGVuYWJsZTogQml0bWFzayBvZiBlbmFibGUgc2FtcGxl
IGV2ZW50cyBvbiB0aGlzIGVuZ2luZS4KPiAgCQkgKgo+IC0tIAo+IDIuMjAuMQo+Cj4gX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp
bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp
c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==