From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Don't claim an unstarted request
 was guilty
Date: Fri, 08 Feb 2019 16:47:13 +0200
Message-ID: <878syq2v7y.fsf@gaia.fi.intel.com>
References: <20190207071829.5574-8-chris@chris-wilson.co.uk>
 <20190207074137.11189-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A24576E318
 for <intel-gfx@lists.freedesktop.org>; Fri,  8 Feb 2019 14:47:25 +0000 (UTC)
In-Reply-To: <20190207074137.11189-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSWYgd2Ug
aGF2ZW4ndCBldmVuIGJlZ3VuIGV4ZWN1dGluZyB0aGUgcGF5bG9hZCBvZiB0aGUgc3RhbGxlZCBy
ZXF1ZXN0LAo+IHRoZW4gd2Ugc2hvdWxkIG5vdCBjbGFpbSB0aGF0IGl0cyB1c2Vyc3BhY2UgY29u
dGV4dCB3YXMgZ3VpbHR5IG9mCj4gc3VibWl0dGluZyBhIGhhbmdpbmcgYmF0Y2guCj4KPiB2Mjog
Q2hlY2sgZm9yIGNvbnRleHQgY29ycnVwdGlvbiBiZWZvcmUgdHJ5aW5nIHRvIHJlc3RhcnQuCj4g
djM6IFByZXNlcnZlIHNlbWFwaG9yZXMgb24gc2tpcHBpbmcgcmVxdWVzdHMgKG5lZWQgdG8ga2Vl
cCB0aGUgdGltZWxpbmVzCj4gaW50YWN0KS4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNv
biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9scmMuYyAgICAgICAgICAgICAgfCA0MiArKysrKysrKysrKysrKysrKy0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pZ3Rfc3Bpbm5lci5jICB8ICA5ICsrKy0KPiAg
Li4uL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfaGFuZ2NoZWNrLmMgIHwgIDYgKysrCj4g
IDMgZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggNWU5OGZkNzliZDlkLi5lMzEzNGE2MzU5MjYg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xMzg3LDYgKzEzODcsMTAgQEAg
c3RhdGljIGludCBnZW44X2VtaXRfaW5pdF9icmVhZGNydW1iKHN0cnVjdCBpOTE1X3JlcXVlc3Qg
KnJxKQo+ICAJKmNzKysgPSBycS0+ZmVuY2Uuc2Vxbm8gLSAxOwo+ICAKPiAgCWludGVsX3Jpbmdf
YWR2YW5jZShycSwgY3MpOwo+ICsKPiArCS8qIFJlY29yZCB0aGUgdXBkYXRlZCBwb3NpdGlvbiBv
ZiB0aGUgcmVxdWVzdCdzIHBheWxvYWQgKi8KPiArCXJxLT5pbmZpeCA9IGludGVsX3Jpbmdfb2Zm
c2V0KHJxLCBjcyk7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTE4NzgsNiArMTg4
MiwyMyBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfcmVzZXRfcHJlcGFyZShzdHJ1Y3QgaW50ZWxf
ZW5naW5lX2NzICplbmdpbmUpCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRp
bWVsaW5lLmxvY2ssIGZsYWdzKTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgbHJjX3JlZ3Nfb2so
Y29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBpbnRl
bF9yaW5nICpyaW5nID0gcnEtPnJpbmc7Cj4gKwljb25zdCB1MzIgKnJlZ3MgPSBycS0+aHdfY29u
dGV4dC0+bHJjX3JlZ19zdGF0ZTsKPiArCj4gKwkvKiBRdWljayBzcG90IGNoZWNrIGZvciB0aGUg
Y29tbW9uIHNpZ25zIG9mIGNvbnRleHQgY29ycnVwdGlvbiAqLwo+ICsKPiArCWlmIChyZWdzW0NU
WF9SSU5HX0JVRkZFUl9DT05UUk9MICsgMV0gIT0KPiArCSAgICAoUklOR19DVExfU0laRShyaW5n
LT5zaXplKSB8IFJJTkdfVkFMSUQpKQo+ICsJCXJldHVybiBmYWxzZTsKCllvdSBiZWVuIG5vdGlj
aW5nIHRoaXMgd2l0aCBjdHggY29ycnVwdGlvbj8gV2VsbCBub3cKdGhpbmtpbmcgYWJvdXQgaXQs
IHdlIGhhdmUgaGFkIHJlcG9ydHMgd2hlcmUgb24gaW5pdCwKb24gc29tZSB0cm91YmxlLCB0aGUg
dmFsaWQgdmFuaXNoZXMuCgoKPiArCj4gKwlpZiAocmVnc1tDVFhfUklOR19CVUZGRVJfU1RBUlQg
KyAxXSAhPSBpOTE1X2dndHRfb2Zmc2V0KHJpbmctPnZtYSkpCj4gKwkJcmV0dXJuIGZhbHNlOwo+
ICsKClNlZW4gdGhpcyBvbiBidWd6aWxsYSByZXBvcnRzIHRvby4gQXJlIHRoZXJlIG1vcmUKaW4g
eW91ciBzbGVldmUgb3IgaXMgdGhpcyBhIGNvbXByb21pc2Ugb24gY29tcGxleGl0eQphbmQgcGVy
Zm9ybWFuY2U/IENoZWNraW5nIG9uIGEgc2FuZSBhY3R1YWwgaGVhZCB0b28/CgpUaGUgaGV1cmlz
dGljcyBvZiBpdCBib3RoZXJzIG1lIHNvbWUgYXMgd2Ugd2lsbApnZXQgZmFsc2UgcG9zaXRpdmVz
LgoKU28gaW4gZWZmZWN0LCB3aGVuIHdlIGdldCBvbmUsIHdlIGp1c3QgbW92ZSBhaGVhZAphZnRl
ciBhbiBleHRyYSByZXNldCBhcyB3ZSBnb3QgaXQgYWxsIHdyb25nPwoKPiArCXJldHVybiB0cnVl
Owo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBleGVjbGlzdHNfcmVzZXQoc3RydWN0IGludGVsX2Vu
Z2luZV9jcyAqZW5naW5lLCBib29sIHN0YWxsZWQpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9lbmdp
bmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3RzOwo+IEBA
IC0xOTEyLDYgKzE5MzMsMjEgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX3Jlc2V0KHN0cnVjdCBp
bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgYm9vbCBzdGFsbGVkKQo+ICAJaWYgKCFycSkKPiAgCQln
b3RvIG91dF91bmxvY2s7Cj4gIAo+ICsJLyoKPiArCSAqIElmIHRoaXMgcmVxdWVzdCBoYXNuJ3Qg
c3RhcnRlZCB5ZXQsIGUuZy4gaXQgaXMgd2FpdGluZyBvbiBhCj4gKwkgKiBzZW1hcGhvcmUsIHdl
IG5lZWQgdG8gYXZvaWQgc2tpcHBpbmcgdGhlIHJlcXVlc3Qgb3IgZWxzZSB3ZQo+ICsJICogYnJl
YWsgdGhlIHNpZ25hbGluZyBjaGFpbi4gSG93ZXZlciwgaWYgdGhlIGNvbnRleHQgaXMgY29ycnVw
dAo+ICsJICogdGhlIHJlcXVlc3Qgd2lsbCBub3QgcmVzdGFydCBhbmQgd2Ugd2lsbCBiZSBzdHVj
ayB3aXRoIGEgd2VkZ2VkCj4gKwkgKiBkZXZpY2UuIEl0IGlzIHF1aXRlIG9mdGVuIHRoZSBjYXNl
IHRoYXQgaWYgd2UgaXNzdWUgYSByZXNldAo+ICsJICogd2hpbGUgdGhlIEdQVSBpcyBsb2FkaW5n
IHRoZSBjb250ZXh0IGltYWdlLCB0aGF0IGNvbnRleHQgaW1hZ2UKPiArCSAqIGJlY29tZXMgY29y
cnVwdC4KPiArCSAqCj4gKwkgKiBPdGhlcndpc2UsIGlmIHdlIGhhdmUgbm90IHN0YXJ0ZWQgeWV0
LCB0aGUgcmVxdWVzdCBzaG91bGQgcmVwbGF5Cj4gKwkgKiBwZXJmZWN0bHkgYW5kIHdlIGRvIG5v
dCBuZWVkIHRvIGZsYWcgdGhlIHJlc3VsdCBhcyBiZWluZyBlcnJvbmVvdXMuCj4gKwkgKi8KPiAr
CWlmICghaTkxNV9yZXF1ZXN0X3N0YXJ0ZWQocnEpICYmIGxyY19yZWdzX29rKHJxKSkKPiArCQln
b3RvIG91dF91bmxvY2s7Cj4gKwo+ICAJLyoKPiAgCSAqIElmIHRoZSByZXF1ZXN0IHdhcyBpbm5v
Y2VudCwgd2UgbGVhdmUgdGhlIHJlcXVlc3QgaW4gdGhlIEVMU1AKPiAgCSAqIGFuZCB3aWxsIHRy
eSB0byByZXBsYXkgaXQgb24gcmVzdGFydGluZy4gVGhlIGNvbnRleHQgaW1hZ2UgbWF5Cj4gQEAg
LTE5MjQsNyArMTk2MCw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19yZXNldChzdHJ1Y3QgaW50
ZWxfZW5naW5lX2NzICplbmdpbmUsIGJvb2wgc3RhbGxlZCkKPiAgCSAqIGltYWdlIGJhY2sgdG8g
dGhlIGV4cGVjdGVkIHZhbHVlcyB0byBza2lwIG92ZXIgdGhlIGd1aWx0eSByZXF1ZXN0Lgo+ICAJ
ICovCj4gIAlpOTE1X3Jlc2V0X3JlcXVlc3QocnEsIHN0YWxsZWQpOwo+IC0JaWYgKCFzdGFsbGVk
KQo+ICsJaWYgKCFzdGFsbGVkICYmIGxyY19yZWdzX29rKHJxKSkKCkV4dGVuZCB0aGUgY3R4IHZh
bGlkYXRvciB1c2FnZSBmb3Igb24gZ3VpbHR5IGVuZ2luZXMsIHdlbGwgd2h5IG5vdC4KLU1pa2EK
Cj4gIAkJZ290byBvdXRfdW5sb2NrOwo+ICAKPiAgCS8qCj4gQEAgLTE5NDIsOCArMTk3OCw4IEBA
IHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19yZXNldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp
bmUsIGJvb2wgc3RhbGxlZCkKPiAgCQkgICAgICAgZW5naW5lLT5jb250ZXh0X3NpemUgLSBQQUdF
X1NJWkUpOwo+ICAJfQo+ICAKPiAtCS8qIE1vdmUgdGhlIFJJTkdfSEVBRCBvbnRvIHRoZSBicmVh
ZGNydW1iLCBwYXN0IHRoZSBoYW5naW5nIGJhdGNoICovCj4gLQlycS0+cmluZy0+aGVhZCA9IGlu
dGVsX3Jpbmdfd3JhcChycS0+cmluZywgcnEtPnBvc3RmaXgpOwo+ICsJLyogUmVydW4gdGhlIHJl
cXVlc3Q7IGl0cyBwYXlsb2FkIGhhcyBiZWVuIG5ldXRlcmVkIChpZiBndWlsdHkpLiAqLwo+ICsJ
cnEtPnJpbmctPmhlYWQgPSBpbnRlbF9yaW5nX3dyYXAocnEtPnJpbmcsIHJxLT5oZWFkKTsKPiAg
CWludGVsX3JpbmdfdXBkYXRlX3NwYWNlKHJxLT5yaW5nKTsKPiAgCj4gIAlleGVjbGlzdHNfaW5p
dF9yZWdfc3RhdGUocmVncywgcnEtPmdlbV9jb250ZXh0LCBlbmdpbmUsIHJxLT5yaW5nKTsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2lndF9zcGlubmVyLmMg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaWd0X3NwaW5uZXIuYwo+IGluZGV4IDll
YmQ5MjI1Njg0ZS4uODYzNTRlNTFiZGQzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L3NlbGZ0ZXN0cy9pZ3Rfc3Bpbm5lci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
c2VsZnRlc3RzL2lndF9zcGlubmVyLmMKPiBAQCAtMTQyLDEwICsxNDIsMTcgQEAgaWd0X3NwaW5u
ZXJfY3JlYXRlX3JlcXVlc3Qoc3RydWN0IGlndF9zcGlubmVyICpzcGluLAo+ICAJKmJhdGNoKysg
PSB1cHBlcl8zMl9iaXRzKHZtYS0+bm9kZS5zdGFydCk7Cj4gIAkqYmF0Y2grKyA9IE1JX0JBVENI
X0JVRkZFUl9FTkQ7IC8qIG5vdCByZWFjaGVkICovCj4gIAo+IC0JaTkxNV9nZW1fY2hpcHNldF9m
bHVzaChzcGluLT5pOTE1KTsKPiArCWlmIChlbmdpbmUtPmVtaXRfaW5pdF9icmVhZGNydW1iICYm
Cj4gKwkgICAgcnEtPnRpbWVsaW5lLT5oYXNfaW5pdGlhbF9icmVhZGNydW1iKSB7Cj4gKwkJZXJy
ID0gZW5naW5lLT5lbWl0X2luaXRfYnJlYWRjcnVtYihycSk7Cj4gKwkJaWYgKGVycikKPiArCQkJ
Z290byBjYW5jZWxfcnE7Cj4gKwl9Cj4gIAo+ICAJZXJyID0gZW5naW5lLT5lbWl0X2JiX3N0YXJ0
KHJxLCB2bWEtPm5vZGUuc3RhcnQsIFBBR0VfU0laRSwgMCk7Cj4gIAo+ICsJaTkxNV9nZW1fY2hp
cHNldF9mbHVzaChzcGluLT5pOTE1KTsKPiArCj4gIGNhbmNlbF9ycToKPiAgCWlmIChlcnIpIHsK
PiAgCQlpOTE1X3JlcXVlc3Rfc2tpcChycSwgZXJyKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2hhbmdjaGVjay5jIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvc2VsZnRlc3RzL2ludGVsX2hhbmdjaGVjay5jCj4gaW5kZXggNDg4NmZhYzEyNjI4Li4z
NmMxN2JmZTA1YTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3Rz
L2ludGVsX2hhbmdjaGVjay5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3Rz
L2ludGVsX2hhbmdjaGVjay5jCj4gQEAgLTI0Niw2ICsyNDYsMTIgQEAgaGFuZ19jcmVhdGVfcmVx
dWVzdChzdHJ1Y3QgaGFuZyAqaCwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJ
aWYgKElOVEVMX0dFTih2bS0+aTkxNSkgPD0gNSkKPiAgCQlmbGFncyB8PSBJOTE1X0RJU1BBVENI
X1NFQ1VSRTsKPiAgCj4gKwlpZiAocnEtPmVuZ2luZS0+ZW1pdF9pbml0X2JyZWFkY3J1bWIpIHsK
PiArCQllcnIgPSBycS0+ZW5naW5lLT5lbWl0X2luaXRfYnJlYWRjcnVtYihycSk7Cj4gKwkJaWYg
KGVycikKPiArCQkJZ290byBjYW5jZWxfcnE7Cj4gKwl9Cj4gKwo+ICAJZXJyID0gcnEtPmVuZ2lu
ZS0+ZW1pdF9iYl9zdGFydChycSwgdm1hLT5ub2RlLnN0YXJ0LCBQQUdFX1NJWkUsIGZsYWdzKTsK
PiAgCj4gIGNhbmNlbF9ycToKPiAtLSAKPiAyLjIwLjEKPgo+IF9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK