intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/7] drm/i915: replace IS_GEN<N> with GT_GEN(..., N)
Date: Fri, 23 Nov 2018 14:42:59 +0200	[thread overview]
Message-ID: <878t1kc6cs.fsf@intel.com> (raw)
In-Reply-To: <20181121222047.GG13148@intel.com>

On Wed, 21 Nov 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Nov 06, 2018 at 01:51:19PM -0800, Lucas De Marchi wrote:
>> Define GT_GEN() similarly to our GT_GEN_RANGE() and convert users of
>> IS_GEN<N> to pss the gen as parameter. This prepares for the addition
>> of display gen checks by renaming the IS_GENx() and using common code
>> for all the n gens.
>> 
>> The following spatch was used to convert the users of these macros:
>> 
>> @@
>> expression e;
>> @@
>> (
>> - IS_GEN2(e)
>> + GT_GEN(e, 2)
>> |
>> - IS_GEN3(e)
>> + GT_GEN(e, 3)
>> |
>> - IS_GEN4(e)
>> + GT_GEN(e, 4)
>> |
>> - IS_GEN5(e)
>> + GT_GEN(e, 5)
>> |
>> - IS_GEN6(e)
>> + GT_GEN(e, 6)
>> |
>> - IS_GEN7(e)
>> + GT_GEN(e, 7)
>> |
>> - IS_GEN8(e)
>> + GT_GEN(e, 8)
>> |
>> - IS_GEN9(e)
>> + GT_GEN(e, 9)
>> |
>> - IS_GEN10(e)
>> + GT_GEN(e, 10)
>> |
>> - IS_GEN11(e)
>> + GT_GEN(e, 11)
>> )
>> 
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

I think this is a contentious patch. I am not sure I agree with the
change. Please hold off on merging until further discussion.


Thanks,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-11-23 12:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 21:51 [PATCH v2 0/7] Make GEN macros more similar Lucas De Marchi
2018-11-06 21:51 ` [PATCH v2 1/7] Revert "drm/i915: Kill GEN_FOREVER" Lucas De Marchi
2018-11-21 22:22   ` Rodrigo Vivi
2018-11-06 21:51 ` [PATCH v2 2/7] drm/i915: Rename IS_GEN to GT_RANGE Lucas De Marchi
2018-11-28  8:02   ` Jani Nikula
2018-11-28  9:27     ` Joonas Lahtinen
2018-11-28 17:04     ` Rodrigo Vivi
2018-11-28 17:34     ` Lucas De Marchi
2018-11-06 21:51 ` [PATCH v2 3/7] drm/i915: replace IS_GEN<N> with GT_GEN(..., N) Lucas De Marchi
2018-11-21 22:20   ` Rodrigo Vivi
2018-11-23 12:42     ` Jani Nikula [this message]
2018-11-26 18:49       ` Rodrigo Vivi
2018-11-27  8:31         ` Jani Nikula
2018-11-28  0:09           ` Rodrigo Vivi
2018-11-06 21:51 ` [PATCH v2 4/7] drm/i915: rename IS_GEN9_* to GT_GEN9_* Lucas De Marchi
2018-11-21 22:22   ` Rodrigo Vivi
2018-11-06 21:51 ` [PATCH v2 5/7] drm/i915: replace gen checks using operators by GT_GEN/GT_GEN_RANGE Lucas De Marchi
2018-11-06 21:51 ` [PATCH v2 6/7] drm/i915: merge gen checks to use range Lucas De Marchi
2018-11-21 22:24   ` Rodrigo Vivi
2018-11-06 21:51 ` [PATCH v2 7/7] drm/i915: remove INTEL_GEN macro Lucas De Marchi
2018-11-07 10:05 ` [PATCH v2 0/7] Make GEN macros more similar Tvrtko Ursulin
2018-11-08  0:57   ` Lucas De Marchi
2018-11-08 11:23     ` Tvrtko Ursulin
2018-11-19 22:20       ` Lucas De Marchi
2018-11-20 13:40         ` Tvrtko Ursulin
2018-11-21 22:19         ` Rodrigo Vivi
2018-11-22  8:54           ` Tvrtko Ursulin
2018-11-26 18:46             ` Rodrigo Vivi
2018-11-27  8:37               ` Jani Nikula
2018-11-27  9:36                 ` Lucas De Marchi
2018-11-27 11:35                   ` Tvrtko Ursulin
2018-11-28  0:19                     ` Rodrigo Vivi
2018-11-28 17:22                       ` Lucas De Marchi
2018-11-23 12:44         ` Jani Nikula
2018-11-07 14:10 ` ✗ Fi.CI.CHECKPATCH: warning for Make GEN macros more similar (rev2) Patchwork
2018-11-07 14:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-07 14:30 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-07 21:17 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t1kc6cs.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).