From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 13/18] drm/vc4: Use drm_atomic_helper_shutdown
Date: Wed, 03 Oct 2018 13:31:18 -0700
Message-ID: <878t3esrft.fsf@anholt.net>
References: <20181002133526.13685-1-daniel.vetter@ffwll.ch>
 <20181003091827.25276-1-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1741216599=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20181003091827.25276-1-daniel.vetter@ffwll.ch>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

--===============1741216599==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> drm_plane_helper_disable is a non-atomic drivers only function, and
> will blow up (since no one passes the locking context it needs).
>
> Atomic drivers which want to quiescent their hw on unload should
> use drm_atomic_helper_shutdown() instead.
>
> v2: Rebase.

I've definitely never tested unload.

Looks like we could drop vc4_plane_destroy() entirely?  Regardless,
acked-by.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlu1JxYACgkQtdYpNtH8
nuiONQ/+MXh7Uw+SoXgJ0WPOKLBpW+WYOCyo/x42k/rQspOvk455F3766uGjH19b
sN1rLp5sp3qB01LTeEUOTm9vWQddbzFOqE+EKVzBcBUgD3QLt/fRdh3rq54Tr2Ao
wQai5LfMUwufZMaUP/r6KjG2E2qnyXfmJocrXRJnoS2iluZzLPYykQmgZEVsmj9M
j5h0snYZ3u4tTbmr9NGzFx7EO8MKVv7sUKcG/AUw+DDGClYo57WDDgqoPFNYOBJM
kokAFF484B7GXBGk53auWBRHIlg1iL4MTloxa+xQn4kfGQSPqrp7cobKlLsNypum
5kryEEnZWl3WUlIreA+iCEtNyiUbMFxhNLnABlSgjqpe4sZ/4M9f/7qUMFnbohD+
NFb9Qsc8xIpcQXM5lLbi1IJI/iPAJsh+wFXhcn/Bfw5h8K1paGYnYLdK91An60GL
bK7ro1LrAallZQ3jKjb638mFGvv1aLsdFXRodcK/Y0IyZSunz5wLVfWMXMaHflI7
mwvNyQnBCjKVgirffEP+JPhf+SqimuJ0VT54JZWuC8cUOyFYABzhawT6Bn7xsfWR
1QuLTLF6sUZCMQwDH3IC5aUT7jumCeF+/df+KdL6ltJpdRLRKy/nxGQLLELDukMw
hA3PTCiEJC352bHweJGH0y+UuJKNReh1XwNAa7nH+wOYUIY9DvY=
=2/GP
-----END PGP SIGNATURE-----
--=-=-=--

--===============1741216599==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============1741216599==--