From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 4/5] drm/i915/execlists: Split spinlock from its irq disabling side-effect Date: Fri, 02 Mar 2018 18:11:52 +0200 Message-ID: <878tbapid3.fsf@gaia.fi.intel.com> References: <20180302143246.2579-1-chris@chris-wilson.co.uk> <20180302143246.2579-4-chris@chris-wilson.co.uk> <87efl2pjc2.fsf@gaia.fi.intel.com> <152000668483.32001.17411762790378694149@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A51846E1C0 for ; Fri, 2 Mar 2018 16:16:28 +0000 (UTC) In-Reply-To: <152000668483.32001.17411762790378694149@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE4LTAzLTAyIDE1OjUwOjUzKQo+PiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiAKPj4gPiBEdXJpbmcgcmVzZXQvd2Vk Z2luZywgd2UgaGF2ZSB0byBjbGVhbiB1cCB0aGUgcmVxdWVzdHMgb24gdGhlIHRpbWVsaW5lCj4+ ID4gYW5kIGZsdXNoIHRoZSBwZW5kaW5nIGludGVycnVwdCBzdGF0ZS4gQ3VycmVudGx5LCB3ZSBh cmUgYWJ1c2luZyB0aGUgaXJxCj4+ID4gZGlzYWJsaW5nIG9mIHRoZSB0aW1lbGluZSBzcGlubG9j ayB0byBwcm90ZWN0IHRoZSBpcnEgc3RhdGUgaW4KPj4gPiBjb25qdW5jdGlvbiB0byB0aGUgZW5n aW5lJ3MgdGltZWxpbmUgcmVxdWVzdHMsIGJ1dCB0aGlzIGlzIGFjY2lkZW50YWwKPj4gPiBhbmQg Y29uZmxhdGVzIHRoZSBzcGlubG9jayB3aXRoIHRoZSBpcnEgc3RhdGUuIEEgYmFmZmxpbmcgc3Rh dGUgb2YKPj4gPiBhZmZhaXJzIGZvciB0aGUgcmVhZGVyLgo+PiA+Cj4+ID4gSW5zdGVhZCwgZXhw bGljaXRseSBkaXNhYmxlIGlycXMgb3ZlciB0aGUgY3JpdGljYWwgc2VjdGlvbiwgYW5kIHNlcGFy YXRlCj4+ID4gbW9kaWZ5aW5nIHRoZSBpcnEgc3RhdGUgZnJvbSB0aGUgdGltZWxpbmUncyByZXF1 ZXN0cy4KPj4gPgo+PiA+IFN1Z2dlc3RlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFs YUBsaW51eC5pbnRlbC5jb20+Cj4+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4+ID4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBh bGFAbGludXguaW50ZWwuY29tPgo+PiA+IENjOiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVy cnlAaW50ZWwuY29tPgo+PiA+IC0tLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyB8IDIxICsrKysrKysrKysrKysrKy0tLS0tLQo+PiA+ICAxIGZpbGUgY2hhbmdlZCwgMTUg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4+ID4gaW5kZXggMDQ4MmU1NGM5NGYwLi43ZDExMDlhY2VhYmIgMTAwNjQ0Cj4+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiA+IEBAIC02ODksMTEgKzY4OSwxMyBAQCBzdGF0 aWMgdm9pZCBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPj4gPiAgCj4+ID4gICAgICAgR0VNX1RSQUNFKCIlc1xuIiwgZW5naW5lLT5uYW1l KTsKPj4gPiAgCj4+ID4gLSAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2luZS0+dGltZWxpbmUt PmxvY2ssIGZsYWdzKTsKPj4gPiArICAgICBsb2NhbF9pcnFfc2F2ZShmbGFncyk7Cj4+IAo+PiBD aHJpcyBleHBsYWluZWQgaW4gaXJjIHRoYXQgdGhpcyBpcyBmb3IgbG9ja2RlcCBvbmx5LiBJdCB3 YXMgYSBiaXQKPj4gY29uZnVzaW5nIGFzIHdlIGFscmVhZHkgYXJlIGd1YXJhbnRlZWQgZXhjbHVz aXZlIGFjY2VzcyB0bwo+PiBzdGF0ZSBieSB0YXNrbGV0IGJlaW5nIGtpbGxlZCBhbmQgZGVhZCBh dCB0aGlzIHBvaW50Lgo+PiAKPj4gSSB0aGluayB0aGlzIHdhcnJhbnRzIGEgY29tbWVudCB0aGF0 IHRoaXMgaXMgdG8gc29vdGhlIGxvY2tkZXAuCj4KPiAvKgo+ICAqIEJlZm9yZSB3ZSBjYWxsIGVu Z2luZS0+Y2FuY2VsX3JlcXVlc3RzKCksIHdlIHNob3VsZCBoYXZlIGV4Y2x1c2l2ZQo+ICAqIGFj Y2VzcyB0byB0aGUgc3VibWlzc2lvbiBzdGF0ZS4gVGhpcyBpcyBhcnJhbmdlZCBmb3IgdXMgYnkg dGhlIGNhbGxlcgo+ICAqIGRpc2FibGluZyB0aGUgaW50ZXJydXB0IGdlbmVyYXRpb24sIHRoZSB0 YXNrbGV0IGFuZCBvdGhlciB0aHJlYWRzCj4gICogdGhhdCBtYXkgdGhlbiBhY2Nlc3MgdGhlIHNh bWUgc3RhdGUsIGdpdmluZyB1cyBhIGZyZWUgaGFuZCB0bwo+ICAqIHJlc2V0IHN0YXRlLiBIb3dl dmVyLCB3ZSBzdGlsbCBuZWVkIHRvIGxldCBsb2NrZGVwIGJlIGF3YXJlIHRoYXQKPiAgKiB3ZSBr bm93IHRoaXMgc3RhdGUgbWF5IGJlIGFjY2Vzc2VkIGluIGhhcmRpcnEgY29udGV4dCwgc28gd2UK PiAgKiBkaXNhYmxlIHRoZSBpcnEgYXJvdW5kIHRoaXMgbWFuaXB1bGF0aW9uIGFuZCB3ZSB3YW50 IHRvIGtlZXAKPiAgKiB0aGUgc3BpbmxvY2sgZm9jdXNlZCBvbiBpdHMgZHV0aWVzIGFuZCBub3Qg YWNjaWRlbnRhbGx5IGNvbmZsYXRlCj4gICogY292ZXJhZ2UgdG8gdGhlIHN1Ym1pc3Npb24ncyBp cnEgc3RhdGUuIChTaW1pbGFybHksIGFsdGhvdWdoIHdlCj4gICogc2hvdWxkbid0IG5lZWQgdG8g ZGlzYWJsZSBpcnEgYXJvdW5kIHRoZSBtYW5pcHVsYXRpb24gb2YgdGhlCj4gICogc3VibWlzc2lv bidzIGlycSBzdGF0ZSwgd2UgYWxzbyB3aXNoIHRvIHJlbWluZCBvdXJzZWx2ZXMgdGhhdAo+ICAq IGl0IGlzIGlycSBzdGF0ZS4pCj4gICovCj4KPj4gPiAgCj4+ID4gICAgICAgLyogQ2FuY2VsIHRo ZSByZXF1ZXN0cyBvbiB0aGUgSFcgYW5kIGNsZWFyIHRoZSBFTFNQIHRyYWNrZXIuICovCj4+ID4g ICAgICAgZXhlY2xpc3RzX2NhbmNlbF9wb3J0X3JlcXVlc3RzKGV4ZWNsaXN0cyk7Cj4+ID4gIAo+ PiA+ICsgICAgIHNwaW5fbG9jaygmZW5naW5lLT50aW1lbGluZS0+bG9jayk7Cj4+ID4gQEAgLTE2 MTgsMTAgKzE2MjIsMTEgQEAgc3RhdGljIHZvaWQgcmVzZXRfY29tbW9uX3Jpbmcoc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+PiA+ICAgICAgIEdFTV9UUkFDRSgiJXMgc2Vxbm89JXhc biIsCj4+ID4gICAgICAgICAgICAgICAgIGVuZ2luZS0+bmFtZSwgcmVxdWVzdCA/IHJlcXVlc3Qt Pmdsb2JhbF9zZXFubyA6IDApOwo+PiA+ICAKPj4gPiAtICAgICBzcGluX2xvY2tfaXJxc2F2ZSgm ZW5naW5lLT50aW1lbGluZS0+bG9jaywgZmxhZ3MpOwo+Cj4gCS8qIFNlZSBleGVjbGlzdHNfY2Fu Y2VsX3JlcXVlc3RzKCkgZm9yIHRoZSBpcnEvc3BpbmxvY2sgc3BsaXQuICovCj4+ID4gKyAgICAg bG9jYWxfaXJxX3NhdmUoZmxhZ3MpOwo+Cj4gR29vZD8KCk11Y2ggbW9yZSB0aGFuIEkgYmFyZ2Fp bmVkIGZvci4gRXhjZWxsZW50IQotTWlrYQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK