From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915: Prune gen8_gt_irq_handler Date: Mon, 19 Feb 2018 15:59:43 +0200 Message-ID: <878tbpt700.fsf@gaia.fi.intel.com> References: <20180215073713.26985-2-chris@chris-wilson.co.uk> <20180219100926.16554-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE5586E18C for ; Mon, 19 Feb 2018 14:02:44 +0000 (UTC) In-Reply-To: <20180219100926.16554-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVGhlIGNv bXBpbGVyIGlzIG5vdCBhdXRvbWF0aWNhbGx5IGNhY2hpbmcgdGhlIGk5MTUtPnJlZ3MgYWRkcmVz cyBpbnNpZGUKPiBhIHJlZ2lzdGVyIGFuZCBlbWl0dGluZyBhIGxvYWQgZm9yIGV2ZXJ5IG1taW8g YWNjZXNzLiBGb3Igc2ltcGxlCj4gZnVuY3Rpb25zIGxpa2UgZ2VuOF9ndF9pcnFfaGFuZGxlciB0 aGF0IGFyZSBhbHJlYWR5IHVzaW5nIHRoZSByYXcKPiBhY2Nlc3NvcnMsIHdlIGNhbiBvcGVuLWNv ZGUgdGhlbSBmb3Igc3Vic3RhbnRpYWwgc2F2aW5nczoKPgo+IGFkZC9yZW1vdmU6IDAvMCBncm93 L3NocmluazogMC8yIHVwL2Rvd246IDAvLTgzICgtODMpCj4gRnVuY3Rpb24gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgb2xkICAgICBuZXcgICBkZWx0YQo+IGdlbjhfZ3RfaXJx X2hhbmRsZXIgICAgICAgICAgICAgICAgICAgICAgICAgIDI5MCAgICAgMjY2ICAgICAtMjQKPiBn ZW44X2d0X2lycV9hY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxODEgICAgIDEyMiAg ICAgLTU5Cj4gVG90YWw6IEJlZm9yZT05NTQ2MzcsIEFmdGVyPTk1NDU1NCwgY2hnIC0wLjAxJQo+ Cj4gdjI6IEFkZCByYXdfcmVnX3JlYWQvcmF3X3JlZ193cml0ZS4KPgo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+IEFuZCBzbyBiZWdpbnMgdGhl IGxvbmcgaGF1bCBvZiBkZS1JOTE1X1JFQUQvV1JJVEUtaW5nIHRoZSBkcml2ZXIuLi4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgICAgfCA1OCArKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vu Y29yZS5oIHwgIDUgKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDMw IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggYzdmNmI3MTll ODZkLi4xN2RlNmNlZjJhMzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMTQx Myw5ICsxNDEzLDExIEBAIGdlbjhfY3NfaXJxX2hhbmRsZXIoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lLCB1MzIgaWlyLCBpbnQgdGVzdF9zaGlmdCkKPiAgCQl0YXNrbGV0X2hpX3NjaGVk dWxlKCZleGVjbGlzdHMtPnRhc2tsZXQpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBnZW44X2d0 X2lycV9hY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICtzdGF0aWMgdm9p ZCBnZW44X2d0X2lycV9hY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gIAkJCSAg ICB1MzIgbWFzdGVyX2N0bCwgdTMyIGd0X2lpcls0XSkKPiAgewo+ICsJdm9pZCBfX2lvbWVtICog Y29uc3QgcmVncyA9IGk5MTUtPnJlZ3M7Cj4gKwo+ICAjZGVmaW5lIEdFTjhfR1RfSVJRUyAoR0VO OF9HVF9SQ1NfSVJRIHwgXAo+ICAJCSAgICAgIEdFTjhfR1RfQkNTX0lSUSB8IFwKPiAgCQkgICAg ICBHRU44X0dUX1ZDUzFfSVJRIHwgXAo+IEBAIC0xNDI1LDYyICsxNDI3LDU4IEBAIHN0YXRpYyB2 b2lkIGdlbjhfZ3RfaXJxX2FjayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g IAkJICAgICAgR0VOOF9HVF9HVUNfSVJRKQo+ICAKPiAgCWlmIChtYXN0ZXJfY3RsICYgKEdFTjhf R1RfUkNTX0lSUSB8IEdFTjhfR1RfQkNTX0lSUSkpIHsKPiAtCQlndF9paXJbMF0gPSBJOTE1X1JF QURfRlcoR0VOOF9HVF9JSVIoMCkpOwo+IC0JCWlmIChndF9paXJbMF0pCj4gLQkJCUk5MTVfV1JJ VEVfRlcoR0VOOF9HVF9JSVIoMCksIGd0X2lpclswXSk7Cj4gKwkJZ3RfaWlyWzBdID0gcmF3X3Jl Z19yZWFkKHJlZ3MsIEdFTjhfR1RfSUlSKDApKTsKPiArCQlpZiAobGlrZWx5KGd0X2lpclswXSkp Cj4gKwkJCXJhd19yZWdfd3JpdGUocmVncywgR0VOOF9HVF9JSVIoMCksIGd0X2lpclswXSk7Cj4g IAl9Cj4gIAo+ICAJaWYgKG1hc3Rlcl9jdGwgJiAoR0VOOF9HVF9WQ1MxX0lSUSB8IEdFTjhfR1Rf VkNTMl9JUlEpKSB7Cj4gLQkJZ3RfaWlyWzFdID0gSTkxNV9SRUFEX0ZXKEdFTjhfR1RfSUlSKDEp KTsKPiAtCQlpZiAoZ3RfaWlyWzFdKQo+IC0JCQlJOTE1X1dSSVRFX0ZXKEdFTjhfR1RfSUlSKDEp LCBndF9paXJbMV0pOwo+ICsJCWd0X2lpclsxXSA9IHJhd19yZWdfcmVhZChyZWdzLCBHRU44X0dU X0lJUigxKSk7Cj4gKwkJaWYgKGxpa2VseShndF9paXJbMV0pKQo+ICsJCQlyYXdfcmVnX3dyaXRl KHJlZ3MsIEdFTjhfR1RfSUlSKDEpLCBndF9paXJbMV0pOwo+ICAJfQo+ICAKPiAtCWlmIChtYXN0 ZXJfY3RsICYgR0VOOF9HVF9WRUNTX0lSUSkgewo+IC0JCWd0X2lpclszXSA9IEk5MTVfUkVBRF9G VyhHRU44X0dUX0lJUigzKSk7Cj4gLQkJaWYgKGd0X2lpclszXSkKPiAtCQkJSTkxNV9XUklURV9G VyhHRU44X0dUX0lJUigzKSwgZ3RfaWlyWzNdKTsKPiArCWlmIChtYXN0ZXJfY3RsICYgKEdFTjhf R1RfUE1fSVJRIHwgR0VOOF9HVF9HVUNfSVJRKSkgewo+ICsJCWd0X2lpclsyXSA9IHJhd19yZWdf cmVhZChyZWdzLCBHRU44X0dUX0lJUigyKSk7Cj4gKwkJaWYgKGxpa2VseShndF9paXJbMl0gJiAo aTkxNS0+cG1fcnBzX2V2ZW50cyB8Cj4gKwkJCQkJaTkxNS0+cG1fZ3VjX2V2ZW50cykpKQo+ICsJ CQlyYXdfcmVnX3dyaXRlKHJlZ3MsIEdFTjhfR1RfSUlSKDIpLAo+ICsJCQkJICAgICAgZ3RfaWly WzJdICYgKGk5MTUtPnBtX3Jwc19ldmVudHMgfAo+ICsJCQkJCQkgICBpOTE1LT5wbV9ndWNfZXZl bnRzKSk7CgpJIHdvdWxkIGdvbmUgYXMgZmFyIGFzIHJlZ19yZWFkIHJlZ193cml0ZSBidXQgdGhh dCBtaWdodCBiZSB0b28gZmFyIDopCgpXZSBsZWF2ZSB0ZSBldmVudHMgaGFuZ2luZyB3aGF0IGFy ZSBvZiBubyBpbnRlcmVzdC4gQXMgd2UgYXJlIGRvaW5nCnRoZSBtYXNrcyB3aXRoIHRoZXNlIHNv IEkgZmluZCBpdCBwZWN1bGlhciB0aGF0IHdlIGRvbnQgYWNrCmV2ZXJ5dGhpbmcgYXMgdGhlIG1h c2tzIHNob3VsZCBiZSBpbiBwbGFjZSBhbmQgcGVyaGFwcyBub3RpZnkgb24KZXZlbnRzIGFwcGVh cmluZyB3aXRob3V0IG9yZGVyIGluIHBsYWNlIGZvciB0aGVtLgoKV2VsbCBpdCBpcyBub3QgaW4g YSBzY29wZSBmb3IgdGhpcyBwYXRjaCB0aG8uIFNvLApSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFs YSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICAJfQo+ICAKPiAtCWlmIChtYXN0 ZXJfY3RsICYgKEdFTjhfR1RfUE1fSVJRIHwgR0VOOF9HVF9HVUNfSVJRKSkgewo+IC0JCWd0X2lp clsyXSA9IEk5MTVfUkVBRF9GVyhHRU44X0dUX0lJUigyKSk7Cj4gLQkJaWYgKGd0X2lpclsyXSAm IChkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cyB8Cj4gLQkJCQkgZGV2X3ByaXYtPnBtX2d1Y19ldmVu dHMpKSB7Cj4gLQkJCUk5MTVfV1JJVEVfRlcoR0VOOF9HVF9JSVIoMiksCj4gLQkJCQkgICAgICBn dF9paXJbMl0gJiAoZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMgfAo+IC0JCQkJCQkgICBkZXZfcHJp di0+cG1fZ3VjX2V2ZW50cykpOwo+IC0JCX0KPiArCWlmIChtYXN0ZXJfY3RsICYgR0VOOF9HVF9W RUNTX0lSUSkgewo+ICsJCWd0X2lpclszXSA9IHJhd19yZWdfcmVhZChyZWdzLCBHRU44X0dUX0lJ UigzKSk7Cj4gKwkJaWYgKGxpa2VseShndF9paXJbM10pKQo+ICsJCQlyYXdfcmVnX3dyaXRlKHJl Z3MsIEdFTjhfR1RfSUlSKDMpLCBndF9paXJbM10pOwo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMg dm9pZCBnZW44X2d0X2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiArc3RhdGljIHZvaWQgZ2VuOF9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSwKPiAgCQkJCXUzMiBtYXN0ZXJfY3RsLCB1MzIgZ3RfaWlyWzRdKQo+ICB7Cj4g IAlpZiAobWFzdGVyX2N0bCAmIChHRU44X0dUX1JDU19JUlEgfCBHRU44X0dUX0JDU19JUlEpKSB7 Cj4gLQkJZ2VuOF9jc19pcnFfaGFuZGxlcihkZXZfcHJpdi0+ZW5naW5lW1JDU10sCj4gKwkJZ2Vu OF9jc19pcnFfaGFuZGxlcihpOTE1LT5lbmdpbmVbUkNTXSwKPiAgCQkJCSAgICBndF9paXJbMF0s IEdFTjhfUkNTX0lSUV9TSElGVCk7Cj4gLQkJZ2VuOF9jc19pcnFfaGFuZGxlcihkZXZfcHJpdi0+ ZW5naW5lW0JDU10sCj4gKwkJZ2VuOF9jc19pcnFfaGFuZGxlcihpOTE1LT5lbmdpbmVbQkNTXSwK PiAgCQkJCSAgICBndF9paXJbMF0sIEdFTjhfQkNTX0lSUV9TSElGVCk7Cj4gIAl9Cj4gIAo+ICAJ aWYgKG1hc3Rlcl9jdGwgJiAoR0VOOF9HVF9WQ1MxX0lSUSB8IEdFTjhfR1RfVkNTMl9JUlEpKSB7 Cj4gLQkJZ2VuOF9jc19pcnFfaGFuZGxlcihkZXZfcHJpdi0+ZW5naW5lW1ZDU10sCj4gKwkJZ2Vu OF9jc19pcnFfaGFuZGxlcihpOTE1LT5lbmdpbmVbVkNTXSwKPiAgCQkJCSAgICBndF9paXJbMV0s IEdFTjhfVkNTMV9JUlFfU0hJRlQpOwo+IC0JCWdlbjhfY3NfaXJxX2hhbmRsZXIoZGV2X3ByaXYt PmVuZ2luZVtWQ1MyXSwKPiArCQlnZW44X2NzX2lycV9oYW5kbGVyKGk5MTUtPmVuZ2luZVtWQ1My XSwKPiAgCQkJCSAgICBndF9paXJbMV0sIEdFTjhfVkNTMl9JUlFfU0hJRlQpOwo+ICAJfQo+ICAK PiAgCWlmIChtYXN0ZXJfY3RsICYgR0VOOF9HVF9WRUNTX0lSUSkgewo+IC0JCWdlbjhfY3NfaXJx X2hhbmRsZXIoZGV2X3ByaXYtPmVuZ2luZVtWRUNTXSwKPiArCQlnZW44X2NzX2lycV9oYW5kbGVy KGk5MTUtPmVuZ2luZVtWRUNTXSwKPiAgCQkJCSAgICBndF9paXJbM10sIEdFTjhfVkVDU19JUlFf U0hJRlQpOwo+ICAJfQo+ICAKPiAgCWlmIChtYXN0ZXJfY3RsICYgKEdFTjhfR1RfUE1fSVJRIHwg R0VOOF9HVF9HVUNfSVJRKSkgewo+IC0JCWlmIChndF9paXJbMl0gJiBkZXZfcHJpdi0+cG1fcnBz X2V2ZW50cykKPiAtCQkJZ2VuNl9ycHNfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIGd0X2lpclsyXSk7 Cj4gLQo+IC0JCWlmIChndF9paXJbMl0gJiBkZXZfcHJpdi0+cG1fZ3VjX2V2ZW50cykKPiAtCQkJ Z2VuOV9ndWNfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIGd0X2lpclsyXSk7Cj4gKwkJZ2VuNl9ycHNf aXJxX2hhbmRsZXIoaTkxNSwgZ3RfaWlyWzJdKTsKPiArCQlnZW45X2d1Y19pcnFfaGFuZGxlcihp OTE1LCBndF9paXJbMl0pOwo+ICAJfQo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vu Y29yZS5oCj4gaW5kZXggYmVkMDE5ZWYwMDBmLi41M2VmNzdkMGM5N2MgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91bmNvcmUuaAo+IEBAIC0xOTgsNCArMTk4LDkgQEAgaW50IGludGVsX3dh aXRfZm9yX3JlZ2lzdGVyX2Z3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CQkJCQkgICAgMiwgdGltZW91dF9tcywgTlVMTCk7Cj4gIH0KPiAgCj4gKyNkZWZpbmUgcmF3X3Jl Z19yZWFkKGJhc2UsIHJlZykgXAo+ICsJcmVhZGwoYmFzZSArIGk5MTVfbW1pb19yZWdfb2Zmc2V0 KHJlZykpCj4gKyNkZWZpbmUgcmF3X3JlZ193cml0ZShiYXNlLCByZWcsIHZhbHVlKSBcCj4gKwl3 cml0ZWwodmFsdWUsIGJhc2UgKyBpOTE1X21taW9fcmVnX29mZnNldChyZWcpKQo+ICsKPiAgI2Vu ZGlmIC8qICFfX0lOVEVMX1VOQ09SRV9IX18gKi8KPiAtLSAKPiAyLjE2LjEKPgo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK