From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Date: Wed, 13 Sep 2017 12:32:26 +0300 Message-ID: <878thjj651.fsf@nikula.org> References: <20170912235730.3492-1-dhinakaran.pandiyan@intel.com> <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5037E6E7E3 for ; Wed, 13 Sep 2017 09:32:51 +0000 (UTC) In-Reply-To: <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxMiBTZXAgMjAxNywgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+IFRoZXJlIGlzIGp1c3Qgb25seSBvbmUgY2FsbGVyIG5v dywgd2hpY2ggYWxyZWFkeSBjaGVja3MgZm9yCj4gaW50ZWxfZHAtPmlzX21zdC4gU28sIHJlbW92 ZSB0aGlzIGFuZCBmaXggc29tZSBicmFjZXMgd2hpbGUgYXQgaXQuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDg1ICsrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRp b25zKCspLCA0MyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4 IGIzZDk1Y2I3NTQ2Yi4uM2YyY2ExMGNjYmNkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gQEAgLTQxOTIsNTcgKzQxOTIsNTYgQEAgc3RhdGljIGludAo+ICBpbnRlbF9kcF9jaGVja19t c3Rfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAgCWJvb2wgYnJldDsK PiArCXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0geyAwIH07Cj4gKwlpbnQgcmV0ID0gMDsKPiAr CWludCByZXRyeTsKPiArCWJvb2wgaGFuZGxlZDsKPiAgCj4gLQlpZiAoaW50ZWxfZHAtPmlzX21z dCkgewo+IC0JCXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0geyAwIH07Cj4gLQkJaW50IHJldCA9 IDA7Cj4gLQkJaW50IHJldHJ5Owo+IC0JCWJvb2wgaGFuZGxlZDsKPiAtCQlicmV0ID0gaW50ZWxf ZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRlbF9kcCwgZXNpKTsKPiArCWJyZXQgPSBpbnRlbF9kcF9n ZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBlc2kpOwo+ICBnb19hZ2FpbjoKPiAtCQlpZiAoYnJl dCA9PSB0cnVlKSB7Cj4gLQo+IC0JCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAtIGVzaVsxMF0gPSAw eDIwMGMgKi8KCkRyaXZlLWJ5IG9ic2VydmF0aW9uIHVucmVsYXRlZCB0byB0aGlzIHBhdGNoOiAw eDIwMGMgaXNuJ3QgZXZlbiBkZWZpbmVkCmluIGRybV9kcF9oZWxwZXIuaC4uLiBjYXJlIHRvIGFk ZCB0aGF0LCBwbGVhc2U/CgpCUiwKSmFuaS4KCj4gLQkJCWlmIChpbnRlbF9kcC0+YWN0aXZlX21z dF9saW5rcyAmJgo+IC0JCQkgICAgIWRybV9kcF9jaGFubmVsX2VxX29rKCZlc2lbMTBdLCBpbnRl bF9kcC0+bGFuZV9jb3VudCkpIHsKPiAtCQkJCURSTV9ERUJVR19LTVMoImNoYW5uZWwgRVEgbm90 IG9rLCByZXRyYWluaW5nXG4iKTsKPiAtCQkJCWludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oaW50 ZWxfZHApOwo+IC0JCQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiAtCQkJ fQo+ICsJaWYgKGJyZXQgPT0gdHJ1ZSkgewo+ICsKPiArCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAt IGVzaVsxMF0gPSAweDIwMGMgKi8KPiArCQlpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3Mg JiYKPiArCQkgICAgIWRybV9kcF9jaGFubmVsX2VxX29rKCZlc2lbMTBdLCBpbnRlbF9kcC0+bGFu ZV9jb3VudCkpIHsKPiArCQkJRFJNX0RFQlVHX0tNUygiY2hhbm5lbCBFUSBub3Qgb2ssIHJldHJh aW5pbmdcbiIpOwo+ICsJCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVsX2RwKTsKPiAr CQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiArCQl9Cj4gIAo+IC0JCQlE Uk1fREVCVUdfS01TKCJnb3QgZXNpICUzcGhcbiIsIGVzaSk7Cj4gLQkJCXJldCA9IGRybV9kcF9t c3RfaHBkX2lycSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGVzaSwgJmhhbmRsZWQpOwo+IC0KPiAtCQkJ aWYgKGhhbmRsZWQpIHsKPiAtCQkJCWZvciAocmV0cnkgPSAwOyByZXRyeSA8IDM7IHJldHJ5Kysp IHsKPiAtCQkJCQlpbnQgd3JldDsKPiAtCQkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUoJmlu dGVsX2RwLT5hdXgsCj4gLQkJCQkJCQkJIERQX1NJTktfQ09VTlRfRVNJKzEsCj4gLQkJCQkJCQkJ ICZlc2lbMV0sIDMpOwo+IC0JCQkJCWlmICh3cmV0ID09IDMpIHsKPiAtCQkJCQkJYnJlYWs7Cj4g LQkJCQkJfQo+IC0JCQkJfQo+ICsJCURSTV9ERUJVR19LTVMoImdvdCBlc2kgJTNwaFxuIiwgZXNp KTsKPiArCQlyZXQgPSBkcm1fZHBfbXN0X2hwZF9pcnEoJmludGVsX2RwLT5tc3RfbWdyLCBlc2ks ICZoYW5kbGVkKTsKPiAgCj4gLQkJCQlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShp bnRlbF9kcCwgZXNpKTsKPiAtCQkJCWlmIChicmV0ID09IHRydWUpIHsKPiAtCQkJCQlEUk1fREVC VUdfS01TKCJnb3QgZXNpMiAlM3BoXG4iLCBlc2kpOwo+IC0JCQkJCWdvdG8gZ29fYWdhaW47Cj4g LQkJCQl9Cj4gLQkJCX0gZWxzZQo+IC0JCQkJcmV0ID0gMDsKPiArCQlpZiAoaGFuZGxlZCkgewo+ ICsJCQlmb3IgKHJldHJ5ID0gMDsgcmV0cnkgPCAzOyByZXRyeSsrKSB7Cj4gKwkJCQlpbnQgd3Jl dDsKPiAgCj4gLQkJCXJldHVybiByZXQ7Cj4gKwkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUo JmludGVsX2RwLT5hdXgsCj4gKwkJCQkJCQkgRFBfU0lOS19DT1VOVF9FU0krMSwKPiArCQkJCQkJ CSAmZXNpWzFdLCAzKTsKPiArCQkJCWlmICh3cmV0ID09IDMpCj4gKwkJCQkJYnJlYWs7Cj4gKwkJ CX0KPiArCj4gKwkJCWJyZXQgPSBpbnRlbF9kcF9nZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBl c2kpOwo+ICsJCQlpZiAoYnJldCA9PSB0cnVlKSB7Cj4gKwkJCQlEUk1fREVCVUdfS01TKCJnb3Qg ZXNpMiAlM3BoXG4iLCBlc2kpOwo+ICsJCQkJZ290byBnb19hZ2FpbjsKPiArCQkJfQo+ICAJCX0g ZWxzZSB7Cj4gLQkJCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0g ZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+IC0JCQlEUk1fREVCVUdfS01TKCJmYWlsZWQgdG8g Z2V0IEVTSSAtIGRldmljZSBtYXkgaGF2ZSBmYWlsZWRcbiIpOwo+IC0JCQlpbnRlbF9kcC0+aXNf bXN0ID0gZmFsc2U7Cj4gLQkJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVs X2RwLT5tc3RfbWdyLCBpbnRlbF9kcC0+aXNfbXN0KTsKPiAtCQkJLyogc2VuZCBhIGhvdHBsdWcg ZXZlbnQgKi8KPiAtCQkJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChpbnRlbF9kaWdfcG9y dC0+YmFzZS5iYXNlLmRldik7Cj4gKwkJCXJldCA9IDA7Cj4gIAkJfQo+ICsJfSBlbHNlIHsKPiAr CQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19w b3J0KGludGVsX2RwKTsKPiArCj4gKwkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGdldCBFU0kg LSBkZXZpY2UgbWF5IGhhdmUgZmFpbGVkXG4iKTsKPiArCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFs c2U7Cj4gKwkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9t Z3IsCj4gKwkJCQkJCWludGVsX2RwLT5pc19tc3QpOwo+ICsJCWRybV9rbXNfaGVscGVyX2hvdHBs dWdfZXZlbnQoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ICsJCXJldCA9IC1FSU5W QUw7Cj4gIAl9Cj4gLQlyZXR1cm4gLUVJTlZBTDsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=