From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Date: Fri, 14 Jul 2017 12:46:08 +0300 Message-ID: <878tjrl5b3.fsf@nikula.org> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-3-git-send-email-jim.bride@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id D81926E7C0 for ; Fri, 14 Jul 2017 09:41:08 +0000 (UTC) In-Reply-To: <1499811596-14634-3-git-send-email-jim.bride@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jim Bride , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxMSBKdWwgMjAxNywgSmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50ZWwuY29t PiB3cm90ZToKPiBBY2NvcmRpbmcgdG8gdGhlIGVEUCBzcGVjLCB3aGVuIHRoZSBjb3VudCBmaWVs ZCBpbiBURVNUX1NJTktfTUlTQwo+IGluY3JlbWVudHMgdGhlbiB0aGUgc2l4IGJ5dGVzIG9mIHNp bmsgQ1JDIGluZm9ybWF0aW9uIGluIHRoZSBEUENECj4gc2hvdWxkIGJlIHZhbGlkLiAgVW5mb3J0 dW5hdGVseSwgdGhpcyBkb2Vzbid0IHNlZW0gdG8gYmUgdGhlIGNhc2UKPiBvbiBzb21lIHBhbmVs cywgYW5kIGFzIGEgcmVzdWx0IHdlIGdldCBzb21lIGluY29ycmVjdCBhbmQgaW5jb25zaXN0ZW50 Cj4gdmFsdWVzIGZyb20gdGhlIHNpbmsgQ1JDIERQQ0QgbG9jYXRpb25zIGF0IHRpbWVzLiAgVGhp cyBwcm9ibGVtIGV4aGliaXRzCj4gaXRzZWxmIG1vcmUgb24gZmFzdGVyIHByb2Nlc3NvcnMgKHJl bGF0aXZlIGZhaWx1cmUgcmF0ZXMgSFNXIDwgU0tMIDwgS0JMLikKPiBJbiBvcmRlciB0byB0cnkg YW5kIGFjY291bnQgZm9yIHRoaXMsIHdlIHRyeSBhIGxvdCBoYXJkZXIgdG8gcmVhZCB0aGUgc2lu awo+IENSQyB1bnRpbCB3ZSBnZXQgY29uc2lzdGVudCB2YWx1ZXMgdHdpY2UgaW4gYSByb3cgYmVm b3JlIHJldHVybmluZyB3aGF0IHdlCj4gcmVhZCBhbmQgZGVsYXkgZm9yIGEgdGltZSBiZWZvcmUg dHJ5aW5nIHRvIHJlYWQuICBXZSBzdGlsbCBzZWUgc29tZQo+IG9jY2FzaW9uYWwgZmFpbHVyZXMs IGJ1dCByZWFkaW5nIHRoZSBzaW5rIENSQyBpcyBtdWNoIG1vcmUgcmVsaWFibGUsCj4gcGFydGlj dWxhcmx5IG9uIFNLTCBhbmQgS0JMLCB3aXRoIHRoZXNlIGNoYW5nZXMgdGhhbiB3aXRob3V0Lgo+ Cj4gdjI6ICogUmVkdWNlIG51bWJlciBvZiByZXRyaWVzIHdoZW4gcmVhZGluZyB0aGUgc2luayBD UkMgKEphbmkpCj4gICAgICogUmVmYWN0b3IgdG8gbWluaW1pemUgY2hhbmdlcyB0byB0aGUgY29k ZSAoSmFuaSkKPiAgICAgKiBSZWJhc2UKPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29t Pgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5 OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog SmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDJkNDJkMDkuLjY5YzgxMzBj IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTM5MDYsNiArMzkwNiwxNCBAQCBp bnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykK PiAgCXU4IGJ1ZjsKPiAgCWludCBjb3VudCwgcmV0Owo+ICAJaW50IGF0dGVtcHRzID0gNjsKPiAr CXU4IG9sZF9jcmNbNl07Cj4gKwo+ICsJaWYgKGNyYyAhPSBOVUxMKSB7CgpBcyBESyBzYWlkLCBw bGVhc2UgZHJvcCB0aGUgY2hlY2suCgo+ICsJCW1lbXNldChjcmMsIDAsIDYpOwo+ICsJCW1lbXNl dChvbGRfY3JjLCAweGZmLCA2KTsKCkJvdGggdW5uZWNlc3NhcnksIHNlZSBiZWxvdy4KCj4gKwl9 IGVsc2Ugewo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsJfQo+ICAKPiAgCXJldCA9IGludGVsX2Rw X3NpbmtfY3JjX3N0YXJ0KGludGVsX2RwKTsKPiAgCWlmIChyZXQpCj4gQEAgLTM5MjksMTEgKzM5 MzcsMzUgQEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs IHU4ICpjcmMpCj4gIAkJZ290byBzdG9wOwo+ICAJfQo+ICAKPiAtCWlmIChkcm1fZHBfZHBjZF9y ZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwgMCkgewo+IC0J CXJldCA9IC1FSU87Cj4gLQkJZ290byBzdG9wOwo+IC0JfQo+ICsJYXR0ZW1wdHMgPSA2Owo+ICsK PiArCS8qCj4gKwkgKiBTb21ldGltZXMgaXQgdGFrZXMgYSB3aGlsZSBmb3IgdGhlICJyZWFsIiBD UkMgdmFsdWVzIHRvIGxhbmQgaW4KPiArCSAqIHRoZSBEUENELCBzbyB0cnkgc2V2ZXJhbCB0aW1l cyB1bnRpbCB3ZSBnZXQgdHdvIHJlYWRzIGluIGEgcm93Cj4gKwkgKiB0aGF0IGFyZSB0aGUgc2Ft ZS4gIElmIHdlJ3JlIGFuIGVEUCBwYW5lbCwgZGVsYXkgYmV0d2VlbiByZWFkcwo+ICsJICogZm9y IGEgd2hpbGUgc2luY2UgdGhlIHZhbHVlcyB0YWtlIGEgYml0IGxvbmdlciB0byBwcm9wYWdhdGUu Cj4gKwkgKi8KPiArCWRvIHsKCk5ldmVyIHVzZSBhIGRvLXdoaWxlIHdoZW4gYSBmb3IgbG9vcCB3 aWxsIGRvLiBmb3IgKGkgPSAwOyBpIDwgNjsgaSsrKQpnZXRzIGludGVycHJldGVkIGluIHRoZSBz cGluZSwgbm8gbmVlZCBmb3IgZnVydGhlciBwcm9jZXNzaW5nLgoKPiArCQlpbnRlbF93YWl0X2Zv cl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+ICsJCWlmIChpc19lZHAoaW50 ZWxfZHApKQo+ICsJCQl1c2xlZXBfcmFuZ2UoMjAwMDAsIDI1MDAwKTsKCklzIHRoZSBpbnRlbnRp b24gdG8gZG8gdGhlc2UgKmJldHdlZW4qIHJlYWRzPyBJZiB5ZXMsIHRoZW4gbW92ZSB0aGlzCiph ZnRlciogdGhlIG1lbWNtcCB0byBvbmx5IGRvIHRoaXMgYmV0d2VlbiByZWFkcy4KCj4gKwo+ICsJ CWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLAo+ ICsJCQkJICAgICBjcmMsIDYpIDwgMCkgewo+ICsJCQlyZXQgPSAtRUlPOwo+ICsJCQlnb3RvIHN0 b3A7CgpicmVhazsKCj4gKwkJfQo+ICsKPiArCQlpZiAobWVtY21wKG9sZF9jcmMsIGNyYywgNikg PT0gMCkgewo+ICsJCQlyZXQgPSAwOwo+ICsJCQlnb3RvIHN0b3A7Cj4gKwkJfSBlbHNlIHsKPiAr CQkJbWVtY3B5KG9sZF9jcmMsIGNyYywgNik7Cj4gKwkJfQoKQWZ0ZXIgeW91J3ZlIHN3aXRjaGVk IHRoaXMgdG8gdGhlIGZvciBsb29wLCB5b3UgY2FuIGRvOgoKCWlmIChpICYmIG1lbWNtcChvbGRf Y3JjLCBjcmMsIHNpemVvZihvbGRfY3JjKSkgPT0gMCkKICAgICAgICAJYnJlYWs7CgltZW1jcHko b2xkX2NyYywgY3JjLCBzaXplb2Yob2xkX2NyYykpOwoKPiArCX0gd2hpbGUgKC0tYXR0ZW1wdHMp Owo+ICAKCglpZiAoaSA9PSA2KSB7Cgo+ICsJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGdldCBD UkMgYWZ0ZXIgNiBhdHRlbXB0cy5cbiIpOwo+ICsJcmV0ID0gLUVUSU1FRE9VVDsKCgl9Cgo+ICBz dG9wOgo+ICAJaW50ZWxfZHBfc2lua19jcmNfc3RvcChpbnRlbF9kcCk7Cj4gIAlyZXR1cm4gcmV0 OwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK