From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 15:03:28 +0300 Message-ID: <878tmmrran.fsf@intel.com> References: <1493227086-3807-3-git-send-email-imre.deak@intel.com> <1493282214-11808-1-git-send-email-imre.deak@intel.com> <20170427114955.GL30290@intel.com> <20170427115600.GC4327@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A3356E4D6 for ; Thu, 27 Apr 2017 12:00:59 +0000 (UTC) In-Reply-To: <20170427115600.GC4327@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com, Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyNyBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBPbiBUaHUsIEFwciAyNywgMjAxNyBhdCAwMjo0OTo1NVBNICswMzAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4+IE9uIFRodSwgQXByIDI3LCAyMDE3IGF0IDExOjM2OjU0QU0gKzAzMDAs IEltcmUgRGVhayB3cm90ZToKPj4gPiBBbiBlcnJvciBmcm9tIGludGVsX2dldF9waXBlX2Zyb21f Y29ubmVjdG9yKCkgd291bGQgbWVhbiBhIGJ1ZyBzb21ld2hlcmUKPj4gPiBlbHNlLCBidXQgd2Ug c3RpbGwgc2hvdWxkIGNoZWNrIGZvciBpdCB0byBwcmV2ZW50IHNvbWUgb3RoZXIgbW9yZQo+PiA+ IG9ic2N1cmUgYnVnIGxhdGVyLgo+PiA+IAo+PiA+IHYyOgo+PiA+IC0gRmFsbCBiYWNrIHRvIGEg cmVhc29uYWJsZSBkZWZhdWx0IGluc3RlYWQgb2YgYmFpbGluZyBvdXQgaW4gY2FzZSBvZgo+PiA+ ICAgZXJyb3IuIChKYW5pKQo+PiA+IHYzOgo+PiA+IC0gRml4IHMvUElQRV9JTlZBTElEL0lOVkFM SURfUElQRS8gdHlwby4gKEphbmkpCj4+ID4gCj4+ID4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5p a3VsYUBpbnRlbC5jb20+Cj4+ID4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtA aW50ZWwuY29tPgo+PiA+IC0tLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5l bC5jIHwgMTcgKysrKysrKysrKysrKystLS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+ID4gCj4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w YW5lbC5jCj4+ID4gaW5kZXggY2I1MGM1Mi4uZDFhYmJmMSAxMDA2NDQKPj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcGFuZWwuYwo+PiA+IEBAIC04ODgsMTAgKzg4OCwxNCBAQCBzdGF0aWMgdm9p ZCBwY2hfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3Ip Cj4+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5l Y3Rvci0+YmFzZS5kZXYpOwo+PiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25u ZWN0b3ItPnBhbmVsOwo+PiA+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9t X2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+PiA+IC0JZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2Nv ZGVyID0KPj4gPiAtCQlpbnRlbF9waXBlX3RvX2NwdV90cmFuc2NvZGVyKGRldl9wcml2LCBwaXBl KTsKPj4gPiArCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlcjsKPj4gPiAgCXUzMiBjcHVf Y3RsMiwgcGNoX2N0bDEsIHBjaF9jdGwyOwo+PiA+ICAKPj4gPiArCWlmICghV0FSTl9PTl9PTkNF KHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPj4gPiArCQljcHVfdHJhbnNjb2RlciA9IGludGVsX3Bp cGVfdG9fY3B1X3RyYW5zY29kZXIoZGV2X3ByaXYsIHBpcGUpOwo+PiA+ICsJZWxzZQo+PiA+ICsJ CWNwdV90cmFuc2NvZGVyID0gVFJBTlNDT0RFUl9FRFA7Cj4+ID4gKwo+PiA+ICAJY3B1X2N0bDIg PSBJOTE1X1JFQUQoQkxDX1BXTV9DUFVfQ1RMMik7Cj4+ID4gIAlpZiAoY3B1X2N0bDIgJiBCTE1f UFdNX0VOQUJMRSkgewo+PiA+ICAJCURSTV9ERUJVR19LTVMoImNwdSBiYWNrbGlnaHQgYWxyZWFk eSBlbmFibGVkXG4iKTsKPj4gPiBAQCAtOTczLDYgKzk3Nyw5IEBAIHN0YXRpYyB2b2lkIGk5NjVf ZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4+ID4g IAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rv cik7Cj4+ID4gIAl1MzIgY3RsLCBjdGwyLCBmcmVxOwo+PiA+ICAKPj4gPiArCWlmIChXQVJOX09O X09OQ0UocGlwZSA9PSBJTlZBTElEX1BJUEUpKQo+PiA+ICsJCXBpcGUgPSBQSVBFX0E7Cj4+ID4g Kwo+PiA+ICAJY3RsMiA9IEk5MTVfUkVBRChCTENfUFdNX0NUTDIpOwo+PiA+ICAJaWYgKGN0bDIg JiBCTE1fUFdNX0VOQUJMRSkgewo+PiA+ICAJCURSTV9ERUJVR19LTVMoImJhY2tsaWdodCBhbHJl YWR5IGVuYWJsZWRcbiIpOwo+PiA+IEBAIC0xMDM3LDYgKzEwNDQsOSBAQCBzdGF0aWMgdm9pZCBi eHRfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4+ ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5l Y3Rvcik7Cj4+ID4gIAl1MzIgcHdtX2N0bCwgdmFsOwo+PiA+ICAKPj4gPiArCWlmIChXQVJOX09O X09OQ0UocGlwZSkgPT0gSU5WQUxJRF9QSVBFKQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF4KPj4gCj4+IElzbid0IHRoYXQgdGhpbmcgaW4gdGhlIHdyb25nIHBsYWNlPwo+Cj4gWWVz LCB0aGFua3MgZm9yIGNhdGNoaW5nIGl0LgoKKmZhY2VwYWxtKiBJIGd1ZXNzIG15IHJldmlldyBp cyBub3QgdG8gYmUgdHJ1c3RlZC4gOi8KCkJSLApKYW5pLgoKCj4KPj4gCj4+ID4gKwkJcGlwZSA9 IFBJUEVfQTsKPj4gPiArCj4+ID4gIAkvKiBDb250cm9sbGVyIDEgdXNlcyB0aGUgdXRpbGl0eSBw aW4uICovCj4+ID4gIAlpZiAocGFuZWwtPmJhY2tsaWdodC5jb250cm9sbGVyID09IDEpIHsKPj4g PiAgCQl2YWwgPSBJOTE1X1JFQUQoVVRJTF9QSU5fQ1RMKTsKPj4gPiBAQCAtMTA5Myw3ICsxMTAz LDggQEAgdm9pZCBpbnRlbF9wYW5lbF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IgKmNvbm5lY3RvcikKPj4gPiAgCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ PiA+ICAJCXJldHVybjsKPj4gPiAgCj4+ID4gLQlEUk1fREVCVUdfS01TKCJwaXBlICVjXG4iLCBw aXBlX25hbWUocGlwZSkpOwo+PiA+ICsJaWYgKCFXQVJOX09OX09OQ0UocGlwZSA9PSBJTlZBTElE X1BJUEUpKQo+PiA+ICsJCURSTV9ERUJVR19LTVMoInBpcGUgJWNcbiIsIHBpcGVfbmFtZShwaXBl KSk7Cj4+ID4gIAo+PiA+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmJhY2tsaWdodF9sb2NrKTsK Pj4gPiAgCj4+ID4gLS0gCj4+ID4gMi41LjAKPj4gPiAKPj4gPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK Pj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPj4gCj4+IC0tIAo+PiBW aWxsZSBTeXJqw6Rsw6QKPj4gSW50ZWwgT1RDCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=