Re: [git pull] drm tree for 4.2

Re: [git pull] drm tree for 4.2

[Linus Torvalds]

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie <airlied@linux.ie> wrote:
>
> This is the main drm pull request for v4.2.

It seems to work ok for me, but it causes quite a few new warnings on
my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka
Haswell, aka 4th gen Intel Core i5)

Most of them are in check_crtc_state(), and I currently have 18 of
these in my log:

  [drm:check_crtc_state [i915]] *ERROR* mismatch in
dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  WARNING: CPU: 0 PID: 115 at
drivers/gpu/drm/i915/intel_display.c:12319
check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!

but there's a few others too:

  WARNING: CPU: 3 PID: 1871 at
drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160
[i915]()
  plane A assertion failure (expected on, current off)

  WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162
drm_wait_one_vblank+0x148/0x1a0 [drm]()
  vblank not available on crtc 0, ret=-22

and the backtraces aren't all that interesting, but I'm attaching the
cleaned-up dmesg, duplicate callchains and all.

                 Linus

[-- Attachment #2: out --]
[-- Type: application/octet-stream, Size: 36450 bytes --]

  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Not tainted 4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790b8 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790b9 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790ba ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? drm_fb_helper_hotplug_event+0xb4/0x100 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x3e/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790bb ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? drm_fb_helper_hotplug_event+0xb4/0x100 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x3e/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790bc ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? drm_fb_helper_hotplug_event+0xb4/0x100 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x3e/0x60 [drm_kms_helper]
    ? drm_fb_helper_set_par+0x1d/0x40 [drm_kms_helper]
    ? intel_fbdev_set_par+0x11/0x60 [i915]
    ? fbcon_init+0x538/0x5c0
    ? visual_init+0xac/0x110
    ? do_bind_con_driver+0x1e1/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790bd ]---
  Console: switching to colour frame buffer device 240x67
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 115 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 115 Comm: kworker/u8:3 Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Workqueue: events_unbound async_run_entry_fn
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_modeset_lock_all_crtcs+0x8e/0xa0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_fb_helper_pan_display+0x89/0xd0 [drm_kms_helper]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? intel_fbdev_pan_display+0x11/0x60 [i915]
    ? soft_cursor+0x192/0x210
    ? fb_pan_display+0xcc/0x160
    ? bit_update_start+0x19/0x40
    ? fbcon_switch+0x396/0x5d0
    ? redraw_screen+0x16c/0x250
    ? do_bind_con_driver+0x2f0/0x3e0
    ? do_take_over_console+0x10a/0x190
    ? do_fbcon_takeover+0x52/0xb0
    ? notifier_call_chain+0x40/0x60
    ? __blocking_notifier_call_chain+0x3c/0x60
    ? register_framebuffer+0x1f6/0x310
    ? intelfb_create+0x308/0x400 [i915]
    ? drm_fb_helper_initial_config+0x259/0x420 [drm_kms_helper]
    ? async_run_entry_fn+0x3e/0x140
    ? process_one_work+0x127/0x3f0
    ? worker_thread+0x42/0x490
    ? process_one_work+0x3f0/0x3f0
    ? kthread+0xbc/0xe0
    ? kthread_worker_fn+0x160/0x160
    ? ret_from_fork+0x3f/0x70
    ? kthread_worker_fn+0x160/0x160
  ---[ end trace caee0d03244790be ]---
  i915 0000:00:02.0: fb0: inteldrmfb frame buffer device
  i915 0000:00:02.0: registered panic notifier
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 2 PID: 401 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 2 PID: 401 Comm: setfont Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_modeset_lock_all_crtcs+0x8e/0xa0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_fb_helper_pan_display+0x89/0xd0 [drm_kms_helper]
    ? intel_fbdev_pan_display+0x11/0x60 [i915]
    ? soft_cursor+0x192/0x210
    ? fb_pan_display+0xcc/0x160
    ? bit_update_start+0x19/0x40
    ? fbcon_switch+0x396/0x5d0
    ? redraw_screen+0x16c/0x250
    ? fbcon_do_set_font+0x231/0x3d0
    ? con_font_op+0x3b5/0x440
    ? vt_ioctl+0x3d9/0x1260
    ? tty_ioctl+0x373/0xb00
    ? handle_mm_fault+0x104e/0x1510
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790bf ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 1 PID: 358 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 1 PID: 358 Comm: plymouthd Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? intel_fbdev_restore_mode+0x19/0x50 [i915]
    ? i915_driver_lastclose+0x9/0x20 [i915]
    ? drm_lastclose+0x28/0x130 [drm]
    ? drm_release+0x309/0x4e0 [drm]
    ? __fput+0xc7/0x1d0
    ? task_work_run+0x7f/0xb0
    ? do_notify_resume+0x5d/0x70
    ? int_signal+0x12/0x17
  ---[ end trace caee0d03244790c0 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 1 PID: 358 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 1 PID: 358 Comm: plymouthd Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? intel_fbdev_restore_mode+0x19/0x50 [i915]
    ? i915_driver_lastclose+0x9/0x20 [i915]
    ? drm_lastclose+0x28/0x130 [drm]
    ? drm_release+0x309/0x4e0 [drm]
    ? __fput+0xc7/0x1d0
    ? task_work_run+0x7f/0xb0
    ? do_notify_resume+0x5d/0x70
    ? int_signal+0x12/0x17
  ---[ end trace caee0d03244790c1 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 1 PID: 358 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 1 PID: 358 Comm: plymouthd Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_atomic_helper_plane_set_property+0x7d/0xb0 [drm_kms_helper]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? restore_fbdev_mode+0xb2/0xd0 [drm_kms_helper]
    ? drm_fb_helper_restore_fbdev_mode_unlocked+0x1b/0x60 [drm_kms_helper]
    ? intel_fbdev_restore_mode+0x19/0x50 [i915]
    ? i915_driver_lastclose+0x9/0x20 [i915]
    ? drm_lastclose+0x28/0x130 [drm]
    ? drm_release+0x309/0x4e0 [drm]
    ? __fput+0xc7/0x1d0
    ? task_work_run+0x7f/0xb0
    ? do_notify_resume+0x5d/0x70
    ? int_signal+0x12/0x17
  ---[ end trace caee0d03244790c2 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 358 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 358 Comm: plymouthd Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? SyS_mmap_pgoff+0xde/0x200
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c3 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 358 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 358 Comm: plymouthd Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c4 ]---

  ...

  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 1349 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm lpc_ich cfg80211 mfd_core
   sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 0 PID: 1349 Comm: gnome-shell Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? tlb_finish_mmu+0x29/0x40
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c5 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 3 PID: 1349 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm lpc_ich cfg80211 mfd_core
   sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 3 PID: 1349 Comm: gnome-shell Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? current_fs_time+0x9/0x50
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c6 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 3 PID: 1349 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm lpc_ich cfg80211 mfd_core
   sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 3 PID: 1349 Comm: gnome-shell Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_modeset_lock_all_crtcs+0x8e/0xa0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? current_fs_time+0x9/0x50
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c7 ]---
  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 3 PID: 1349 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm lpc_ich cfg80211 mfd_core
   sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 3 PID: 1349 Comm: gnome-shell Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_duplicate_state+0x37/0x80 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_modeset_lock_all_crtcs+0x8e/0xa0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? current_fs_time+0x9/0x50
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c8 ]---

   ...

  [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
  ------------[ cut here ]------------
  WARNING: CPU: 2 PID: 1871 at drivers/gpu/drm/i915/intel_display.c:12319 check_crtc_state+0x8be/0xf60 [i915]()
  pipe state doesn't match!
  Modules linked in: ccm cmac ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm lpc_ich cfg80211
   mfd_core sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 2 PID: 1871 Comm: Xorg Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? check_crtc_state+0x8be/0xf60 [i915]
    ? intel_modeset_check_state+0x1fa/0xac0 [i915]
    ? intel_crtc_set_config+0x484/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? __do_page_fault+0x169/0x380
    ? SyS_ioctl+0x6f/0x80
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790c9 ]---

  ------------[ cut here ]------------
  WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160 [i915]()
  plane A assertion failure (expected on, current off)
  Modules linked in: rfcomm fuse ccm cmac ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm
   lpc_ich cfg80211 mfd_core sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 3 PID: 1871 Comm: Xorg Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? hsw_disable_ips+0x34/0x160 [i915]
    ? intel_crtc_disable_planes+0x21/0xe0 [i915]
    ? __intel_set_mode+0x980/0xb70 [i915]
    ? drm_atomic_get_crtc_state+0x27/0xc0 [drm]
    ? intel_crtc_set_config+0x2c2/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? SyS_ioctl+0x6f/0x80
    ? SyS_rt_sigprocmask+0x5d/0xa0
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790ca ]---
  ------------[ cut here ]------------
  WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162 drm_wait_one_vblank+0x148/0x1a0 [drm]()
  vblank not available on crtc 0, ret=-22
  Modules linked in: rfcomm fuse ccm cmac ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw bnep vfat fat arc4 pn544_mei mei_phy pn544 hci nfc iTCO_wdt iTCO_vendor_support x86_pkg_temp_thermal coretemp kvm_intel kvm microcode snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic iwlmvm uvcvideo videobuf2_vmalloc mac80211 videobuf2_memops snd_hda_intel videobuf2_core snd_hda_codec v4l2_common btusb videodev snd_hwdep joydev btrtl i2c_i801 media snd_hda_core btbcm btintel bluetooth snd_seq snd_seq_device iwlwifi snd_pcm
   lpc_ich cfg80211 mfd_core sony_laptop rfkill snd_timer mei_me snd mei shpchp soundcore dm_crypt crct10dif_pclmul crc32_pclmul crc32c_intel i915 i2c_algo_bit drm_kms_helper ghash_clmulni_intel drm serio_raw i2c_core video hid_multitouch
  CPU: 3 PID: 1871 Comm: Xorg Tainted: G        W       4.1.0-09188-g099bfbfc7fbb #9
  Hardware name: Sony Corporation SVP11213CXB/VAIO, BIOS R0270V7 05/17/2013
  Call Trace:
    ? drm_vblank_get+0x6f/0xc0 [drm]
    ? drm_wait_one_vblank+0x148/0x1a0 [drm]
    ? hsw_disable_ips+0x6a/0x160 [i915]
    ? intel_crtc_disable_planes+0x21/0xe0 [i915]
    ? __intel_set_mode+0x980/0xb70 [i915]
    ? drm_atomic_get_crtc_state+0x27/0xc0 [drm]
    ? intel_crtc_set_config+0x2c2/0x610 [i915]
    ? drm_crtc_check_viewport+0x27/0xe0 [drm]
    ? drm_mode_set_config_internal+0x59/0xf0 [drm]
    ? drm_mode_setcrtc+0x396/0x4b0 [drm]
    ? drm_ioctl+0x102/0x530 [drm]
    ? drm_mode_setplane+0x1b0/0x1b0 [drm]
    ? do_vfs_ioctl+0x28a/0x470
    ? file_has_perm+0x7a/0x90
    ? SyS_ioctl+0x6f/0x80
    ? SyS_rt_sigprocmask+0x5d/0xa0
    ? entry_SYSCALL_64_fastpath+0x12/0x6a
  ---[ end trace caee0d03244790cb ]---

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [git pull] drm tree for 4.2

[Ander Conselvan De Oliveira]

On Fri, 2015-06-26 at 14:43 -0700, Linus Torvalds wrote:
> On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie <airlied@linux.ie> wrote:
> >
> > This is the main drm pull request for v4.2.
> 
> It seems to work ok for me, but it causes quite a few new warnings on
> my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka
> Haswell, aka 4th gen Intel Core i5)
> 
> Most of them are in check_crtc_state(), and I currently have 18 of
> these in my log:
> 
>   [drm:check_crtc_state [i915]] *ERROR* mismatch in
> dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
>   WARNING: CPU: 0 PID: 115 at
> drivers/gpu/drm/i915/intel_display.c:12319
> check_crtc_state+0x8be/0xf60 [i915]()
>   pipe state doesn't match!
> 
> but there's a few others too:
> 
>   WARNING: CPU: 3 PID: 1871 at
> drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160
> [i915]()
>   plane A assertion failure (expected on, current off)
> 
>   WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162
> drm_wait_one_vblank+0x148/0x1a0 [drm]()
>   vblank not available on crtc 0, ret=-22
> 
> and the backtraces aren't all that interesting, but I'm attaching the
> cleaned-up dmesg, duplicate callchains and all.

Please provide a full dmesg with drm.debug=0x1f in the kernel command
line.

Thanks,
Ander

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [git pull] drm tree for 4.2

[Jani Nikula]

On Mon, 29 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> On Fri, 2015-06-26 at 14:43 -0700, Linus Torvalds wrote:
>> On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie <airlied@linux.ie> wrote:
>> >
>> > This is the main drm pull request for v4.2.
>> 
>> It seems to work ok for me, but it causes quite a few new warnings on
>> my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka
>> Haswell, aka 4th gen Intel Core i5)
>> 
>> Most of them are in check_crtc_state(), and I currently have 18 of
>> these in my log:
>> 
>>   [drm:check_crtc_state [i915]] *ERROR* mismatch in
>> dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
>>   WARNING: CPU: 0 PID: 115 at
>> drivers/gpu/drm/i915/intel_display.c:12319
>> check_crtc_state+0x8be/0xf60 [i915]()
>>   pipe state doesn't match!
>> 
>> but there's a few others too:
>> 
>>   WARNING: CPU: 3 PID: 1871 at
>> drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160
>> [i915]()
>>   plane A assertion failure (expected on, current off)
>> 
>>   WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162
>> drm_wait_one_vblank+0x148/0x1a0 [drm]()
>>   vblank not available on crtc 0, ret=-22
>> 
>> and the backtraces aren't all that interesting, but I'm attaching the
>> cleaned-up dmesg, duplicate callchains and all.
>
> Please provide a full dmesg with drm.debug=0x1f in the kernel command
> line.

Ander, I think I was able to reproduce this on the BDW NUC here. Bisect
points at...

commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Fri May 15 13:34:29 2015 +0300

    drm/i915: Don't overwrite (e)DP PLL selection on SKL
    
    In the following commit, the place where the contents of dpll_hw_state
    in crtc_state where zeroed was changed. Prior to that commit, it
    happened when the new state was allocated, but now that happens just
    before the call the .crtc_compute_clock() hook. The DP code for SKL,
    however, sets up the (private) PLL in the encoder compute config
    function that has already run by the time that memset() is reached,
    causing the previous value to be lost.
    
    This patch fixes the issue by moving the memset() down the call chain,
    so that it is only called if the values in dpll_hw_state are going to be
    updated.
    
    commit 4978cc93d9ac240b435ce60431aef24239b4c270
    Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
    Date:   Tue Apr 21 17:13:21 2015 +0300
    
        drm/i915: Preserve shared DPLL information in new pipe_config
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90462
    Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
    Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
    Reported-and-tested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

This doesn't revert cleanly on Linus' master, and I didn't have the time
to look deeper right now. However I confirmed that this commit fails and
its parent doesn't.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [git pull] drm tree for 4.2

[Daniel Vetter]

On Mon, Jun 29, 2015 at 05:50:09PM +0300, Jani Nikula wrote:
> On Mon, 29 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> > On Fri, 2015-06-26 at 14:43 -0700, Linus Torvalds wrote:
> >> On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie <airlied@linux.ie> wrote:
> >> >
> >> > This is the main drm pull request for v4.2.
> >> 
> >> It seems to work ok for me, but it causes quite a few new warnings on
> >> my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka
> >> Haswell, aka 4th gen Intel Core i5)
> >> 
> >> Most of them are in check_crtc_state(), and I currently have 18 of
> >> these in my log:
> >> 
> >>   [drm:check_crtc_state [i915]] *ERROR* mismatch in
> >> dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
> >>   WARNING: CPU: 0 PID: 115 at
> >> drivers/gpu/drm/i915/intel_display.c:12319
> >> check_crtc_state+0x8be/0xf60 [i915]()
> >>   pipe state doesn't match!
> >> 
> >> but there's a few others too:
> >> 
> >>   WARNING: CPU: 3 PID: 1871 at
> >> drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160
> >> [i915]()
> >>   plane A assertion failure (expected on, current off)
> >> 
> >>   WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162
> >> drm_wait_one_vblank+0x148/0x1a0 [drm]()
> >>   vblank not available on crtc 0, ret=-22
> >> 
> >> and the backtraces aren't all that interesting, but I'm attaching the
> >> cleaned-up dmesg, duplicate callchains and all.
> >
> > Please provide a full dmesg with drm.debug=0x1f in the kernel command
> > line.
> 
> Ander, I think I was able to reproduce this on the BDW NUC here. Bisect
> points at...
> 
> commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date:   Fri May 15 13:34:29 2015 +0300
> 
>     drm/i915: Don't overwrite (e)DP PLL selection on SKL
>     
>     In the following commit, the place where the contents of dpll_hw_state
>     in crtc_state where zeroed was changed. Prior to that commit, it
>     happened when the new state was allocated, but now that happens just
>     before the call the .crtc_compute_clock() hook. The DP code for SKL,
>     however, sets up the (private) PLL in the encoder compute config
>     function that has already run by the time that memset() is reached,
>     causing the previous value to be lost.
>     
>     This patch fixes the issue by moving the memset() down the call chain,
>     so that it is only called if the values in dpll_hw_state are going to be
>     updated.
>     
>     commit 4978cc93d9ac240b435ce60431aef24239b4c270
>     Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>     Date:   Tue Apr 21 17:13:21 2015 +0300
>     
>         drm/i915: Preserve shared DPLL information in new pipe_config
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90462
>     Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>     Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>     Reported-and-tested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> This doesn't revert cleanly on Linus' master, and I didn't have the time
> to look deeper right now. However I confirmed that this commit fails and
> its parent doesn't.

Note that there seems to be two bugs here: Firs one is display state
checker getting annoyed, which is probably the one Jani bisected to here
(please confirm).

The other is the two backtraces complaining that the pipe is off (both the
drm_irq.c and the one in hsw_display_ips amount to that) because we seem
to call disable_planes on a disable pipe, which is bullocks (with runtime
pm the hw is dead and will just drop the writes).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [git pull] drm tree for 4.2

[Jani Nikula]

On Mon, 29 Jun 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Jun 29, 2015 at 05:50:09PM +0300, Jani Nikula wrote:
>> On Mon, 29 Jun 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
>> > On Fri, 2015-06-26 at 14:43 -0700, Linus Torvalds wrote:
>> >> On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie <airlied@linux.ie> wrote:
>> >> >
>> >> > This is the main drm pull request for v4.2.
>> >> 
>> >> It seems to work ok for me, but it causes quite a few new warnings on
>> >> my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka
>> >> Haswell, aka 4th gen Intel Core i5)
>> >> 
>> >> Most of them are in check_crtc_state(), and I currently have 18 of
>> >> these in my log:
>> >> 
>> >>   [drm:check_crtc_state [i915]] *ERROR* mismatch in
>> >> dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)
>> >>   WARNING: CPU: 0 PID: 115 at
>> >> drivers/gpu/drm/i915/intel_display.c:12319
>> >> check_crtc_state+0x8be/0xf60 [i915]()
>> >>   pipe state doesn't match!
>> >> 
>> >> but there's a few others too:
>> >> 
>> >>   WARNING: CPU: 3 PID: 1871 at
>> >> drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160
>> >> [i915]()
>> >>   plane A assertion failure (expected on, current off)
>> >> 
>> >>   WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162
>> >> drm_wait_one_vblank+0x148/0x1a0 [drm]()
>> >>   vblank not available on crtc 0, ret=-22
>> >> 
>> >> and the backtraces aren't all that interesting, but I'm attaching the
>> >> cleaned-up dmesg, duplicate callchains and all.
>> >
>> > Please provide a full dmesg with drm.debug=0x1f in the kernel command
>> > line.
>> 
>> Ander, I think I was able to reproduce this on the BDW NUC here. Bisect
>> points at...
>> 
>> commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
>> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Date:   Fri May 15 13:34:29 2015 +0300
>> 
>>     drm/i915: Don't overwrite (e)DP PLL selection on SKL
>>     
>>     In the following commit, the place where the contents of dpll_hw_state
>>     in crtc_state where zeroed was changed. Prior to that commit, it
>>     happened when the new state was allocated, but now that happens just
>>     before the call the .crtc_compute_clock() hook. The DP code for SKL,
>>     however, sets up the (private) PLL in the encoder compute config
>>     function that has already run by the time that memset() is reached,
>>     causing the previous value to be lost.
>>     
>>     This patch fixes the issue by moving the memset() down the call chain,
>>     so that it is only called if the values in dpll_hw_state are going to be
>>     updated.
>>     
>>     commit 4978cc93d9ac240b435ce60431aef24239b4c270
>>     Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>     Date:   Tue Apr 21 17:13:21 2015 +0300
>>     
>>         drm/i915: Preserve shared DPLL information in new pipe_config
>>     
>>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90462
>>     Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>     Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>>     Reported-and-tested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> 
>> This doesn't revert cleanly on Linus' master, and I didn't have the time
>> to look deeper right now. However I confirmed that this commit fails and
>> its parent doesn't.
>
> Note that there seems to be two bugs here: Firs one is display state
> checker getting annoyed, which is probably the one Jani bisected to here
> (please confirm).

Right, the above bisect is for the "[drm:check_crtc_state [i915]]
*ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found
0x00000000)" warning.

> The other is the two backtraces complaining that the pipe is off (both the
> drm_irq.c and the one in hsw_display_ips amount to that) because we seem
> to call disable_planes on a disable pipe, which is bullocks (with runtime
> pm the hw is dead and will just drop the writes).

The "vblank not available on crtc 0, ret=-22" warning bisects to

commit 8c7b5ccb729870e606321b3703e2c2e698c49a95
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Tue Apr 21 17:13:19 2015 +0300

    drm/i915: Use atomic helpers for computing changed flags
    
    Replace the drivers own logic for computing mode_changed, active_changed
    and planes_changed flags with the check_modeset() atomic helper. Since
    that function needs to compare the crtc's new mode with the current,
    this patch also moves the set up of crtc_state->mode earlier in the call
    chain.
    
    Note that for the call to check_plane() to work properly, we need to
    check new plane state against new crtc state. But since we still use the
    plane update helper, which doesn't have a full atomic state, we need to
    hack around that in intel_plane_atomic_check().
    
    Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
    Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>


BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Ander Conselvan de Oliveira]

Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
That can happen if a crtc that was previously driving an HDMI connector
switches to a DP connector. In that case, the wrpll field was left with
its old value, leading to warnings like the one below:

[drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
------------[ cut here ]------------
WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
pipe state doesn't match!

This regression was indroduced in

commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Fri May 15 13:34:29 2015 +0300

    drm/i915: Don't overwrite (e)DP PLL selection on SKL

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---

Only compile tested, for the wrpll warning.

Thanks,
Ander

 drivers/gpu/drm/i915/intel_dp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 4ebfc3a..fbd9ac3 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1147,6 +1147,9 @@ skl_edp_set_pll_config(struct intel_crtc_state *pipe_config, int link_clock)
 static void
 hsw_dp_set_ddi_pll_sel(struct intel_crtc_state *pipe_config, int link_bw)
 {
+	memset(&pipe_config->dpll_hw_state, 0,
+	       sizeof(pipe_config->dpll_hw_state));
+
 	switch (link_bw) {
 	case DP_LINK_BW_1_62:
 		pipe_config->ddi_pll_sel = PORT_CLK_SEL_LCPLL_810;
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Jani Nikula]

On Tue, 30 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
> config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
> That can happen if a crtc that was previously driving an HDMI connector
> switches to a DP connector. In that case, the wrpll field was left with
> its old value, leading to warnings like the one below:
>
> [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
> pipe state doesn't match!
>
> This regression was indroduced in
>
> commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date:   Fri May 15 13:34:29 2015 +0300
>
>     drm/i915: Don't overwrite (e)DP PLL selection on SKL
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Jani Nikula <jani.nikula@intel.com>

> ---
>
> Only compile tested, for the wrpll warning.
>
> Thanks,
> Ander
>
>  drivers/gpu/drm/i915/intel_dp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 4ebfc3a..fbd9ac3 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1147,6 +1147,9 @@ skl_edp_set_pll_config(struct intel_crtc_state *pipe_config, int link_clock)
>  static void
>  hsw_dp_set_ddi_pll_sel(struct intel_crtc_state *pipe_config, int link_bw)
>  {
> +	memset(&pipe_config->dpll_hw_state, 0,
> +	       sizeof(pipe_config->dpll_hw_state));
> +
>  	switch (link_bw) {
>  	case DP_LINK_BW_1_62:
>  		pipe_config->ddi_pll_sel = PORT_CLK_SEL_LCPLL_810;
> -- 
> 2.1.0
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Daniel Vetter]

On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote:
> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
> > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
> > That can happen if a crtc that was previously driving an HDMI connector
> > switches to a DP connector. In that case, the wrpll field was left with
> > its old value, leading to warnings like the one below:
> >
> > [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
> > ------------[ cut here ]------------
> > WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
> > pipe state doesn't match!
> >
> > This regression was indroduced in
> >
> > commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
> > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > Date:   Fri May 15 13:34:29 2015 +0300
> >
> >     drm/i915: Don't overwrite (e)DP PLL selection on SKL
> >
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> 
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Tested-by: Jani Nikula <jani.nikula@intel.com>

Yeah makes sense as a fix for 4.2. But for 4.3 I wonder whether the
original commit that started this chain needs to be changed a bit:

commit 4978cc93d9ac240b435ce60431aef24239b4c270
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Tue Apr 21 17:13:21 2015 +0300

    drm/i915: Preserve shared DPLL information in new pipe_config

All the trouble this caused is because it not only preserves the sharing
config (in crtc_state->shared_dpll) but also the ->dpll_hw_state. And I
think with Maarten's latest code (for 4.3) we'd just do an unconditional
compute_config (need it for fast pfit updates and fastboot), which means
the bogus values in ->dpll_hw_state aren't a problem any more since we'll
overwrite them again. And then we could remove that sprinkle of memsets we
have all over, which would be good (since the current approach is
obviously a bit fragile). Anyway:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, Daniel

> 
> > ---
> >
> > Only compile tested, for the wrpll warning.
> >
> > Thanks,
> > Ander
> >
> >  drivers/gpu/drm/i915/intel_dp.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 4ebfc3a..fbd9ac3 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -1147,6 +1147,9 @@ skl_edp_set_pll_config(struct intel_crtc_state *pipe_config, int link_clock)
> >  static void
> >  hsw_dp_set_ddi_pll_sel(struct intel_crtc_state *pipe_config, int link_bw)
> >  {
> > +	memset(&pipe_config->dpll_hw_state, 0,
> > +	       sizeof(pipe_config->dpll_hw_state));
> > +
> >  	switch (link_bw) {
> >  	case DP_LINK_BW_1_62:
> >  		pipe_config->ddi_pll_sel = PORT_CLK_SEL_LCPLL_810;
> > -- 
> > 2.1.0
> >
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Jani Nikula]

On Tue, 30 Jun 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote:
>> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
>> > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
>> > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
>> > That can happen if a crtc that was previously driving an HDMI connector
>> > switches to a DP connector. In that case, the wrpll field was left with
>> > its old value, leading to warnings like the one below:
>> >
>> > [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
>> > ------------[ cut here ]------------
>> > WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
>> > pipe state doesn't match!
>> >
>> > This regression was indroduced in
>> >
>> > commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
>> > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> > Date:   Fri May 15 13:34:29 2015 +0300
>> >
>> >     drm/i915: Don't overwrite (e)DP PLL selection on SKL
>> >
>> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> 
>> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
>> Tested-by: Jani Nikula <jani.nikula@intel.com>
>
> Yeah makes sense as a fix for 4.2. But for 4.3 I wonder whether the
> original commit that started this chain needs to be changed a bit:
>
> commit 4978cc93d9ac240b435ce60431aef24239b4c270
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date:   Tue Apr 21 17:13:21 2015 +0300
>
>     drm/i915: Preserve shared DPLL information in new pipe_config
>
> All the trouble this caused is because it not only preserves the sharing
> config (in crtc_state->shared_dpll) but also the ->dpll_hw_state. And I
> think with Maarten's latest code (for 4.3) we'd just do an unconditional
> compute_config (need it for fast pfit updates and fastboot), which means
> the bogus values in ->dpll_hw_state aren't a problem any more since we'll
> overwrite them again. And then we could remove that sprinkle of memsets we
> have all over, which would be good (since the current approach is
> obviously a bit fragile). Anyway:
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed to drm-intel-next-fixes, thanks for the patch and review. One
down, another one left to fix.

BR,
Jani.


>
> Thanks, Daniel
>
>> 
>> > ---
>> >
>> > Only compile tested, for the wrpll warning.
>> >
>> > Thanks,
>> > Ander
>> >
>> >  drivers/gpu/drm/i915/intel_dp.c | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> > index 4ebfc3a..fbd9ac3 100644
>> > --- a/drivers/gpu/drm/i915/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/intel_dp.c
>> > @@ -1147,6 +1147,9 @@ skl_edp_set_pll_config(struct intel_crtc_state *pipe_config, int link_clock)
>> >  static void
>> >  hsw_dp_set_ddi_pll_sel(struct intel_crtc_state *pipe_config, int link_bw)
>> >  {
>> > +	memset(&pipe_config->dpll_hw_state, 0,
>> > +	       sizeof(pipe_config->dpll_hw_state));
>> > +
>> >  	switch (link_bw) {
>> >  	case DP_LINK_BW_1_62:
>> >  		pipe_config->ddi_pll_sel = PORT_CLK_SEL_LCPLL_810;
>> > -- 
>> > 2.1.0
>> >
>> 
>> -- 
>> Jani Nikula, Intel Open Source Technology Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Ander Conselvan De Oliveira]

On Tue, 2015-06-30 at 18:41 +0300, Jani Nikula wrote:
> On Tue, 30 Jun 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote:
> >> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> >> > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
> >> > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
> >> > That can happen if a crtc that was previously driving an HDMI connector
> >> > switches to a DP connector. In that case, the wrpll field was left with
> >> > its old value, leading to warnings like the one below:
> >> >
> >> > [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
> >> > ------------[ cut here ]------------
> >> > WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
> >> > pipe state doesn't match!
> >> >
> >> > This regression was indroduced in
> >> >
> >> > commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
> >> > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >> > Date:   Fri May 15 13:34:29 2015 +0300
> >> >
> >> >     drm/i915: Don't overwrite (e)DP PLL selection on SKL
> >> >
> >> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >> 
> >> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> >> Tested-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Yeah makes sense as a fix for 4.2. But for 4.3 I wonder whether the
> > original commit that started this chain needs to be changed a bit:
> >
> > commit 4978cc93d9ac240b435ce60431aef24239b4c270
> > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > Date:   Tue Apr 21 17:13:21 2015 +0300
> >
> >     drm/i915: Preserve shared DPLL information in new pipe_config
> >
> > All the trouble this caused is because it not only preserves the sharing
> > config (in crtc_state->shared_dpll) but also the ->dpll_hw_state. And I
> > think with Maarten's latest code (for 4.3) we'd just do an unconditional
> > compute_config (need it for fast pfit updates and fastboot), which means
> > the bogus values in ->dpll_hw_state aren't a problem any more since we'll
> > overwrite them again. And then we could remove that sprinkle of memsets we
> > have all over, which would be good (since the current approach is
> > obviously a bit fragile). Anyway:
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Pushed to drm-intel-next-fixes, thanks for the patch and review. One
> down, another one left to fix.

I made some progress on the second issue, but I'm afraid Jani might have
a found a third bug. The warning he gets happens because we try to wait
for vblanks while updating the primary plane during the modeset. At that
point, the crtc is off. The problem is in intel_check_primary_plane(),
which is called from drm_atomic_helper_check_planes(). That function
makes decisions about waiting for a vblank based on intel_crtc->active.
Since the check is called before we disable the crtcs, active might be
true, even though the plane update is done with crtcs disable.

The patch below makes the warning go away, but I still need to figure
out how to set crtc_state->planes_changed properly if we are going down
that route.

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index dcb1d25..f14727c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12480,10 +12480,6 @@ intel_modeset_compute_config(struct drm_crtc *crtc,
 
        intel_dump_pipe_config(to_intel_crtc(crtc), pipe_config,"[modeset]");
 
-       ret = drm_atomic_helper_check_planes(state->dev, state);
-       if (ret)
-               return ERR_PTR(ret);
-
        return pipe_config;
 }
 

The backtrace on Linus' machine is different, though. It comes from the
call to intel_crtc_disable_planes() in __intel_set_mode(). That would
indicate we have a crtc with crtc->state->enable == true but that is
actually inactive. I'm still not sure how we can get in that state.

Ander

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[Daniel Vetter]

On Wed, Jul 01, 2015 at 05:54:06PM +0300, Ander Conselvan De Oliveira wrote:
> On Tue, 2015-06-30 at 18:41 +0300, Jani Nikula wrote:
> > On Tue, 30 Jun 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote:
> > >> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> > >> > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe
> > >> > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values.
> > >> > That can happen if a crtc that was previously driving an HDMI connector
> > >> > switches to a DP connector. In that case, the wrpll field was left with
> > >> > its old value, leading to warnings like the one below:
> > >> >
> > >> > [drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0xb035061f, found 0x00000000)
> > >> > ------------[ cut here ]------------
> > >> > WARNING: CPU: 1 PID: 767 at drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x975/0x10b0 [i915]()
> > >> > pipe state doesn't match!
> > >> >
> > >> > This regression was indroduced in
> > >> >
> > >> > commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5
> > >> > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > >> > Date:   Fri May 15 13:34:29 2015 +0300
> > >> >
> > >> >     drm/i915: Don't overwrite (e)DP PLL selection on SKL
> > >> >
> > >> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > >> 
> > >> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > >> Tested-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > Yeah makes sense as a fix for 4.2. But for 4.3 I wonder whether the
> > > original commit that started this chain needs to be changed a bit:
> > >
> > > commit 4978cc93d9ac240b435ce60431aef24239b4c270
> > > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > > Date:   Tue Apr 21 17:13:21 2015 +0300
> > >
> > >     drm/i915: Preserve shared DPLL information in new pipe_config
> > >
> > > All the trouble this caused is because it not only preserves the sharing
> > > config (in crtc_state->shared_dpll) but also the ->dpll_hw_state. And I
> > > think with Maarten's latest code (for 4.3) we'd just do an unconditional
> > > compute_config (need it for fast pfit updates and fastboot), which means
> > > the bogus values in ->dpll_hw_state aren't a problem any more since we'll
> > > overwrite them again. And then we could remove that sprinkle of memsets we
> > > have all over, which would be good (since the current approach is
> > > obviously a bit fragile). Anyway:
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > Pushed to drm-intel-next-fixes, thanks for the patch and review. One
> > down, another one left to fix.
> 
> I made some progress on the second issue, but I'm afraid Jani might have
> a found a third bug. The warning he gets happens because we try to wait
> for vblanks while updating the primary plane during the modeset. At that
> point, the crtc is off. The problem is in intel_check_primary_plane(),
> which is called from drm_atomic_helper_check_planes(). That function
> makes decisions about waiting for a vblank based on intel_crtc->active.
> Since the check is called before we disable the crtcs, active might be
> true, even though the plane update is done with crtcs disable.
> 
> The patch below makes the warning go away, but I still need to figure
> out how to set crtc_state->planes_changed properly if we are going down
> that route.
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index dcb1d25..f14727c 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12480,10 +12480,6 @@ intel_modeset_compute_config(struct drm_crtc *crtc,
>  
>         intel_dump_pipe_config(to_intel_crtc(crtc), pipe_config,"[modeset]");
>  
> -       ret = drm_atomic_helper_check_planes(state->dev, state);
> -       if (ret)
> -               return ERR_PTR(ret);
> -
>         return pipe_config;
>  }
>  
> 
> The backtrace on Linus' machine is different, though. It comes from the
> call to intel_crtc_disable_planes() in __intel_set_mode(). That would
> indicate we have a crtc with crtc->state->enable == true but that is
> actually inactive. I'm still not sure how we can get in that state.

Using intel_crtc->active to precompute any kind of decisions won't work. I
guess we just need to delay the decision whether to make a vblank wait or
not to where we do the vblank wait, and use the (then current
intel_crtc->active) there. This will be fixed properly in 4.3.

I suspect Linus' backtrace is something similar - we try to precompute
what needs to be updated, get it wrong and the go boom. Sprinkling an

	if (!intel_crtc->active)
		return;

early return into the set_mode should help. But I haven't looked at what
4.2 looks precisely yet in this area - too much flux because of the atomic
conversion.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

[shuang.he]

Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6681
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
ILK                                  302/302              302/302
SNB                                  312/316              312/316
IVB                                  343/343              343/343
BYT                 -2              287/287              285/287
HSW                                  380/380              380/380
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
*BYT  igt@gem_partial_pwrite_pread@reads      PASS(1)      FAIL(1)
*BYT  igt@gem_tiled_partial_pwrite_pread@reads      PASS(1)      FAIL(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx