From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v4] drm/i915: avoid processing spurious/shared interrupts in low-power states Date: Tue, 24 Feb 2015 16:00:36 +0200 Message-ID: <878ufnpfy3.fsf@intel.com> References: <1424685494-8556-1-git-send-email-imre.deak@intel.com> <1424769270-15014-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DF456E35C for ; Tue, 24 Feb 2015 05:59:24 -0800 (PST) In-Reply-To: <1424769270-15014-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Klaus Ethgen List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyNCBGZWIgMjAxNSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBBdG0sIGl0J3MgcG9zc2libGUgdGhhdCB0aGUgaW50ZXJydXB0IGhhbmRsZXIgaXMgY2Fs bGVkIHdoZW4gdGhlIGRldmljZQo+IGlzIGluIEQzIG9yIHNvbWUgb3RoZXIgbG93LXBvd2VyIHN0 YXRlLiBJdCBjYW4gYmUgZHVlIHRvIGFub3RoZXIgZGV2aWNlCj4gdGhhdCBpcyBzdGlsbCBpbiBE MCBzdGF0ZSBhbmQgc2hhcmVzIHRoZSBpbnRlcnJ1cHQgbGluZSB3aXRoIGk5MTUsIG9yIG9uCj4g c29tZSBwbGF0Zm9ybXMgdGhlcmUgY291bGQgYmUgc3B1cmlvdXMgaW50ZXJydXB0cyBldmVuIHdp dGhvdXQgc2hhcmluZwo+IHRoZSBpbnRlcnJ1cHQgbGluZS4gVGhlIGxhdHRlciBjYXNlIHdhcyBy ZXBvcnRlZCBieSBLbGF1cyBFdGhnZW4gdXNpbmcgYQo+IExlbm92byB4NjFwIG1hY2hpbmUgKGdl biA0KS4gSGUgbm90aWNlZCB0aGlzIGlzc3VlIHZpYSBhIHN5c3RlbQo+IHN1c3BlbmQvcmVzdW1l IGhhbmcgYW5kIGJpc2VjdGVkIGl0IHRvIHRoZSBmb2xsb3dpbmcgY29tbWl0Ogo+Cj4gY29tbWl0 IGUxMWFhMzYyMzA4ZjVkZTQ2N2NlMzU1YTJhMjQ3MTMyMWIxNWEzNWMKPiBBdXRob3I6IEplc3Nl IEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+IERhdGU6ICAgV2VkIEp1biAxOCAw OTo1Mjo1NSAyMDE0IC0wNzAwCj4KPiAgICAgZHJtL2k5MTU6IHVzZSBydW50aW1lIGlycSBzdXNw ZW5kL3Jlc3VtZSBpbiBmcmVlemUvdGhhdwo+Cj4gVGhpcyBpcyBhIHByb2JsZW0sIHNpbmNlIGlu IGxvdy1wb3dlciBzdGF0ZXMgSUlSIHdpbGwgYWx3YXlzIHJlYWQKPiAweGZmZmZmZmZmIHJlc3Vs dGluZyBpbiBhbiBlbmRsZXNzIElSUSBzZXJ2aWNpbmcgbG9vcC4KPgo+IEZpeCB0aGlzIGJ5IGhh bmRsaW5nIGludGVycnVwdHMgb25seSB3aGVuIHRoZSBkcml2ZXIgZXhwbGljaXRseSBlbmFibGVz Cj4gdGhlbSBhbmQgc28gaXQncyBndWFyYW50ZWVkIHRoYXQgdGhlIGludGVycnVwdCByZWdpc3Rl cnMgcmV0dXJuIGEgdmFsaWQKPiB2YWx1ZS4KPgo+IE5vdGUgdGhhdCB0aGlzIGlzc3VlIGV4aXN0 ZWQgZXZlbiBiZWZvcmUgdGhlIGFib3ZlIGNvbW1pdCwgc2luY2UgZHVyaW5nCj4gcnVudGltZSBz dXNwZW5kL3Jlc3VtZSB3ZSBuZXZlciB1bnJlZ2lzdGVyZWQgdGhlIGhhbmRsZXIuCj4KPiB2MjoK PiAtIGNsYXJpZnkgdGhlIHB1cnBvc2Ugb2Ygc21wX21iKCkgdnMuIHN5bmNocm9uaXplX2lycSgp IGluIHRoZQo+ICAgY29kZSBjb21tZW50IChDaHJpcykKPgo+IHYzOgo+IC0gbm8gbmVlZCBmb3Ig YW4gZXhwbGljaXQgc21wX21iKCksIHdlIGNhbiBhc3N1bWUgdGhhdCBzeW5jaHJvbml6ZV9pcnEo KQo+ICAgYW5kIHRoZSBtbWlvIHJlYWQvd3JpdGVzIGluIHRoZSBpbnN0YWxsIGhvb2tzIHByb3Zp ZGUgZm9yIHRoaXMgKERhbmllbCkKPiAtIHJlbW92ZSBjb2RlIGNvbW1lbnQgYXMgdGhlIHJlbWFp bmluZyBzeW5jaHJvbml6ZV9pcnEoKSBpcyBzZWxmCj4gICBleHBsYW5hdG9yeSAoRGFuaWVsKQo+ Cj4gdjQ6Cj4gLSBkcm1faXJxX3VuaW5zdGFsbCgpIGltcGxpZXMgc3luY2hyb25pemVfaXJxKCks IHNvIG5vIG5lZWQgdG8gY2FsbCBpdAo+ICAgZXhwbGljaXRseSAoRGFuaWVsKQo+Cj4gUmVmZXJl bmNlOiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNS8yLzExLzIwNQo+IFJlcG9ydGVkLWFuZC1i aXNlY3RlZC1ieTogS2xhdXMgRXRoZ2VuIDxLbGF1c0BFdGhnZW4uY2g+Cj4gU2lnbmVkLW9mZi1i eTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKUHVzaGVkIHRvIGRybS1pbnRlbC1maXhl cywgY2M6IHN0YWJsZSwgdGhhbmtzIGZvciB0aGUgcGF0Y2ggYW5kIHJldmlldy4KCkJSLApKYW5p LgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCAyMiArKysrKysr KysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBpbmRleCA5MDczMTE5Li4xNTYxMjQ4IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTE4ODksNiArMTg4OSw5IEBAIHN0YXRpYyBpcnFyZXR1 cm5fdCB2YWxsZXl2aWV3X2lycV9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiAgCXUzMiBp aXIsIGd0X2lpciwgcG1faWlyOwo+ICAJaXJxcmV0dXJuX3QgcmV0ID0gSVJRX05PTkU7Cj4gIAo+ ICsJaWYgKCFpbnRlbF9pcnFzX2VuYWJsZWQoZGV2X3ByaXYpKQo+ICsJCXJldHVybiBJUlFfTk9O RTsKPiArCj4gIAl3aGlsZSAodHJ1ZSkgewo+ICAJCS8qIEZpbmQsIGNsZWFyLCB0aGVuIHByb2Nl c3MgZWFjaCBzb3VyY2Ugb2YgaW50ZXJydXB0ICovCj4gIAo+IEBAIC0xOTMzLDYgKzE5MzYsOSBA QCBzdGF0aWMgaXJxcmV0dXJuX3QgY2hlcnJ5dmlld19pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lk ICphcmcpCj4gIAl1MzIgbWFzdGVyX2N0bCwgaWlyOwo+ICAJaXJxcmV0dXJuX3QgcmV0ID0gSVJR X05PTkU7Cj4gIAo+ICsJaWYgKCFpbnRlbF9pcnFzX2VuYWJsZWQoZGV2X3ByaXYpKQo+ICsJCXJl dHVybiBJUlFfTk9ORTsKPiArCj4gIAlmb3IgKDs7KSB7Cj4gIAkJbWFzdGVyX2N0bCA9IEk5MTVf UkVBRChHRU44X01BU1RFUl9JUlEpICYgfkdFTjhfTUFTVEVSX0lSUV9DT05UUk9MOwo+ICAJCWlp ciA9IEk5MTVfUkVBRChWTFZfSUlSKTsKPiBAQCAtMjIwNSw2ICsyMjExLDkgQEAgc3RhdGljIGly cXJldHVybl90IGlyb25sYWtlX2lycV9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiAgCXUz MiBkZV9paXIsIGd0X2lpciwgZGVfaWVyLCBzZGVfaWVyID0gMDsKPiAgCWlycXJldHVybl90IHJl dCA9IElSUV9OT05FOwo+ICAKPiArCWlmICghaW50ZWxfaXJxc19lbmFibGVkKGRldl9wcml2KSkK PiArCQlyZXR1cm4gSVJRX05PTkU7Cj4gKwo+ICAJLyogV2UgZ2V0IGludGVycnVwdHMgb24gdW5j bGFpbWVkIHJlZ2lzdGVycywgc28gY2hlY2sgZm9yIHRoaXMgYmVmb3JlIHdlCj4gIAkgKiBkbyBh bnkgSTkxNV97UkVBRCxXUklURX0uICovCj4gIAlpbnRlbF91bmNvcmVfY2hlY2tfZXJyb3JzKGRl dik7Cj4gQEAgLTIyNzYsNiArMjI4NSw5IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBnZW44X2lycV9o YW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiAgCWVudW0gcGlwZSBwaXBlOwo+ICAJdTMyIGF1 eF9tYXNrID0gR0VOOF9BVVhfQ0hBTk5FTF9BOwo+ICAKPiArCWlmICghaW50ZWxfaXJxc19lbmFi bGVkKGRldl9wcml2KSkKPiArCQlyZXR1cm4gSVJRX05PTkU7Cj4gKwo+ICAJaWYgKElTX0dFTjko ZGV2KSkKPiAgCQlhdXhfbWFzayB8PSAgR0VOOV9BVVhfQ0hBTk5FTF9CIHwgR0VOOV9BVVhfQ0hB Tk5FTF9DIHwKPiAgCQkJR0VOOV9BVVhfQ0hBTk5FTF9EOwo+IEBAIC0zNzY4LDYgKzM3ODAsOSBA QCBzdGF0aWMgaXJxcmV0dXJuX3QgaTh4eF9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcp Cj4gIAkJSTkxNV9ESVNQTEFZX1BMQU5FX0FfRkxJUF9QRU5ESU5HX0lOVEVSUlVQVCB8Cj4gIAkJ STkxNV9ESVNQTEFZX1BMQU5FX0JfRkxJUF9QRU5ESU5HX0lOVEVSUlVQVDsKPiAgCj4gKwlpZiAo IWludGVsX2lycXNfZW5hYmxlZChkZXZfcHJpdikpCj4gKwkJcmV0dXJuIElSUV9OT05FOwo+ICsK PiAgCWlpciA9IEk5MTVfUkVBRDE2KElJUik7Cj4gIAlpZiAoaWlyID09IDApCj4gIAkJcmV0dXJu IElSUV9OT05FOwo+IEBAIC0zOTQ4LDYgKzM5NjMsOSBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgaTkx NV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcpCj4gIAkJSTkxNV9ESVNQTEFZX1BMQU5F X0JfRkxJUF9QRU5ESU5HX0lOVEVSUlVQVDsKPiAgCWludCBwaXBlLCByZXQgPSBJUlFfTk9ORTsK PiAgCj4gKwlpZiAoIWludGVsX2lycXNfZW5hYmxlZChkZXZfcHJpdikpCj4gKwkJcmV0dXJuIElS UV9OT05FOwo+ICsKPiAgCWlpciA9IEk5MTVfUkVBRChJSVIpOwo+ICAJZG8gewo+ICAJCWJvb2wg aXJxX3JlY2VpdmVkID0gKGlpciAmIH5mbGlwX21hc2spICE9IDA7Cj4gQEAgLTQxNjgsNiArNDE4 Niw5IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBpOTY1X2lycV9oYW5kbGVyKGludCBpcnEsIHZvaWQg KmFyZykKPiAgCQlJOTE1X0RJU1BMQVlfUExBTkVfQV9GTElQX1BFTkRJTkdfSU5URVJSVVBUIHwK PiAgCQlJOTE1X0RJU1BMQVlfUExBTkVfQl9GTElQX1BFTkRJTkdfSU5URVJSVVBUOwo+ICAKPiAr CWlmICghaW50ZWxfaXJxc19lbmFibGVkKGRldl9wcml2KSkKPiArCQlyZXR1cm4gSVJRX05PTkU7 Cj4gKwo+ICAJaWlyID0gSTkxNV9SRUFEKElJUik7Cj4gIAo+ICAJZm9yICg7Oykgewo+IEBAIC00 NTE3LDYgKzQ1MzgsNyBAQCB2b2lkIGludGVsX3J1bnRpbWVfcG1fZGlzYWJsZV9pbnRlcnJ1cHRz KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJZGV2X3ByaXYtPmRl di0+ZHJpdmVyLT5pcnFfdW5pbnN0YWxsKGRldl9wcml2LT5kZXYpOwo+ICAJZGV2X3ByaXYtPnBt LmlycXNfZW5hYmxlZCA9IGZhbHNlOwo+ICsJc3luY2hyb25pemVfaXJxKGRldl9wcml2LT5kZXYt PmlycSk7Cj4gIH0KPiAgCj4gIC8qKgo+IC0tIAo+IDIuMS4wCj4KCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK