From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/2] drm/i915: unify remaining register save/restore code a bit Date: Thu, 13 Nov 2014 09:19:49 +0200 Message-ID: <878ujfy3ca.fsf@intel.com> References: <1415802343-23091-2-git-send-email-jani.nikula@intel.com> <1415804470-3029-1-git-send-email-jani.nikula@intel.com> <20141112154814.GA25711@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D535D6E86C for ; Wed, 12 Nov 2014 23:19:50 -0800 (PST) In-Reply-To: <20141112154814.GA25711@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMiBOb3YgMjAxNCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBXZWQsIE5vdiAxMiwgMjAxNCBhdCAwNTowMToxMFBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gVXNlIHRoZSBzYW1lIGNvbmRpdGlvbnMsIGdyb3VwIGJ5IGZlYXR1cmVzLCBh ZGQgY29tbWVudHMuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3VzcGVu ZC5jIHwgMTggKysrKysrKysrLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRp b25zKCspLCA5IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfc3VzcGVuZC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zdXNwZW5k LmMKPj4gaW5kZXggM2MxZmNjZmFjYWMxLi5kZmU2NjE3NDMzOTggMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3VzcGVuZC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfc3VzcGVuZC5jCj4+IEBAIC0yMDMsMjEgKzIwMywxOSBAQCBzdGF0aWMgdm9p ZCBpOTE1X3NhdmVfZGlzcGxheShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgCQlpOTE1X3Nh dmVfZGlzcGxheV9yZWcoZGV2KTsKPj4gIAo+PiAgCS8qIExWRFMgc3RhdGUgKi8KPj4gLQlpZiAo SEFTX1BDSF9TUExJVChkZXYpKSB7Cj4+IC0JCWRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9DT05U Uk9MID0gSTkxNV9SRUFEKFBDSF9QUF9DT05UUk9MKTsKPj4gLQkJaWYgKEhBU19QQ0hfSUJYKGRl dikgfHwgSEFTX1BDSF9DUFQoZGV2KSkKPj4gLQkJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVMVkRT ID0gSTkxNV9SRUFEKFBDSF9MVkRTKTsKPj4gLQl9IGVsc2UgaWYgKCFJU19WQUxMRVlWSUVXKGRl dikpIHsKPj4gLQkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0NPTlRST0wgPSBJOTE1X1JFQUQo UFBfQ09OVFJPTCk7Cj4+IC0JCWlmIChJU19NT0JJTEUoZGV2KSAmJiAhSVNfSTgzMChkZXYpKQo+ PiAtCQkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZUxWRFMgPSBJOTE1X1JFQUQoTFZEUyk7Cj4+IC0J fQo+PiArCWlmIChIQVNfUENIX0lCWChkZXYpIHx8IEhBU19QQ0hfQ1BUKGRldikpCj4+ICsJCWRl dl9wcml2LT5yZWdmaWxlLnNhdmVMVkRTID0gSTkxNV9SRUFEKFBDSF9MVkRTKTsKPj4gKwllbHNl IGlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA8PSA0ICYmIElTX01PQklMRShkZXYpICYmICFJU19J ODMwKGRldikpCj4+ICsJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVMVkRTID0gSTkxNV9SRUFEKExW RFMpOwo+PiAgCj4+ICsJLyogUGFuZWwgcG93ZXIgc2VxdWVuY2VyICovCj4+ICAJaWYgKEhBU19Q Q0hfU1BMSVQoZGV2KSkgewo+PiArCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfQ09OVFJPTCA9 IEk5MTVfUkVBRChQQ0hfUFBfQ09OVFJPTCk7Cj4+ICAJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVQ UF9PTl9ERUxBWVMgPSBJOTE1X1JFQUQoUENIX1BQX09OX0RFTEFZUyk7Cj4+ICAJCWRldl9wcml2 LT5yZWdmaWxlLnNhdmVQUF9PRkZfREVMQVlTID0gSTkxNV9SRUFEKFBDSF9QUF9PRkZfREVMQVlT KTsKPj4gIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0RJVklTT1IgPSBJOTE1X1JFQUQoUENI X1BQX0RJVklTT1IpOwo+PiAgCX0gZWxzZSBpZiAoIUlTX1ZBTExFWVZJRVcoZGV2KSkgewo+PiAr CQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfQ09OVFJPTCA9IEk5MTVfUkVBRChQUF9DT05UUk9M KTsKPj4gIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX09OX0RFTEFZUyA9IEk5MTVfUkVBRChQ UF9PTl9ERUxBWVMpOwo+PiAgCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfT0ZGX0RFTEFZUyA9 IEk5MTVfUkVBRChQUF9PRkZfREVMQVlTKTsKPj4gIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQ X0RJVklTT1IgPSBJOTE1X1JFQUQoUFBfRElWSVNPUik7Cj4KPiBKdXN0IGJlY2F1c2UgdGhleSdy ZSBpbiB0aGUgY29udGV4dDogRG8gd2Ugc3RpbGwgbmVlZCB0byByZXN0b3JlIHRoZSBQUAo+IHN0 dWZmIHdpdGggYWxsIHRoZSByZWNlbnQgcHBzIHBhdGNoZXM/IFdvdWxkIGJlIGdyZWF0IHRvIHJl bW92ZSB0aGlzIC4uLgoKQUZBSUNUIHdlIG9ubHkgZG8gdGhlIGZ1bGwgc2V0dXAgZm9yIHZsdi9j aHYgYXQgZURQIG1vZGUgc2V0LCBhbmQgdGhhdCdzCmJlY2F1c2UgdGhlIHBpcGUgbWlnaHQgaGF2 ZSBjaGFuZ2VkLiBTb21ldGhpbmcgc2ltaWxhciBtaWdodCBjdXQgaXQgZm9yCmx2ZHMgYW5kIG5v bi12bHYvY2h2IGVEUCwgYnV0IEknbSBub3QgcHJlcGFyZWQgdG8gdG91Y2ggdGhhdCBqdXN0IHll dAphZnRlciBWaWxsZSdzIGNoYW5nZXMuIEknZCByYXRoZXIgdGhlIGR1c3Qgc2V0dGxlZCBhIGJp dCBmaXJzdC4gOykKClRoZSBsdmRzIHNldHVwIHNpbWlsYXJseSBzZWVtcyB0byBjYXJyeSBvdmVy IGJpdHMgYWxsIHRoZSB3YXkgZnJvbSBib290Cm92ZXIgc3VzcGVuZC9yZXN1bWUgY3ljbGVzLgoK QlIsCkphbmkuCgoKPgo+IEFueXdheSBsb29rcyBhbGwgZ29vZCAoYW5kIG5pY2VseSBmcmlndGhl bmluZyA7LSkgc28gcHVsbGVkIGFsbCBpbnRvIGRpbnEuCj4gLURhbmllbAo+Cj4+IEBAIC0yNDYs MTEgKzI0NCwxMyBAQCBzdGF0aWMgdm9pZCBpOTE1X3Jlc3RvcmVfZGlzcGxheShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+PiAgCWlmIChkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVS X01PREVTRVQpKQo+PiAgCQltYXNrID0gfkxWRFNfUE9SVF9FTjsKPj4gIAo+PiArCS8qIExWRFMg c3RhdGUgKi8KPj4gIAlpZiAoSEFTX1BDSF9JQlgoZGV2KSB8fCBIQVNfUENIX0NQVChkZXYpKQo+ PiAgCQlJOTE1X1dSSVRFKFBDSF9MVkRTLCBkZXZfcHJpdi0+cmVnZmlsZS5zYXZlTFZEUyAmIG1h c2spOwo+PiAgCWVsc2UgaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuIDw9IDQgJiYgSVNfTU9CSUxF KGRldikgJiYgIUlTX0k4MzAoZGV2KSkKPj4gIAkJSTkxNV9XUklURShMVkRTLCBkZXZfcHJpdi0+ cmVnZmlsZS5zYXZlTFZEUyAmIG1hc2spOwo+PiAgCj4+ICsJLyogUGFuZWwgcG93ZXIgc2VxdWVu Y2VyICovCj4+ICAJaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewo+PiAgCQlJOTE1X1dSSVRFKFBD SF9QUF9PTl9ERUxBWVMsIGRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9PTl9ERUxBWVMpOwo+PiAg CQlJOTE1X1dSSVRFKFBDSF9QUF9PRkZfREVMQVlTLCBkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBf T0ZGX0RFTEFZUyk7Cj4+IC0tIAo+PiAyLjEuMQo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPgo+IC0tIAo+IERhbmllbCBWZXR0ZXIK PiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiArNDEgKDApIDc5IDM2NSA1 NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy Y2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK