From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] rendercopy/gen8: Also emit 3DSTATE_WM_DEPTH_STENCIL. Date: Wed, 04 Jun 2014 10:27:20 +0300 Message-ID: <878updf82v.fsf@intel.com> References: <1401832350-10171-1-git-send-email-kenneth@whitecape.org> <20140603220458.GA31603@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 586036E7CD for ; Wed, 4 Jun 2014 00:27:24 -0700 (PDT) In-Reply-To: <20140603220458.GA31603@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky , Kenneth Graunke Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 04 Jun 2014, Ben Widawsky wrote: > On Tue, Jun 03, 2014 at 02:52:30PM -0700, Kenneth Graunke wrote: >> rendercopy was failing to emit 3DSTATE_WM_DEPTH_STENCIL, which is a new >> packet on Broadwell. Mesa emits this packet. >> >> This appears to fix various tests on a fresh boot, when Mesa has never >> run. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78890 >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78891 >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78935 >>From this bug, Tested-by: Guo Jinxian >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78936 >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78937 >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78938 >> Signed-off-by: Kenneth Graunke >> Cc: Ben Widawsky > > I sat with Ken all day today (after a few days of debugging myself) and > it does what it purport to do, and fixes a bunch of tests. > > Reviewed-by: Ben Widawsky > > FWIW: I don't think we need to update the null state in the kernel. It's > actually kind of nice for finding userspace bugs. > > -- > Ben Widawsky, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center