From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <ben@bwidawsk.net>,
Art Runyan <arthur.j.runyan@intel.com>,
Kenneth Graunke <kenneth.w.graunke@intel.com>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Fix PSR programming
Date: Wed, 05 Mar 2014 11:31:27 +0200 [thread overview]
Message-ID: <878usp3sb4.fsf@intel.com> (raw)
In-Reply-To: <1394001490-18235-1-git-send-email-benjamin.widawsky@intel.com>
On Wed, 05 Mar 2014, Ben Widawsky <benjamin.widawsky@intel.com> wrote:
> | has a higher precedence than ?. Therefore, the calculation doesn't do
> at all what you would expect. Thanks to Ken for convincing me that this
> was indeed the issue. Send me back to C programmer school, please.
>
> I'm sort of surprised PSR was continuing to work for people. It should
> be broken IMO (and it was broken for me, but I had assumed it never
> worked).
>
> Regression from:
> commit ed8546ac1f99b850879f07b1e9b06b42fb0a36d9
> Author: Ben Widawsky <benjamin.widawsky@intel.com>
> Date: Mon Nov 4 22:45:05 2013 -0800
>
> drm/i915/bdw: Support eDP PSR
>
> I am pretty certain PSR is disabled by default, so no CC stable.
I think I'll pick this up for -fixes, with CC stable, as it also breaks
Haswell PSR.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Cc: Kenneth Graunke <kenneth.w.graunke@intel.com>
> Cc: Art Runyan <arthur.j.runyan@intel.com>
> Reported-by: "Kumar, Kiran S" <kiran.s.kumar@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index c512d78..2c0ceb4 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1723,7 +1723,7 @@ static void intel_edp_psr_enable_source(struct intel_dp *intel_dp)
> val |= EDP_PSR_LINK_DISABLE;
>
> I915_WRITE(EDP_PSR_CTL(dev), val |
> - IS_BROADWELL(dev) ? 0 : link_entry_time |
> + (IS_BROADWELL(dev) ? 0 : link_entry_time) |
> max_sleep_time << EDP_PSR_MAX_SLEEP_TIME_SHIFT |
> idle_frames << EDP_PSR_IDLE_FRAME_SHIFT |
> EDP_PSR_ENABLE);
> --
> 1.9.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-05 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 6:38 [PATCH] drm/i915: Fix PSR programming Ben Widawsky
2014-03-05 9:31 ` Jani Nikula [this message]
2014-03-06 12:05 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878usp3sb4.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arthur.j.runyan@intel.com \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth.w.graunke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox