From: Jani Nikula <jani.nikula@intel.com>
To: Shobhit Kumar <shobhit.kumar@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [v2 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements
Date: Thu, 27 Feb 2014 16:48:11 +0200 [thread overview]
Message-ID: <878usw7gt0.fsf@intel.com> (raw)
In-Reply-To: <1392895001-26055-2-git-send-email-shobhit.kumar@intel.com>
On Thu, 20 Feb 2014, Shobhit Kumar <shobhit.kumar@intel.com> wrote:
> +/* Block 52 contains MIPI configuration block
> + * 6 * bdb_mipi_config, followed by 6 pps data
> + * block below
> + *
> + * all delays in ms
The spec you sent me has "... delay in 100us unit" for MIPI PPS entries
which is weird and which is the reason I asked you to document the
units. Please check.
With that checked,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-02-27 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:16 [v2 0/2] Support for new MIPI Blocks in VBT Shobhit Kumar
2014-02-20 11:16 ` [v2 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements Shobhit Kumar
2014-02-27 14:48 ` Jani Nikula [this message]
2014-02-28 5:25 ` Shobhit Kumar
2014-02-28 5:48 ` [PATCH] " Shobhit Kumar
2014-03-05 12:52 ` Daniel Vetter
2014-02-20 11:16 ` [v2 2/2] drm/i915: Add parsing support for new MIPI blocks in VBT Shobhit Kumar
2014-02-28 12:34 ` Jani Nikula
2014-04-14 5:30 ` [PATCH v3] " Shobhit Kumar
2014-04-14 7:02 ` Daniel Vetter
2014-04-14 7:54 ` Kumar, Shobhit
2014-04-14 9:05 ` Daniel Vetter
2014-04-14 9:55 ` Kumar, Shobhit
2014-04-15 8:24 ` [PATCH] drm/i915: Code cleanup patch to fix checkpatch errors Shobhit Kumar
2014-04-15 19:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878usw7gt0.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shobhit.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox