From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 2/5] drm/i915: fix intel_dp_aux_native_read's reply array size
Date: Fri, 13 Sep 2013 16:41:42 +0300 [thread overview]
Message-ID: <878uz0n8ix.fsf@intel.com> (raw)
In-Reply-To: <20130913125303.GB24404@strange.amr.corp.intel.com>
On Fri, 13 Sep 2013, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Fri, Sep 13, 2013 at 12:21:21PM +0300, Jani Nikula wrote:
>> On Fri, 13 Sep 2013, Paulo Zanoni <przanoni@gmail.com> wrote:
>> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> >
>> > So far we control all the reads an none of them exceeds the current
>> > limit of 20 bytes, but we never think about this when reviewing
>> > patches, so we may at some point in the future overflow the buffer.
>> >
>> > My initial patch just added a WARN in case we were about to overflow
>> > the buffer, but Chris suggested to make the size of the array dynamic.
>>
>> VLA on stack in kernel gives me an uneasy feeling, but I'll survive.
>
> IIRC sparse will complain about this. Might worth double checking.
True.
CHECK drivers/gpu/drm/i915/intel_dp.c
drivers/gpu/drm/i915/intel_dp.c:567:34: error: bad constant expression
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-09-13 13:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 16:58 [PATCH 1/5] drm/i915: don't save/restore LBB on Gen5+ Paulo Zanoni
2013-09-12 16:58 ` [PATCH 2/5] drm/i915: WARN if the DP aux read is too big Paulo Zanoni
2013-09-12 17:15 ` Chris Wilson
2013-09-12 21:03 ` [PATCH 2/5] drm/i915: fix intel_dp_aux_native_read's reply array size Paulo Zanoni
2013-09-13 9:21 ` Jani Nikula
2013-09-13 12:53 ` Damien Lespiau
2013-09-13 13:41 ` Jani Nikula [this message]
2013-09-13 13:50 ` Damien Lespiau
2013-09-16 19:26 ` Paulo Zanoni
2013-09-12 16:58 ` [PATCH 3/5] drm/i915: check for more ASLC interrupts Paulo Zanoni
2013-09-13 10:23 ` Jani Nikula
2013-09-12 16:58 ` [PATCH 4/5] drm/i915: clear opregon->lid_state after we unmap it Paulo Zanoni
2013-09-13 13:53 ` Rodrigo Vivi
2013-09-12 16:58 ` [PATCH 5/5] drm/i915: check for errors on i915_drm_thaw Paulo Zanoni
2013-09-12 17:10 ` Chris Wilson
2013-09-12 21:06 ` [PATCH 6/5] drm/i915: move more code to __i915_drm_thaw Paulo Zanoni
2013-09-12 21:44 ` Chris Wilson
2013-09-13 9:40 ` Daniel Vetter
2013-09-12 17:36 ` [PATCH 1/5] drm/i915: don't save/restore LBB on Gen5+ Ville Syrjälä
2013-09-13 9:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uz0n8ix.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox