RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 25 Sep 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> >  .../gpu/drm/i915/display/intel_histogram.c    | 111 +++++++++++++-----
>> >  .../drm/i915/display/intel_histogram_reg.h    |  25 ++++
>> >  2 files changed, 105 insertions(+), 31 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c
>> > b/drivers/gpu/drm/i915/display/intel_histogram.c
>> > index 6529a59ca6b6..02d5270b0232 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_histogram.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_histogram.c
>> > @@ -29,6 +29,51 @@ struct intel_histogram {
>> >  	u32 bindata[HISTOGRAM_BIN_COUNT];
>> >  };
>> >
>> > +static __inline__ void set_bin_index_0(struct intel_display *display,
>> > +enum pipe pipe)
>>           ^^^^^^^^^^
>> 
>> Why?
>> 
> Sorry, didn't get your question. Is it why "enum pipe pipe"

No, why __inline__? What's the point?

(I tried to underline it with ^^^^^^^^^^ [1].)

You should basically never use inline in .c files, just let the compiler
do its job. And if you do need to use inline in headers, it should be
"inline", not "__inline__". See include/linux/compiler_types.h.

BR,
Jani.


[1] https://lore.kernel.org/all/87y13g2jkq.fsf@intel.com


-- 
Jani Nikula, Intel