From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A29C61DA4 for ; Sat, 18 Mar 2023 03:29:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CF1010E036; Sat, 18 Mar 2023 03:29:01 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A1DA10E036; Sat, 18 Mar 2023 03:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679110139; x=1710646139; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Qw1LvfpDIMFUMaH7KSVVjc6qxL9hUIx0rZh4CknESg0=; b=LPRX2NwCSnFvULca8pcNerxU67sNKpeUTbmLRyJ1vSh3rqdYosoo43XA FJKj2TzlZ7uZe5FsYo1jAMp/w2gBRdwtCQvsdofhB+E2gMmeDtTDt8gMI OlDs7Yj6g8k+EC1QTBGJyjAcBm38sGfhXwGi0GSDdKlTXgzSdrLOMvgjs 4ixSrPdYY6xxc4yN9CuYsA7nHvmV5Amt5Wr9RcBU3y81zYuY7R6Ofav6c HDOXLI+UbIcxUNTWbmvJ9aZ3gk42oIMNT3mSrRVBFgOdI96FT/uUxeW9p zG6vYFdvo9Lqqczluuw0muTbY1my+W9QXPDNc+Xgm+6ljYEZxh9SPb0lI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="318803789" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="318803789" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 20:28:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="1009886108" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="1009886108" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.197.230]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 20:28:58 -0700 Date: Fri, 17 Mar 2023 20:28:58 -0700 Message-ID: <87a60awxdx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula , Rodrigo Vivi In-Reply-To: References: <20230208190312.1611335-1-ashutosh.dixit@intel.com> <877cwjq6rp.fsf@intel.com> <875yc2oq0c.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: [Intel-gfx] Reverted patch reappears! X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Jani/Rodrigo, Original Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915/hwmon: Enable PL1 power limit" On Wed, 15 Feb 2023 09:19:07 -0800, Rodrigo Vivi wrote: > > On Wed, Feb 15, 2023 at 08:24:51AM -0800, Dixit, Ashutosh wrote: > > On Wed, 15 Feb 2023 07:37:30 -0800, Jani Nikula wrote: > > > > > > On Wed, 08 Feb 2023, Rodrigo Vivi wrote: > > > > On Wed, Feb 08, 2023 at 11:03:12AM -0800, Ashutosh Dixit wrote: > > > >> This reverts commit 0349c41b05968befaffa5fbb7e73d0ee6004f610. > > > >> > > > >> 0349c41b0596 ("drm/i915/hwmon: Enable PL1 power limit") is incorrect and > > > >> caused a major regression on ATSM. The change enabled the PL1 power limit > > > >> but FW sets the default value of the PL1 limit to 0 which implies HW now > > > >> works at minimum power and therefore the lowest effective frequency. This > > > >> means all workloads now run slower resulting in even GuC FW load operations > > > >> timing out, rendering ATSM unusable. > > > >> > > > >> A different solution to the original issue of the PL1 limit being disabled > > > >> on ATSM is needed but till that is developed, revert 0349c41b0596. > > > >> > > > >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8062 > > > > > > > > pushed to drm-intel-next and removed from drm-intel-fixes. > > > > > > > > Thanks for the quick reaction. > > > > > > Please always add Fixes: tags also to reverts. > > > > > > I suppose we should fix dim to also detect reverts, but I ended up > > > cherry-picking and pushing the original commit out to > > > drm-intel-next-fixes before realizing it's been reverted. > > > > Oops, sorry! > > That's my mistake. I should had thought about this when pushing > and removing from the fixes. I just realized yet, when this patch > showed up in my -fixes cherry-pick again, but without the revert. > > I'm sorry. Not sure if it's related to this, but the reverted patch below has reappeared on drm-tip. Newest on top: ee892ea83d996 drm/i915/hwmon: Enable PL1 power limit 05d5562e401eb Revert "drm/i915/hwmon: Enable PL1 power limit" 0349c41b05968 drm/i915/hwmon: Enable PL1 power limit The new patch is: commit ee892ea83d99610fa33bea612de058e0955eec3a Author: Ashutosh Dixit AuthorDate: Fri Feb 3 07:53:09 2023 -0800 Commit: Jani Nikula CommitDate: Mon Mar 13 11:38:05 2023 +0200 drm/i915/hwmon: Enable PL1 power limit Sorry I couldn't track which branch did this new patch come from (looks like drm-tip itself?). This is breaking ATSM again: https://intel-gfx-ci.01.org/tree/drm-tip/bat-atsm-1.html so needs to be reverted again and stay reverted. I could send a revert or any of you can also do it. Thanks. -- Ashutosh