From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F100C433F5 for ; Thu, 28 Apr 2022 08:29:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED34B10ED41; Thu, 28 Apr 2022 08:29:54 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F0C710ED41; Thu, 28 Apr 2022 08:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651134594; x=1682670594; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=UAf4djUbqasgSXBIB9OZfbdv4fwN5mjAX558wgDc4tE=; b=ne1aJEbbGREWWgsBhjywqi2BnytSDJ6izBkIAsIdr2vZG15niAc8hOK6 QlVY0YR6DAPZMsbOeXp3AO9UrOO6Ast4Qtn8Z8C2KS1mn8O2OQnjE9CuL 6d+rq/hClFz3rdQ1+eyHDQlDh5C+Wu/m4gfKNKOt9x8G/CcWBmgTfXLG5 cMwb3lMvI0qLDGsgA9Z0pPHGxhavT/jgLOm/WCfzTp0kyaSHSUoNknfWu Zbq1WETG0mRDKUF39F+LMrWm6lU2rDUH5FSIQwBtM87FcxTkgce6OO5KJ 8jWgwddpRmh3qKsnafiszfb/XDW7JYci494W6Mdsj1Qw8NWPkarN+SVKx w==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="248139578" X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="248139578" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 01:29:53 -0700 X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="682245814" Received: from mswiniar-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.154.87]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 01:29:51 -0700 From: Jani Nikula To: Zhi Wang , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org In-Reply-To: <20220427212849.18109-2-zhi.a.wang@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220427212849.18109-1-zhi.a.wang@intel.com> <20220427212849.18109-2-zhi.a.wang@intel.com> Date: Thu, 28 Apr 2022 11:29:48 +0300 Message-ID: <87a6c5txtv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Gunthorpe Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 27 Apr 2022, Zhi Wang wrote: > A compiling error was reported when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n. > Fix the problem by using the pre-defined macro. > > Cc: Jason Gunthorpe > Cc: Jani Nikula > Signed-off-by: Zhi Wang We'll get this right, for now, but I do wonder if breaking these is going to be a perpetual thing. :( Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_gvt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_gvt.c b/drivers/gpu/drm/i915/intel_gvt.c > index 24bc693439e8..e98b6d69a91a 100644 > --- a/drivers/gpu/drm/i915/intel_gvt.c > +++ b/drivers/gpu/drm/i915/intel_gvt.c > @@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT); > EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT); > EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT); > EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT); > +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM) > EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT); > +#endif > EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT); > EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT); > EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT); -- Jani Nikula, Intel Open Source Graphics Center