Re: [maintainer-tools PATCH 01/30] qf: Deprecate the use of qf without any subcommand.

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 21 Aug 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> These sequences here are already covered by `qf git` subcommand.
> I double checked and confirmed that our continuously rebasing
> bot does not use this qf directly here and I'm not aware
> of anyone else using it. So let's remove it so we can start
> handling everything with subcommands (dim style).

Apart from the specific comments from me and Daniel, ack on the
series. This is pretty much how I converted dim way back.

BR,
Jani.



>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  qf     | 7 +------
>  qf.rst | 7 -------
>  2 files changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/qf b/qf
> index 1f056f90ef70..d1c331023230 100755
> --- a/qf
> +++ b/qf
> @@ -480,12 +480,7 @@ case "$1" in
>  		shift
>  		gitk "$@"
>  		;;
> -	help)
> -		qf_help
> -		;;
>  	*)
> -		cd_toplevel
> -		cd patches
> -		git "$@"
> +		qf_help
>  		;;
>  esac
> diff --git a/qf.rst b/qf.rst
> index 902b0d377f41..f0019d76c53d 100644
> --- a/qf.rst
> +++ b/qf.rst
> @@ -233,13 +233,6 @@ help
>  ----
>  This help text here
>  
> -all other subcommands - IMPORTANT
> ----------------------------------
> -Any other subcommands are executed directly in the quilt patches
> -directory as git commans. When using quilt flow in scripts it is
> -import to use the explicit forwarding to avoid clashes with
> -furture extensions.
> -
>  CONTRIBUTING
>  ============

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx