From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/6] dim: Also allow git urls
Date: Thu, 26 Jan 2017 12:39:45 +0200 [thread overview]
Message-ID: <87a8ae3y1a.fsf@intel.com> (raw)
In-Reply-To: <20170126091049.9122-3-daniel.vetter@ffwll.ch>
On Thu, 26 Jan 2017, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Maybe there's only a read-only remote available, and with the
> drm-misc/-intel split that's perfectly fine.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> dim | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/dim b/dim
> index e5afa9ee1bb8..cf61dc412652 100755
> --- a/dim
> +++ b/dim
> @@ -218,11 +218,16 @@ function url_to_remote # url
> remote=$(git remote -v | grep -m 1 "$url" | cut -f 1)
>
> if [[ -z "$remote" ]]; then
> - echoerr "No git remote for url $url found in $(pwd)"
> - echoerr "Please set it up using:"
> - echoerr " $ git remote add <name> $url"
> - echoerr "with a name of your choice."
> - return 1
> + git_url=`echo $url | sed -e 's/git\./anongit./' -e 's/ssh:/git:/'`
I've thought about fixing this in the past, and I'm sure you know the
above is far from being universally true. It may be a quick fix for fdo,
but quite the hack.
In fact, *all* drm-tip repos in nightly.conf could be written as git
urls, and we could rebuild drm-tip from them. There is no longer a need
to have any of them ssh:// urls.
BR,
Jani.
> + remote=$(git remote -v | grep -m 1 "$git_url" | cut -f 1)
> +
> + if [[ -z "$remote" ]]; then
> + echoerr "No git remote for url $url or $git_url found in $(pwd)"
> + echoerr "Please set it up using:"
> + echoerr " $ git remote add <name> $url"
> + echoerr "with a name of your choice."
> + return 1
> + fi
> fi
>
> echo $remote
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-26 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:10 [PATCH 1/6] dim: Update docs Daniel Vetter
2017-01-26 9:10 ` [PATCH 2/6] dim: don't check everything in dim setup Daniel Vetter
2017-01-26 9:10 ` [PATCH 3/6] dim: Also allow git urls Daniel Vetter
2017-01-26 10:39 ` Jani Nikula [this message]
2017-01-26 9:10 ` [PATCH 4/6] dim: Add git_is_current_branch helper Daniel Vetter
2017-01-26 10:43 ` Jani Nikula
2017-01-26 9:10 ` [PATCH 5/6] dim: Add helper for checking for a branch Daniel Vetter
2017-01-26 10:46 ` Jani Nikula
2017-01-26 9:10 ` [PATCH 6/6] dim: Don't try to create branches in update_branches Daniel Vetter
2017-01-26 10:47 ` Jani Nikula
2017-01-26 10:42 ` [PATCH] dim: Explain how to resolve conflicts when git rerere fails Daniel Vetter
2017-01-26 11:12 ` [PATCH 1/6] dim: Update docs Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8ae3y1a.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).