* [PATCH 1/2] drm: make is_lspcon_adaptor static
@ 2016-10-18 11:21 Jani Nikula
2016-10-18 11:21 ` [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jani Nikula @ 2016-10-18 11:21 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, dri-devel, Rodrigo Vivi
Fixes sparse warning:
drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol
'is_lspcon_adaptor' was not declared. Should it be static?
Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has
been merged via drm-intel tree
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
index a7aeb1ec852c..2624e266abbd 100644
--- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
+++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
@@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
DP_DUAL_MODE_REV_TYPE2);
}
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
- const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
+ const uint8_t adaptor_id)
{
return is_hdmi_adaptor(hdmi_id) &&
(adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/i915: make lspcon_get_current_mode static
2016-10-18 11:21 [PATCH 1/2] drm: make is_lspcon_adaptor static Jani Nikula
@ 2016-10-18 11:21 ` Jani Nikula
2016-10-18 11:43 ` Sharma, Shashank
2016-10-18 11:42 ` [PATCH 1/2] drm: make is_lspcon_adaptor static Sharma, Shashank
2016-10-18 12:16 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2016-10-18 11:21 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Rodrigo Vivi
Fixes sparse warning:
drivers/gpu/drm/i915/intel_lspcon.c:30:22: warning: symbol
'lspcon_get_current_mode' was not declared. Should it be static?
Fixes: dbe9e61b8e43 ("drm/i915: Add lspcon support for I915 driver")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
index d606f1a8f3b6..632149c6b3ad 100644
--- a/drivers/gpu/drm/i915/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/intel_lspcon.c
@@ -27,7 +27,7 @@
#include <drm/drm_dp_dual_mode_helper.h>
#include "intel_drv.h"
-enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
+static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
{
enum drm_lspcon_mode current_mode = DRM_LSPCON_MODE_INVALID;
struct i2c_adapter *adapter = &lspcon->aux->ddc;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm: make is_lspcon_adaptor static
2016-10-18 11:21 [PATCH 1/2] drm: make is_lspcon_adaptor static Jani Nikula
2016-10-18 11:21 ` [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Jani Nikula
@ 2016-10-18 11:42 ` Sharma, Shashank
2016-10-19 11:15 ` Jani Nikula
2016-10-18 12:16 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Sharma, Shashank @ 2016-10-18 11:42 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Vivi, Rodrigo
Reviewed-by: Shashank Sharma
Regards
Shashank
-----Original Message-----
From: Nikula, Jani
Sent: Tuesday, October 18, 2016 4:52 PM
To: intel-gfx@lists.freedesktop.org
Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Sharma, Shashank <shashank.sharma@intel.com>; dri-devel@lists.freedesktop.org
Subject: [PATCH 1/2] drm: make is_lspcon_adaptor static
Fixes sparse warning:
drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?
Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
index a7aeb1ec852c..2624e266abbd 100644
--- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
+++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
@@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
DP_DUAL_MODE_REV_TYPE2);
}
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
- const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
+ const uint8_t adaptor_id)
{
return is_hdmi_adaptor(hdmi_id) &&
(adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915: make lspcon_get_current_mode static
2016-10-18 11:21 ` [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Jani Nikula
@ 2016-10-18 11:43 ` Sharma, Shashank
0 siblings, 0 replies; 6+ messages in thread
From: Sharma, Shashank @ 2016-10-18 11:43 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx@lists.freedesktop.org; +Cc: Vivi, Rodrigo
Reviewed-by: Shashank Sharma
Regards
Shashank
-----Original Message-----
From: Nikula, Jani
Sent: Tuesday, October 18, 2016 4:52 PM
To: intel-gfx@lists.freedesktop.org
Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Sharma, Shashank <shashank.sharma@intel.com>
Subject: [PATCH 2/2] drm/i915: make lspcon_get_current_mode static
Fixes sparse warning:
drivers/gpu/drm/i915/intel_lspcon.c:30:22: warning: symbol 'lspcon_get_current_mode' was not declared. Should it be static?
Fixes: dbe9e61b8e43 ("drm/i915: Add lspcon support for I915 driver")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
index d606f1a8f3b6..632149c6b3ad 100644
--- a/drivers/gpu/drm/i915/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/intel_lspcon.c
@@ -27,7 +27,7 @@
#include <drm/drm_dp_dual_mode_helper.h> #include "intel_drv.h"
-enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
+static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon
+*lspcon)
{
enum drm_lspcon_mode current_mode = DRM_LSPCON_MODE_INVALID;
struct i2c_adapter *adapter = &lspcon->aux->ddc;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: make is_lspcon_adaptor static
2016-10-18 11:21 [PATCH 1/2] drm: make is_lspcon_adaptor static Jani Nikula
2016-10-18 11:21 ` [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Jani Nikula
2016-10-18 11:42 ` [PATCH 1/2] drm: make is_lspcon_adaptor static Sharma, Shashank
@ 2016-10-18 12:16 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2016-10-18 12:16 UTC (permalink / raw)
To: Shashank Sharma; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm: make is_lspcon_adaptor static
URL : https://patchwork.freedesktop.org/series/13944/
State : failure
== Summary ==
Series 13944v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/13944/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> INCOMPLETE (fi-ivb-3770)
Test gem_sync:
Subgroup basic-store-each:
pass -> FAIL (fi-ivb-3520m)
Test vgem_basic:
Subgroup unload:
skip -> PASS (fi-bdw-5557u)
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:246 pass:203 dwarn:1 dfail:0 fail:0 skip:42
fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
fi-byt-j1900 total:76 pass:62 dwarn:0 dfail:0 fail:1 skip:12
fi-byt-n2820 total:246 pass:209 dwarn:1 dfail:0 fail:1 skip:35
fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770r total:246 pass:223 dwarn:1 dfail:0 fail:0 skip:22
fi-ilk-650 total:246 pass:181 dwarn:0 dfail:0 fail:5 skip:60
fi-ivb-3520m total:246 pass:220 dwarn:0 dfail:0 fail:1 skip:25
fi-ivb-3770 total:76 pass:63 dwarn:0 dfail:0 fail:0 skip:12
fi-kbl-7200u total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23
fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24
fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36
fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2742/
7cdf5d9e9e8e0e0fdf3034f949f72a6d64783f6c drm-intel-nightly: 2016y-10m-18d-10h-27m-08s UTC integration manifest
84c7054 drm/i915: make lspcon_get_current_mode static
1eccec0 drm: make is_lspcon_adaptor static
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] drm: make is_lspcon_adaptor static
2016-10-18 11:42 ` [PATCH 1/2] drm: make is_lspcon_adaptor static Sharma, Shashank
@ 2016-10-19 11:15 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2016-10-19 11:15 UTC (permalink / raw)
To: Sharma, Shashank, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Vivi, Rodrigo
On Tue, 18 Oct 2016, "Sharma, Shashank" <shashank.sharma@intel.com> wrote:
> Reviewed-by: Shashank Sharma
Both pushed to drm-intel-next-queued, thanks for the review.
RB,
Jani.
>
> Regards
> Shashank
> -----Original Message-----
> From: Nikula, Jani
> Sent: Tuesday, October 18, 2016 4:52 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Sharma, Shashank <shashank.sharma@intel.com>; dri-devel@lists.freedesktop.org
> Subject: [PATCH 1/2] drm: make is_lspcon_adaptor static
>
> Fixes sparse warning:
>
> drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?
>
> Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree
> ---
> drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> index a7aeb1ec852c..2624e266abbd 100644
> --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c
> @@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
> DP_DUAL_MODE_REV_TYPE2);
> }
>
> -bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
> - const uint8_t adaptor_id)
> +static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
> + const uint8_t adaptor_id)
> {
> return is_hdmi_adaptor(hdmi_id) &&
> (adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |
> --
> 2.1.4
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-19 11:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 11:21 [PATCH 1/2] drm: make is_lspcon_adaptor static Jani Nikula
2016-10-18 11:21 ` [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Jani Nikula
2016-10-18 11:43 ` Sharma, Shashank
2016-10-18 11:42 ` [PATCH 1/2] drm: make is_lspcon_adaptor static Sharma, Shashank
2016-10-19 11:15 ` Jani Nikula
2016-10-18 12:16 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox