From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915/backlight: handle enabled but zero duty cycle at module load Date: Thu, 25 Aug 2016 14:27:04 +0300 Message-ID: <87a8g1t7g7.fsf@intel.com> References: <1471939811-9817-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 038C86E953 for ; Thu, 25 Aug 2016 11:27:07 +0000 (UTC) In-Reply-To: <1471939811-9817-1-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMyBBdWcgMjAxNiwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gRnJvbTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh QGludGVsLmNvbT4KPgo+IERvbid0IGNvbnNpZGVyIGVuYWJsZWQgYnV0IHplcm8gZHV0eSBjeWNs ZSBiYWNrbGlnaHQgZGlzYWJsZWQuIENsYW1wCj4gbGV2ZWwgYmV0d2VlbiBtaW4gYW5kIG1heCBm b3Igc2FuaXR5Lgo+Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4KCkkgdGhpbmsgdGhpcyBpcyB0aGUgcmlnaHQgdGhpbmcgdG8gZG8uCgpJbiB0aGUg ZnV0dXJlLCBwZXJoYXBzIHdlJ2xsIHdhbnQgdG8gY2hlY2sgZm9yICFlbmFibGVkLCBhbmQgYWN0 dWFsbHkKZW5hYmxlIHRoZSBiYWNrbGlnaHQgdG9vIGlmIGJhY2tsaWdodCBpcyBwcmVzZW50IGFu ZCB0aGUgY3J0YyBpcyBhY3RpdmUuCgpQbGVhc2UganVzdCBwdXNoIHRoaXMsIGFuZCB3ZSdsbCBz ZWUgd2hhdCBoYXBwZW5zLgoKQlIsCkphbmkuCgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcGFuZWwuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+IGluZGV4IDk2YzY1ZDc3ZTg4Ni4uYzEw ZTliMDQwNWU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVs LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gQEAgLTE0MzAs MTAgKzE0MzAsMTEgQEAgc3RhdGljIGludCBscHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVjdCBpbnRl bF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXMKPiAgCXBhbmVsLT5iYWNrbGln aHQubWluID0gZ2V0X2JhY2tsaWdodF9taW5fdmJ0KGNvbm5lY3Rvcik7Cj4gIAo+ICAJdmFsID0g bHB0X2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiAtCXBhbmVsLT5iYWNrbGlnaHQubGV2ZWwg PSBpbnRlbF9wYW5lbF9jb21wdXRlX2JyaWdodG5lc3MoY29ubmVjdG9yLCB2YWwpOwo+ICsJdmFs ID0gaW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3RvciwgdmFsKTsKPiArCXBh bmVsLT5iYWNrbGlnaHQubGV2ZWwgPSBjbGFtcCh2YWwsIHBhbmVsLT5iYWNrbGlnaHQubWluLAo+ ICsJCQkJICAgICAgIHBhbmVsLT5iYWNrbGlnaHQubWF4KTsKPiAgCj4gLQlwYW5lbC0+YmFja2xp Z2h0LmVuYWJsZWQgPSAocGNoX2N0bDEgJiBCTE1fUENIX1BXTV9FTkFCTEUpICYmCj4gLQkJcGFu ZWwtPmJhY2tsaWdodC5sZXZlbCAhPSAwOwo+ICsJcGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0g cGNoX2N0bDEgJiBCTE1fUENIX1BXTV9FTkFCTEU7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBA QCAtMTQ1OSwxMSArMTQ2MCwxMyBAQCBzdGF0aWMgaW50IHBjaF9zZXR1cF9iYWNrbGlnaHQoc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBlbnVtIHBpcGUgdW51cwo+ICAJcGFuZWwt PmJhY2tsaWdodC5taW4gPSBnZXRfYmFja2xpZ2h0X21pbl92YnQoY29ubmVjdG9yKTsKPiAgCj4g IAl2YWwgPSBwY2hfZ2V0X2JhY2tsaWdodChjb25uZWN0b3IpOwo+IC0JcGFuZWwtPmJhY2tsaWdo dC5sZXZlbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZhbCk7 Cj4gKwl2YWwgPSBpbnRlbF9wYW5lbF9jb21wdXRlX2JyaWdodG5lc3MoY29ubmVjdG9yLCB2YWwp Owo+ICsJcGFuZWwtPmJhY2tsaWdodC5sZXZlbCA9IGNsYW1wKHZhbCwgcGFuZWwtPmJhY2tsaWdo dC5taW4sCj4gKwkJCQkgICAgICAgcGFuZWwtPmJhY2tsaWdodC5tYXgpOwo+ICAKPiAgCWNwdV9j dGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ICAJcGFuZWwtPmJhY2tsaWdodC5l bmFibGVkID0gKGNwdV9jdGwyICYgQkxNX1BXTV9FTkFCTEUpICYmCj4gLQkJKHBjaF9jdGwxICYg QkxNX1BDSF9QV01fRU5BQkxFKSAmJiBwYW5lbC0+YmFja2xpZ2h0LmxldmVsICE9IDA7Cj4gKwkJ KHBjaF9jdGwxICYgQkxNX1BDSF9QV01fRU5BQkxFKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+ IEBAIC0xNDk4LDkgKzE1MDEsMTEgQEAgc3RhdGljIGludCBpOXh4X3NldHVwX2JhY2tsaWdodChz dHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsIGVudW0gcGlwZSB1bnUKPiAgCXBhbmVs LT5iYWNrbGlnaHQubWluID0gZ2V0X2JhY2tsaWdodF9taW5fdmJ0KGNvbm5lY3Rvcik7Cj4gIAo+ ICAJdmFsID0gaTl4eF9nZXRfYmFja2xpZ2h0KGNvbm5lY3Rvcik7Cj4gLQlwYW5lbC0+YmFja2xp Z2h0LmxldmVsID0gaW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3RvciwgdmFs KTsKPiArCXZhbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZh bCk7Cj4gKwlwYW5lbC0+YmFja2xpZ2h0LmxldmVsID0gY2xhbXAodmFsLCBwYW5lbC0+YmFja2xp Z2h0Lm1pbiwKPiArCQkJCSAgICAgICBwYW5lbC0+YmFja2xpZ2h0Lm1heCk7Cj4gIAo+IC0JcGFu ZWwtPmJhY2tsaWdodC5lbmFibGVkID0gcGFuZWwtPmJhY2tsaWdodC5sZXZlbCAhPSAwOwo+ICsJ cGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0gdmFsICE9IDA7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4g IH0KPiBAQCAtMTUzMCwxMCArMTUzNSwxMSBAQCBzdGF0aWMgaW50IGk5NjVfc2V0dXBfYmFja2xp Z2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudQo+ICAJ cGFuZWwtPmJhY2tsaWdodC5taW4gPSBnZXRfYmFja2xpZ2h0X21pbl92YnQoY29ubmVjdG9yKTsK PiAgCj4gIAl2YWwgPSBpOXh4X2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiAtCXBhbmVsLT5i YWNrbGlnaHQubGV2ZWwgPSBpbnRlbF9wYW5lbF9jb21wdXRlX2JyaWdodG5lc3MoY29ubmVjdG9y LCB2YWwpOwo+ICsJdmFsID0gaW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3Rv ciwgdmFsKTsKPiArCXBhbmVsLT5iYWNrbGlnaHQubGV2ZWwgPSBjbGFtcCh2YWwsIHBhbmVsLT5i YWNrbGlnaHQubWluLAo+ICsJCQkJICAgICAgIHBhbmVsLT5iYWNrbGlnaHQubWF4KTsKPiAgCj4g LQlwYW5lbC0+YmFja2xpZ2h0LmVuYWJsZWQgPSAoY3RsMiAmIEJMTV9QV01fRU5BQkxFKSAmJgo+ IC0JCXBhbmVsLT5iYWNrbGlnaHQubGV2ZWwgIT0gMDsKPiArCXBhbmVsLT5iYWNrbGlnaHQuZW5h YmxlZCA9IGN0bDIgJiBCTE1fUFdNX0VOQUJMRTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBA IC0xNTYyLDEwICsxNTY4LDExIEBAIHN0YXRpYyBpbnQgdmx2X3NldHVwX2JhY2tsaWdodChzdHJ1 Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsIGVudW0gcGlwZSBwaXBlCj4gIAlwYW5lbC0+ YmFja2xpZ2h0Lm1pbiA9IGdldF9iYWNrbGlnaHRfbWluX3ZidChjb25uZWN0b3IpOwo+ICAKPiAg CXZhbCA9IF92bHZfZ2V0X2JhY2tsaWdodChkZXZfcHJpdiwgcGlwZSk7Cj4gLQlwYW5lbC0+YmFj a2xpZ2h0LmxldmVsID0gaW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3Rvciwg dmFsKTsKPiArCXZhbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3Is IHZhbCk7Cj4gKwlwYW5lbC0+YmFja2xpZ2h0LmxldmVsID0gY2xhbXAodmFsLCBwYW5lbC0+YmFj a2xpZ2h0Lm1pbiwKPiArCQkJCSAgICAgICBwYW5lbC0+YmFja2xpZ2h0Lm1heCk7Cj4gIAo+IC0J cGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0gKGN0bDIgJiBCTE1fUFdNX0VOQUJMRSkgJiYKPiAt CQlwYW5lbC0+YmFja2xpZ2h0LmxldmVsICE9IDA7Cj4gKwlwYW5lbC0+YmFja2xpZ2h0LmVuYWJs ZWQgPSBjdGwyICYgQkxNX1BXTV9FTkFCTEU7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiBAQCAt MTYwNywxMCArMTYxNCwxMSBAQCBieHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXNlZCkKPiAgCQlyZXR1cm4gLUVOT0RFVjsK PiAgCj4gIAl2YWwgPSBieHRfZ2V0X2JhY2tsaWdodChjb25uZWN0b3IpOwo+IC0JcGFuZWwtPmJh Y2tsaWdodC5sZXZlbCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3Is IHZhbCk7Cj4gKwl2YWwgPSBpbnRlbF9wYW5lbF9jb21wdXRlX2JyaWdodG5lc3MoY29ubmVjdG9y LCB2YWwpOwo+ICsJcGFuZWwtPmJhY2tsaWdodC5sZXZlbCA9IGNsYW1wKHZhbCwgcGFuZWwtPmJh Y2tsaWdodC5taW4sCj4gKwkJCQkgICAgICAgcGFuZWwtPmJhY2tsaWdodC5tYXgpOwo+ICAKPiAt CXBhbmVsLT5iYWNrbGlnaHQuZW5hYmxlZCA9IChwd21fY3RsICYgQlhUX0JMQ19QV01fRU5BQkxF KSAmJgo+IC0JCXBhbmVsLT5iYWNrbGlnaHQubGV2ZWwgIT0gMDsKPiArCXBhbmVsLT5iYWNrbGln aHQuZW5hYmxlZCA9IHB3bV9jdGwgJiBCWFRfQkxDX1BXTV9FTkFCTEU7Cj4gIAo+ICAJcmV0dXJu IDA7Cj4gIH0KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==