From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/3] drm/i915: Clean up hsw_audio_codec_enable() Date: Thu, 11 Aug 2016 10:47:06 +0300 Message-ID: <87a8gjwxvp.fsf@intel.com> References: <20160809220857.GA29783@nuc-i3427.alporthouse.com> <1470897673-29292-1-git-send-email-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 15AEC6E188 for ; Thu, 11 Aug 2016 07:47:09 +0000 (UTC) In-Reply-To: <1470897673-29292-1-git-send-email-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMSBBdWcgMjAxNiwgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLCBjb2RlIGNsZWFu IHVwIGFuZCBpbXByb3ZlZCBkZWJ1Zy4KPgo+IENocmlzIHN1Z2dlc3RlZCB0aGlzIGNvZGUgc25p cHBldCB3aGlsZSByZXZpZXdpbmcsIEkganVzdCBtYWRlIHRoaXMgaW50byBhCj4gcGF0Y2guCj4K PiBDcmVkaXRzLXRvOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBD YzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gU2lnbmVkLW9mZi1i eTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMgfCAyOCArKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAx NiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9hdWRpby5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYwo+IGluZGV4IGQz MmY1ODYuLjNlZmNlMGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXVkaW8uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiBAQCAt MjgyLDE0ICsyODIsOSBAQCBzdGF0aWMgdm9pZCBoc3dfYXVkaW9fY29kZWNfZW5hYmxlKHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5lY3Rvci0+ZGV2KTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRj ICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+ICAJZW51 bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+IC0Jc3RydWN0IGk5MTVfYXVkaW9fY29t cG9uZW50ICphY29tcCA9IGRldl9wcml2LT5hdWRpb19jb21wb25lbnQ7Cj4gIAljb25zdCB1aW50 OF90ICplbGQgPSBjb25uZWN0b3ItPmVsZDsKPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQg KmludGVsX2RpZ19wb3J0ID0KPiAtCQllbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2UpOwo+ IC0JZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+cG9ydDsKPiAgCXVpbnQzMl90IHRt cDsKPiAgCWludCBsZW4sIGk7Cj4gLQlpbnQgbiwgcmF0ZTsKPiAgCj4gIAlEUk1fREVCVUdfS01T KCJFbmFibGUgYXVkaW8gY29kZWMgb24gcGlwZSAlYywgJXUgYnl0ZXMgRUxEXG4iLAo+ICAJCSAg ICAgIHBpcGVfbmFtZShwaXBlKSwgZHJtX2VsZF9zaXplKGVsZCkpOwo+IEBAIC0zMzUsMTkgKzMz MCwyMCBAQCBzdGF0aWMgdm9pZCBoc3dfYXVkaW9fY29kZWNfZW5hYmxlKHN0cnVjdCBkcm1fY29u bmVjdG9yICpjb25uZWN0b3IsCj4gIAo+ICAJdG1wICY9IH5BVURfQ09ORklHX05fUFJPR19FTkFC TEU7Cj4gIAlpZiAoYXVkaW9fcmF0ZV9uZWVkX3Byb2coaW50ZWxfY3J0YywgYWRqdXN0ZWRfbW9k ZSkpIHsKPiAtCQlpZiAoIWFjb21wKQo+IC0JCQlyYXRlID0gMDsKPiAtCQllbHNlIGlmIChwb3J0 ID49IFBPUlRfQSAmJiBwb3J0IDw9IFBPUlRfRSkKPiArCQllbnVtIHBvcnQgcG9ydCA9IGVuY190 b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSktPnBvcnQ7Cj4gKwkJc3RydWN0IGk5MTVfYXVkaW9f Y29tcG9uZW50ICphY29tcCA9IGRldl9wcml2LT5hdWRpb19jb21wb25lbnQ7Cj4gKwkJaW50IHJh dGUsIG47CgpNb3ZpbmcgdGhlc2UgaGVyZSBpcyBwcm9iYWJseSBmaW5lLCBhbHRob3VnaCBvcmln aW5hbGx5IEkgd2FzIGhvcGluZyB3ZQp3b3VsZCBhbHdheXMgcHJvZ3JhbSB0aGUgTiwgYW5kIHRo dXMgd291bGRuJ3QgaGF2ZSB0aGlzIGlmCihhdWRpb19yYXRlX25lZWRfcHJvZyhpbnRlbF9jcnRj LCBhZGp1c3RlZF9tb2RlKSkgYmxvY2sgaGVyZSBhdCBhbGwuIFRoZQppZGVhIHdhcyB0aGF0IHdl J2QgYWx3YXlzIHVzZSB0aGUgc2FtZSBtZXRob2QgaW5zdGVhZCBvZiBsZXR0aW5nIHRoZSBodwpz ZXQgaXQgYXV0b21hdGljYWxseSBmb3Igc29tZSByYXRlcywgYW5kIG1hbnVhbGx5IHNldHRpbmcg b3RoZXJzLgoKPiArCj4gKwkJcmF0ZSA9IDA7Cj4gKwkJaWYgKGFjb21wICYmIHBvcnQgPj0gUE9S VF9BICYmIHBvcnQgPD0gUE9SVF9FKSB7Cj4gIAkJCXJhdGUgPSBhY29tcC0+YXVkX3NhbXBsZV9y YXRlW3BvcnRdOwo+IC0JCWVsc2Ugewo+IC0JCQlEUk1fRVJST1IoImludmFsaWQgcG9ydDogJWRc biIsIHBvcnQpOwoKSSB0aGluayBJIG1heSBoYXZlIHNlZW4gdGhlc2UgaW4gc29tZSBkbWVzZ3Mg aW4gb3RoZXJ3aXNlIHVucmVsYXRlZApidWdzLiBJJ2QgbGlrZSB0byBwcmVzZXJ2ZSB0aGlzIGF0 IGxlYXN0IGFzIGEgZGVidWcgYnJlYWRjcnVtYi4KCj4gLQkJCXJhdGUgPSAwOwo+ICsKPiArCQkJ biA9IGF1ZGlvX2NvbmZpZ19nZXRfbihhZGp1c3RlZF9tb2RlLCByYXRlKTsKPiArCQkJRFJNX0RF QlVHX0tNUygicG9ydCAlZCBhdWRpbyByYXRlICVkID0+IE49JXhcbiIsCj4gKwkJCQkgICAgICBw b3J0LCByYXRlLCBuKTsKPiArCQkJaWYgKG4pCj4gKwkJCQl0bXAgPSBhdWRpb19jb25maWdfc2V0 dXBfbl9yZWcobiwgdG1wKTsKPiAgCQl9Cj4gLQkJbiA9IGF1ZGlvX2NvbmZpZ19nZXRfbihhZGp1 c3RlZF9tb2RlLCByYXRlKTsKPiAtCQlpZiAobiAhPSAwKQo+IC0JCQl0bXAgPSBhdWRpb19jb25m aWdfc2V0dXBfbl9yZWcobiwgdG1wKTsKPiAtCQllbHNlCj4gLQkJCURSTV9ERUJVR19LTVMoIm5v IHN1aXRhYmxlIE4gdmFsdWUgaXMgZm91bmRcbiIpOwoKU2FtZSBoZXJlLCBJJ2QgbGlrZSB0byBw cmVzZXJ2ZSB0aGUgZGVidWcuCgo+ICAJfQo+ICAKPiAgCUk5MTVfV1JJVEUoSFNXX0FVRF9DRkco cGlwZSksIHRtcCk7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=