public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids
@ 2016-06-13 12:38 Gerd Hoffmann
  2016-06-13 13:05 ` ✗ Ro.CI.BAT: warning for drm/i915: use #defines for qemu subsystem ids (rev2) Patchwork
  2016-06-13 13:19 ` [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Jani Nikula
  0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2016-06-13 12:38 UTC (permalink / raw)
  To: dri-devel
  Cc: Daniel Vetter,
	open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list,
	Gerd Hoffmann

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index f313b4d..3099390 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -515,8 +515,10 @@ void intel_detect_pch(struct drm_device *dev)
 			} else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) ||
 				   (id == INTEL_PCH_P3X_DEVICE_ID_TYPE) ||
 				   ((id == INTEL_PCH_QEMU_DEVICE_ID_TYPE) &&
-				    pch->subsystem_vendor == 0x1af4 &&
-				    pch->subsystem_device == 0x1100)) {
+				    pch->subsystem_vendor ==
+					    PCI_SUBVENDOR_ID_REDHAT_QUMRANET &&
+				    pch->subsystem_device ==
+					    PCI_SUBDEVICE_ID_QEMU)) {
 				dev_priv->pch_type = intel_virt_detect_pch(dev);
 			} else
 				continue;
-- 
1.8.3.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✗ Ro.CI.BAT: warning for drm/i915: use #defines for qemu subsystem ids (rev2)
  2016-06-13 12:38 [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Gerd Hoffmann
@ 2016-06-13 13:05 ` Patchwork
  2016-06-13 13:19 ` [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-06-13 13:05 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: use #defines for qemu subsystem ids (rev2)
URL   : https://patchwork.freedesktop.org/series/2918/
State : warning

== Summary ==

Series 2918v2 drm/i915: use #defines for qemu subsystem ids
http://patchwork.freedesktop.org/api/1.0/series/2918/revisions/2/mbox

Test kms_force_connector_basic:
        Subgroup force-connector-state:
                skip       -> PASS       (ro-ivb2-i7-3770)
        Subgroup force-edid:
                skip       -> PASS       (ro-ivb2-i7-3770)
        Subgroup prune-stale-modes:
                skip       -> PASS       (ro-ivb2-i7-3770)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-b-frame-sequence:
                pass       -> SKIP       (fi-skl-i5-6260u)
        Subgroup suspend-read-crc-pipe-b:
                skip       -> DMESG-WARN (ro-bdw-i5-5250u)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> SKIP       (ro-bdw-i5-5250u)

fi-bdw-i7-5557u  total:213  pass:201  dwarn:0   dfail:0   fail:0   skip:12 
fi-skl-i5-6260u  total:213  pass:201  dwarn:0   dfail:0   fail:0   skip:12 
fi-skl-i7-6700k  total:213  pass:188  dwarn:0   dfail:0   fail:0   skip:25 
fi-snb-i7-2600   total:213  pass:174  dwarn:0   dfail:0   fail:0   skip:39 
ro-bdw-i5-5250u  total:213  pass:197  dwarn:2   dfail:0   fail:0   skip:14 
ro-bdw-i7-5557U  total:213  pass:198  dwarn:0   dfail:0   fail:0   skip:15 
ro-bdw-i7-5600u  total:213  pass:185  dwarn:0   dfail:0   fail:0   skip:28 
ro-bsw-n3050     total:213  pass:172  dwarn:0   dfail:0   fail:2   skip:39 
ro-byt-n2820     total:213  pass:173  dwarn:0   dfail:0   fail:3   skip:37 
ro-hsw-i3-4010u  total:213  pass:190  dwarn:0   dfail:0   fail:0   skip:23 
ro-hsw-i7-4770r  total:213  pass:190  dwarn:0   dfail:0   fail:0   skip:23 
ro-ilk-i7-620lm  total:177  pass:120  dwarn:2   dfail:2   fail:1   skip:51 
ro-ilk1-i5-650   total:208  pass:150  dwarn:0   dfail:0   fail:1   skip:57 
ro-ivb-i7-3770   total:213  pass:181  dwarn:0   dfail:0   fail:0   skip:32 
ro-ivb2-i7-3770  total:213  pass:185  dwarn:0   dfail:0   fail:0   skip:28 
ro-skl3-i5-6260u total:213  pass:201  dwarn:1   dfail:0   fail:0   skip:11 
ro-snb-i7-2620M  total:213  pass:174  dwarn:0   dfail:0   fail:1   skip:38 
fi-hsw-i7-4770k failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1174/

f80cfb4 drm-intel-nightly: 2016y-06m-13d-10h-41m-19s UTC integration manifest
ddb6763 drm/i915: use #defines for qemu subsystem ids

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids
  2016-06-13 12:38 [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Gerd Hoffmann
  2016-06-13 13:05 ` ✗ Ro.CI.BAT: warning for drm/i915: use #defines for qemu subsystem ids (rev2) Patchwork
@ 2016-06-13 13:19 ` Jani Nikula
  2016-06-13 14:45   ` Jani Nikula
  1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2016-06-13 13:19 UTC (permalink / raw)
  To: dri-devel
  Cc: David Airlie, Daniel Vetter,
	open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...), linux-kernel@vger.kernel.org (open list),
	Gerd Hoffmann

On Mon, 13 Jun 2016, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/i915_drv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f313b4d..3099390 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -515,8 +515,10 @@ void intel_detect_pch(struct drm_device *dev)
>  			} else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) ||
>  				   (id == INTEL_PCH_P3X_DEVICE_ID_TYPE) ||
>  				   ((id == INTEL_PCH_QEMU_DEVICE_ID_TYPE) &&
> -				    pch->subsystem_vendor == 0x1af4 &&
> -				    pch->subsystem_device == 0x1100)) {
> +				    pch->subsystem_vendor ==
> +					    PCI_SUBVENDOR_ID_REDHAT_QUMRANET &&
> +				    pch->subsystem_device ==
> +					    PCI_SUBDEVICE_ID_QEMU)) {
>  				dev_priv->pch_type = intel_virt_detect_pch(dev);
>  			} else
>  				continue;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids
  2016-06-13 13:19 ` [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Jani Nikula
@ 2016-06-13 14:45   ` Jani Nikula
  0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-06-13 14:45 UTC (permalink / raw)
  To: dri-devel
  Cc: Daniel Vetter,
	open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...), linux-kernel@vger.kernel.org (open list),
	Gerd Hoffmann

On Mon, 13 Jun 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 13 Jun 2016, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

And pushed to drm-intel-next-queued, thanks for the patch.

BR,
Jani.

>
>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index f313b4d..3099390 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -515,8 +515,10 @@ void intel_detect_pch(struct drm_device *dev)
>>  			} else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) ||
>>  				   (id == INTEL_PCH_P3X_DEVICE_ID_TYPE) ||
>>  				   ((id == INTEL_PCH_QEMU_DEVICE_ID_TYPE) &&
>> -				    pch->subsystem_vendor == 0x1af4 &&
>> -				    pch->subsystem_device == 0x1100)) {
>> +				    pch->subsystem_vendor ==
>> +					    PCI_SUBVENDOR_ID_REDHAT_QUMRANET &&
>> +				    pch->subsystem_device ==
>> +					    PCI_SUBDEVICE_ID_QEMU)) {
>>  				dev_priv->pch_type = intel_virt_detect_pch(dev);
>>  			} else
>>  				continue;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-13 14:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-13 12:38 [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Gerd Hoffmann
2016-06-13 13:05 ` ✗ Ro.CI.BAT: warning for drm/i915: use #defines for qemu subsystem ids (rev2) Patchwork
2016-06-13 13:19 ` [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids Jani Nikula
2016-06-13 14:45   ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox