From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/opregion: remove unnecessary ifdefs on CONFIG_ACPI
Date: Tue, 12 Apr 2016 15:20:08 +0300 [thread overview]
Message-ID: <87a8kzt3wn.fsf@intel.com> (raw)
In-Reply-To: <20160412103626.GO20240@nuc-i3427.alporthouse.com>
On Tue, 12 Apr 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Apr 08, 2016 at 05:59:49PM +0300, Jani Nikula wrote:
>> The whole file is ignored on CONFIG_ACPI=n.
>
> That's an issue as we can't then acquire the opregion->vbt (which itself
> is not acpi dependent). Shrug no modern system can boot without acpi (at
> least not if you want more than cpu etc), so I guess we also don't care
> that much?
Interesting, I thought we shouldn't touch ACPI OpRegion for
CONFIG_ACPI=n, but seems that this was changed only in
commit 27d50c82714f6477ac690034b37d202f76eb4f70
Author: Lv Zheng <lv.zheng@intel.com>
Date: Fri Dec 6 16:52:05 2013 +0800
ACPI / i915: Fix incorrect <acpi/acpi.h> inclusions via <linux/acpi_io.h>
So this patch here doesn't change the fact, and since there hasn't been
complaints after the above commit, I wouldn't worry too much.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-12 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 14:59 [PATCH] drm/i915/opregion: remove unnecessary ifdefs on CONFIG_ACPI Jani Nikula
2016-04-08 15:55 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-12 10:33 ` [PATCH] " Ander Conselvan De Oliveira
2016-04-12 10:36 ` Chris Wilson
2016-04-12 12:20 ` Jani Nikula [this message]
2016-04-13 13:01 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8kzt3wn.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox