From: Jani Nikula <jani.nikula@linux.intel.com>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Akash Goel <akash.goel@intel.com>
Subject: Re: [PATCH] drm/i915: Log correct start and length in pte map trace
Date: Wed, 14 Oct 2015 10:23:44 +0300 [thread overview]
Message-ID: <87a8rl3ocf.fsf@intel.com> (raw)
In-Reply-To: <1444731879-3858-1-git-send-email-michel.thierry@intel.com>
On Tue, 13 Oct 2015, Michel Thierry <michel.thierry@intel.com> wrote:
> The PTE_map trace added in commit 4c06ec8d13d2 ("drm/i915/gen8: Add
> dynamic page trace events") was using the full start and length values,
> instead of the page directory ones.
>
> Since this is just a trace, I don't think it requires cc'ing stable.
Especially not since 4c06ec8d13d2 is not even in Linus' tree yet.
BR,
Jani.
>
> Cc: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e81990d..642fe87 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1305,8 +1305,8 @@ static int gen8_alloc_va_range_3lvl(struct i915_address_space *vm,
> page_directory[pde] = gen8_pde_encode(px_dma(pt),
> I915_CACHE_LLC);
> trace_i915_page_table_entry_map(&ppgtt->base, pde, pt,
> - gen8_pte_index(start),
> - gen8_pte_count(start, length),
> + gen8_pte_index(pd_start),
> + gen8_pte_count(pd_start, pd_len),
> GEN8_PTES);
>
> /* NB: We haven't yet mapped ptes to pages. At this
> --
> 2.6.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-10-14 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 10:24 [PATCH] drm/i915: Log correct start and length in pte map trace Michel Thierry
2015-10-14 7:23 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8rl3ocf.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox