From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Adam Jackson <ajax@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/edid: Fix up clock for CEA/HDMI modes specified via detailed timings
Date: Fri, 09 Oct 2015 13:54:58 +0300 [thread overview]
Message-ID: <87a8rs71ml.fsf@intel.com> (raw)
In-Reply-To: <20151008165516.GF3383@phenom.ffwll.local>
On Thu, 08 Oct 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Oct 08, 2015 at 12:22:31PM -0400, Adam Jackson wrote:
>> On Thu, 2015-10-08 at 11:43 +0300, ville.syrjala@linux.intel.com wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > EDID detailed timings have a resolution of 10kHz for the pixel clock, so
>> > they can't represent certain CEA/HDMI modes accurately. If we see a mode
>> > coming in via detailed timings which otherwise matches one of the
>> > CEA/HDMI modes except the clock is just a bit off, let's assume that the
>> > intention was for that mode to be one of the CEA/HDMI modes and go ahead
>> > and fix up the clock to match the CEA/HDMI spec exactly (well, as close
>> > as we can get with the 1 kHz resolution we use).
>> >
>> > This should help code that's looking for an exact clock match (eg. i915
>> > audio N/CTS setup).
>>
>> Looks like a sane set of changes. Series is:
>>
>> Reviewed-by: Adam Jackson <ajax@redhat.com>
>
> Merged the first two patches to drm-misc (the later one has conflicts with
> the lack of drm-intel-next, so can pull it in only after a rebase).
This is needed in v4.3.
BR,
Jani.
>
> Thanks, Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-09 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 8:43 [PATCH 1/3] drm/edid: Fix up clock for CEA/HDMI modes specified via detailed timings ville.syrjala
2015-10-08 8:43 ` [PATCH 2/3] drm/edid: Round to closest when computing the CEA/HDMI alternate clock ville.syrjala
2015-10-08 8:43 ` [PATCH 3/3] drm/i915: Use round to closest when computing the CEA 1.001 pixel clocks ville.syrjala
2015-10-08 16:22 ` [PATCH 1/3] drm/edid: Fix up clock for CEA/HDMI modes specified via detailed timings Adam Jackson
2015-10-08 16:55 ` Daniel Vetter
2015-10-09 10:54 ` Jani Nikula [this message]
2015-10-19 15:56 ` [Intel-gfx] " Daniel Vetter
2015-10-20 6:31 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8rs71ml.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ajax@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).