From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vijay Purushothaman <vijay.a.purushothaman@linux.intel.com>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
ville.syrjala@intel.com
Subject: Re: [PATCH] drm/i915: More DPIO magic for CHV HDMI & DP
Date: Tue, 10 Feb 2015 14:43:20 +0200 [thread overview]
Message-ID: <87a90muec7.fsf@intel.com> (raw)
In-Reply-To: <1422556313-3198-1-git-send-email-vijay.a.purushothaman@linux.intel.com>
On Thu, 29 Jan 2015, Vijay Purushothaman <vijay.a.purushothaman@linux.intel.com> wrote:
> This patch implements latest changes in Gain, lock threshold and integer
> co-efficient values using sideband r/w. Without these changes there will
> be signal integrity issues for both HDMI and DP.
Vijay, are you planning on sending a v2 of the patch? I'd like to see if
it helps with bugs
https://bugs.freedesktop.org/show_bug.cgi?id=83870
https://bugs.freedesktop.org/show_bug.cgi?id=84304
BR,
Jani.
>
> Change-Id: I7b7151b5ab3a52c4c912cf10602c69a7d1a70222
> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@linux.intel.com>
> Tested-by: Hong Liu <hong.liu@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 31 ++++++++++++++++
> drivers/gpu/drm/i915/intel_display.c | 67 ++++++++++++++++++++++++----------
> 2 files changed, 79 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 137c5e0..2b3f065 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1049,6 +1049,37 @@ enum punit_power_well {
> #define DPIO_CHV_PROP_COEFF_SHIFT 0
> #define CHV_PLL_DW6(ch) _PIPE(ch, _CHV_PLL_DW6_CH0, _CHV_PLL_DW6_CH1)
>
> +#define _CHV_PLL_DW7_CH0 0x801c
> +#define _CHV_PLL_DW7_CH1 0x803c
> +#define CHV_PLL_DW7(ch) _PIPE(ch, _CHV_PLL_DW7_CH0, _CHV_PLL_DW7_CH1)
> +
> +#define _CHV_PLL_DW8_CH0 0x8020
> +#define _CHV_PLL_DW8_CH1 0x81A0
> +#define CHV_PLL_DW8(ch) _PIPE(ch, _CHV_PLL_DW8_CH0, _CHV_PLL_DW8_CH1)
> +
> +#define _CHV_PLL_DW9_CH0 0x8024
> +#define _CHV_PLL_DW9_CH1 0x81A4
> +#define DPIO_CHV_INT_LOCK_THRESHOLD_SHIFT 1 /* 3 bits */
> +#define DPIO_CHV_INT_LOCK_THRESHOLD_SEL_COARSE 1 /* 1: coarse & 0 : fine */
> +#define CHV_PLL_DW9(ch) _PIPE(ch, _CHV_PLL_DW9_CH0, _CHV_PLL_DW9_CH1)
> +
> +#define _CHV_PLL_DW10_CH0 0x8040
> +#define _CHV_PLL_DW10_CH1 0x8060
> +#define CHV_PLL_DW10(ch) _PIPE(ch, _CHV_PLL_DW10_CH0, _CHV_PLL_DW10_CH1)
> +
> +#define _CHV_PLL_DW11_BCAST 0xC044
> +#define _CHV_PLL_DW11_CH0 0x8044
> +#define _CHV_PLL_DW11_CH1 0x8064
> +#define CHV_PLL_DW11(ch) _PIPE(ch, _CHV_PLL_DW11_CH0, _CHV_PLL_DW11_CH1)
> +
> +#define _CHV_PLL_DW12_CH0 0x8048
> +#define _CHV_PLL_DW12_CH1 0x8068
> +#define CHV_PLL_DW12(ch) _PIPE(ch, _CHV_PLL_DW12_CH0, _CHV_PLL_DW12_CH1)
> +
> +#define _CHV_PLL_DW13_CH0 0x804C
> +#define _CHV_PLL_DW13_CH1 0x806C
> +#define CHV_PLL_DW13(ch) _PIPE(ch, _CHV_PLL_DW13_CH0, _CHV_PLL_DW13_CH1)
> +
> #define _CHV_CMN_DW5_CH0 0x8114
> #define CHV_BUFRIGHTENA1_DISABLE (0 << 20)
> #define CHV_BUFRIGHTENA1_NORMAL (1 << 20)
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c362d11e..fb27faf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6576,9 +6576,9 @@ static void chv_update_pll(struct intel_crtc *crtc)
> int pipe = crtc->pipe;
> int dpll_reg = DPLL(crtc->pipe);
> enum dpio_channel port = vlv_pipe_to_channel(pipe);
> - u32 loopfilter, intcoeff;
> + u32 loopfilter, tribuf_calcntr;
> u32 bestn, bestm1, bestm2, bestp1, bestp2, bestm2_frac;
> - int refclk;
> + int vco;
>
> crtc->config.dpll_hw_state.dpll = DPLL_SSC_REF_CLOCK_CHV |
> DPLL_REFA_CLK_ENABLE_VLV | DPLL_VGA_MODE_DIS |
> @@ -6595,6 +6595,7 @@ static void chv_update_pll(struct intel_crtc *crtc)
> bestm2 = crtc->config.dpll.m2 >> 22;
> bestp1 = crtc->config.dpll.p1;
> bestp2 = crtc->config.dpll.p2;
> + vco = crtc->config.dpll.vco;
>
> /*
> * Enable Refclk and SSC
> @@ -6619,31 +6620,59 @@ static void chv_update_pll(struct intel_crtc *crtc)
> DPIO_CHV_M1_DIV_BY_2 |
> 1 << DPIO_CHV_N_DIV_SHIFT);
>
> - /* M2 fraction division */
> - vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW2(port), bestm2_frac);
> + if (bestm2_frac) {
> + /* M2 fraction division */
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW2(port), bestm2_frac);
> +
> + /* M2 fraction division enable */
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW3(port),
> + vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW3(port)) &
> + DPIO_CHV_FRAC_DIV_EN);
> +
> + /* Program digital lock detect threshold */
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW9(port),
> + vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW9(port)) |
> + (0x5 << DPIO_CHV_INT_LOCK_THRESHOLD_SHIFT));
> + } else {
> + /* M2 fraction division disable */
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW3(port),
> + vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW3(port)) &
> + ~(DPIO_CHV_FRAC_DIV_EN));
>
> - /* M2 fraction division enable */
> - vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW3(port),
> - DPIO_CHV_FRAC_DIV_EN |
> - (2 << DPIO_CHV_FEEDFWD_GAIN_SHIFT));
> + /* Program digital lock detect threshold */
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW9(port),
> + vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW9(port)) |
> + (0x5 << DPIO_CHV_INT_LOCK_THRESHOLD_SHIFT) |
> + DPIO_CHV_INT_LOCK_THRESHOLD_SEL_COARSE);
> + }
>
> /* Loop filter */
> - refclk = i9xx_get_refclk(&crtc->base, 0);
> - loopfilter = 5 << DPIO_CHV_PROP_COEFF_SHIFT |
> - 2 << DPIO_CHV_GAIN_CTRL_SHIFT;
> - if (refclk == 100000)
> - intcoeff = 11;
> - else if (refclk == 38400)
> - intcoeff = 10;
> + if (vco == 540000)
> + loopfilter = 0x10803;
> + else if (vco <= 620000)
> + loopfilter = 0x30B05;
> + else if (vco <= 648000)
> + loopfilter = 0x30904;
> + else
> + loopfilter = 0x10803;
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW6(port),
> + ((vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW6(port)) &
> + 0xFF000000) | loopfilter));
> +
> + if (vco <= 620000)
> + tribuf_calcntr = 0x9;
> + else if (vco <= 648000)
> + tribuf_calcntr = 0x8;
> else
> - intcoeff = 9;
> - loopfilter |= intcoeff << DPIO_CHV_INT_COEFF_SHIFT;
> - vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW6(port), loopfilter);
> + tribuf_calcntr = 0;
> + vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW8(port),
> + ((vlv_dpio_read(dev_priv, pipe, CHV_PLL_DW8(port)) &
> + 0xFFFFFF00) | tribuf_calcntr));
>
> /* AFC Recal */
> vlv_dpio_write(dev_priv, pipe, CHV_CMN_DW14(port),
> vlv_dpio_read(dev_priv, pipe, CHV_CMN_DW14(port)) |
> - DPIO_AFC_RECAL);
> + DPIO_AFC_RECAL | DPIO_DCLKP_EN);
>
> mutex_unlock(&dev_priv->dpio_lock);
> }
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-10 12:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:31 [PATCH] drm/i915: More DPIO magic for CHV HDMI & DP Vijay Purushothaman
2015-01-30 11:09 ` Ville Syrjälä
2015-02-12 13:19 ` Purushothaman, Vijay A
2015-02-16 9:37 ` [v2 0/5] " Vijay Purushothaman
2015-02-16 9:37 ` [v2 1/5] drm/i915: Add new PHY reg definitions for lock threshold Vijay Purushothaman
2015-02-16 11:21 ` Ville Syrjälä
2015-02-16 9:37 ` [v2 2/5] drm/i915: Limit max VCO supported in CHV to 6.48GHz Vijay Purushothaman
2015-02-16 11:21 ` Ville Syrjälä
2015-02-23 16:13 ` Daniel Vetter
2015-03-03 14:57 ` Purushothaman, Vijay A
2015-03-05 15:52 ` Daniel Vetter
2015-03-05 15:59 ` Ville Syrjälä
2015-02-16 9:38 ` [v2 3/5] drm/i915: Disable M2 frac division for integer case Vijay Purushothaman
2015-02-16 11:23 ` Ville Syrjälä
2015-03-03 15:11 ` [PATCH 1/3] " Vijay Purushothaman
2015-03-03 15:36 ` Ville Syrjälä
2015-03-05 13:49 ` Purushothaman, Vijay A
2015-03-05 14:00 ` Vijay Purushothaman
2015-03-10 9:23 ` Daniel Vetter
2015-02-16 9:38 ` [v2 4/5] drm/i915: Initialize CHV digital lock detect threshold Vijay Purushothaman
2015-02-16 11:27 ` Ville Syrjälä
2015-03-03 15:13 ` [PATCH 2/3] " Vijay Purushothaman
2015-03-03 15:38 ` Ville Syrjälä
2015-03-05 13:50 ` Purushothaman, Vijay A
2015-03-05 14:02 ` Vijay Purushothaman
2015-02-16 9:38 ` [v2 5/5] drm/i915: Update prop, int co-eff and gain threshold for CHV Vijay Purushothaman
2015-02-16 11:32 ` Ville Syrjälä
2015-03-03 14:59 ` Purushothaman, Vijay A
2015-03-03 15:14 ` [PATCH 3/3] " Vijay Purushothaman
2015-03-03 15:45 ` Ville Syrjälä
2015-03-05 14:03 ` Vijay Purushothaman
2015-03-05 14:35 ` Ville Syrjälä
2015-02-23 16:13 ` [v2 0/5] More DPIO magic for CHV HDMI & DP Daniel Vetter
2015-02-10 12:43 ` Jani Nikula [this message]
2015-02-12 13:20 ` [PATCH] drm/i915: " Purushothaman, Vijay A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a90muec7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vijay.a.purushothaman@linux.intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox